From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42BACC4829A for ; Tue, 13 Feb 2024 15:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+yrWW5mJQdMU0uTwl0LZT1F7tA1C+uMFtEQXjsWSkUE=; b=n/pXHcSJWtnzq+ wPR+Elga0uKaMSNGm7j2SFpybp/+PpJJj+JzUYR8uiy8qeZJC7ha1iMtUgbN9YtBVjWuVuy86dfUT aRnfO7d//PCEVdN5jqLrluf7eh7P5Yl9jCwo/bXHYp994t4OtPRHjGqdyPZMs6+SfdgU2wFZf3MFS EaJNIirkPNIB6p16lHfFKnLglSK0VF7tdvS7aP/Q2Hkj5cNvPZB7O+9gXluADqcUez4N+Y+Yoonw+ QcxyivYdkVFV9jz/JS0HbEvxBZ6xyI87L3o8sszAYbP/EWDJInbY2cANWvEZ3zZcWeql/RTAOWKOW p9fxFGcuBeOq3tEcBeAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZuwm-00000009o9V-4C5C; Tue, 13 Feb 2024 15:43:49 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZuwk-00000009o7l-3pzl for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 15:43:48 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-56037115bb8so11536a12.0 for ; Tue, 13 Feb 2024 07:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707839025; x=1708443825; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bk1NS0qtruMcjKHBcgzBmeFEQhZuiLsEvlLQjVfdIzQ=; b=hx2p7f00r0PjlJgKYvXSMM6iApF/lf7ox5FtVx3Gi3/vnIBuuO4lONOys3G1gP7pmT lwnoNDUEdEdyQEUB5d2Wef88Y9O9+kZewbacT1dgUDiY9i/ZuuxDkI6/Icx66f5w7BDP 9S9PMlUbx7ureLs0014M3TrPB3cjcR3nKmzZ57GXgrwU7kMT5QysjTG+fy1iISC8jFYM +bZgPdho6ooCZNVrWjjO5ZY8X1z2rdnUsMsls76yVZTPwWE6ObA9E+A6BF4l6PXkptdb LXOixHHcCTwF3xw05V6ZMpugEvMlvtuAhK3xw8LzY0y5VDXSDC3wNNDKRRoRzDxUWa9q op1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707839025; x=1708443825; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bk1NS0qtruMcjKHBcgzBmeFEQhZuiLsEvlLQjVfdIzQ=; b=xFxeJtaWaIHIDRBiZX8Q4i0ugbOx/UBHSZxTr1RzSVzpgX+gqNGP5ShEJuTQktrdDG lp0prhgFOaxnEBPlZzoLiVuP51hJzJeyW+4/x+AnCUTe3BUSUn8XlJ72zv9XMODHCEMt vIgq8bp4AbOKnqZWWb5XiR+6qBENnvsk/enO9OiO4uNaAVydAepdOZ2fHiNvcsdEYVxS FjJIdmxsoufrKP44+SpHyXYYJYUhwVHtfaD3INhmVwxpUbiZalDrTz0CsEtYFtgeg18w xg3shLe+bmZEMkKrVNwqLh4d8Rd3bJwrn5l4rOHy4xukcpARYC/yO796nrsuzia3Wobz blvw== X-Forwarded-Encrypted: i=1; AJvYcCV6+JSYUUZy0DkVsti+lz8MAhuHsAkpNasE9u7hnhjEF7HbzkVGRygILsogHbzM20HVCow3D8eTpEA8uWCwLfHeiguHQ37jrNGPrJd+N/9acKGytLE= X-Gm-Message-State: AOJu0YzREnJXvursSkG+1ber1MYMHNwjrlb5Gtf0gYJZtDqXulL0aQYD aGk8ybrweKvXfyyz0M8+ZNnhL3Uk9zn8YyR2Am3+QN/39vOnYzRiKUzK394U+g== X-Google-Smtp-Source: AGHT+IEDuFFGUViGZf1sivuihjVwzz8vwZE2+7laoVfrhpOcs8/51AaEx5/z7DwuCk9g7hiBMa6/Ow== X-Received: by 2002:a50:f61e:0:b0:562:b30:fc90 with SMTP id c30-20020a50f61e000000b005620b30fc90mr85478edn.3.1707839024972; Tue, 13 Feb 2024 07:43:44 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXkyeXKE7DKbH/TjbebFN18vb0CDgNTI8e+gyC5f/BREAF8H1ZkgvYFZmTLWWse+vAq5OhqP5L7sSMKWKSivXZS5ryVxvgCxgQK2vTy/UlMuSyCssNfdfuVAMA+xA24FpE3mG/kh4LnPYCthi3LrlOYarLKZWecppbJHLPus+On4RnZplKsvfLrGKz+9y9HGQrKXkYXMzocs897epeaLvlfuLnmX7Z0Y4P5tbvHRyGevaR0XuAqz26daTzMOcBcOy085KdYMfc4+3t7qY/71xh/zjzjQYi0Rij4YaYYrPk8bzvw7F4Q3emWb6NDhd5L2wNe28MJKlnEJwRDA3bsxigSMnAjNVNulVzE0WQX/1H0k1pp1JCCXNhnAjR+DEDk2qU5G1s8tkA79I7PT054CfY488F+r4OtQDqtkAo0tG2y3TWHbusyPPfvbfHW8kq7AqsDjlmbcKVXrLAKfP2izQIjZjho6xP5wCINi1/1YqxrAzJSx525mg== Received: from google.com (185.83.140.34.bc.googleusercontent.com. [34.140.83.185]) by smtp.gmail.com with ESMTPSA id un6-20020a170907cb8600b00a3cfb02c12bsm829998ejc.79.2024.02.13.07.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 07:43:44 -0800 (PST) Date: Tue, 13 Feb 2024 15:43:40 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Lu Baolu , Jean-Philippe Brucker , Joerg Roedel , Moritz Fischer , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameer Kolothum , Zhangfei Gao Subject: Re: [PATCH v5 10/17] iommu/arm-smmu-v3: Pass smmu_domain to arm_enable/disable_ats() Message-ID: References: <0-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> <10-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <10-v5-cd1be8dd9c71+3fa-smmuv3_newapi_p1_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_074346_980172_1484877D X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 06, 2024 at 11:12:47AM -0400, Jason Gunthorpe wrote: > The caller already has the domain, just pass it in. A following patch will > remove master->domain. > > Tested-by: Shameer Kolothum > Tested-by: Nicolin Chen > Tested-by: Moritz Fischer > Reviewed-by: Nicolin Chen > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 2a6ac0af932c54..133f13f33df124 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -2474,12 +2474,12 @@ static bool arm_smmu_ats_supported(struct arm_smmu_master *master) > return dev_is_pci(dev) && pci_ats_supported(to_pci_dev(dev)); > } > > -static void arm_smmu_enable_ats(struct arm_smmu_master *master) > +static void arm_smmu_enable_ats(struct arm_smmu_master *master, > + struct arm_smmu_domain *smmu_domain) > { > size_t stu; > struct pci_dev *pdev; > struct arm_smmu_device *smmu = master->smmu; > - struct arm_smmu_domain *smmu_domain = master->domain; > > /* Don't enable ATS at the endpoint if it's not enabled in the STE */ > if (!master->ats_enabled) > @@ -2495,10 +2495,9 @@ static void arm_smmu_enable_ats(struct arm_smmu_master *master) > dev_err(master->dev, "Failed to enable ATS (STU %zu)\n", stu); > } > > -static void arm_smmu_disable_ats(struct arm_smmu_master *master) > +static void arm_smmu_disable_ats(struct arm_smmu_master *master, > + struct arm_smmu_domain *smmu_domain) > { > - struct arm_smmu_domain *smmu_domain = master->domain; > - > if (!master->ats_enabled) > return; > > @@ -2567,7 +2566,7 @@ static void arm_smmu_detach_dev(struct arm_smmu_master *master) > if (!smmu_domain) > return; > > - arm_smmu_disable_ats(master); > + arm_smmu_disable_ats(master, smmu_domain); > > spin_lock_irqsave(&smmu_domain->devices_lock, flags); > list_del(&master->domain_head); > @@ -2689,7 +2688,7 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) > break; > } > > - arm_smmu_enable_ats(master); > + arm_smmu_enable_ats(master, smmu_domain); > goto out_unlock; > > out_list_del: > -- > 2.43.0 > Reviewed-by: Mostafa Saleh Thanks, Mostafa _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel