From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C793BC48BEB for ; Wed, 14 Feb 2024 10:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0SmxnwTTI2QRbBUvJxt3hqjQxAS55tdXZhymG2YJCSQ=; b=WRL/UPBjUeJWUp GPeG1XTcF6+8kPa8ouzKrW5WAHHz63inhEyLcijeQ1UN8vahV2iwvL5sm6aOan7PS477pKHNynGns aIJgXerSNVTaY1gvFPTNuMrMM2bntaU3k04ldj8Glpfswnrr4D54n389XYxTsMImX9Gy85MXpLXBf JGbe0E0s5ajz2aIMm9p9ORNiV6jtLhk9WEKxOXWCtrM73uJUMEc1PVA3KkAjJKq3VSDnxabfY4KbA BaEHF5bqx+PWK+dAq5qDAU7IwK1vyn8SevT3Ps9eEEmp+FYEZesraMzQ9HEjT50f416f4HkOgR5Xx bejhGiRtF4xOiza6OGmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raCfP-0000000CYGM-1yR6; Wed, 14 Feb 2024 10:39:03 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1raCfM-0000000CYFd-33PH for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2024 10:39:02 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 86E53618B6; Wed, 14 Feb 2024 10:38:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55909C433C7; Wed, 14 Feb 2024 10:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707907139; bh=eslzQormGDUUKR6M3wUfA/wR65g2VVIMI2OcUV5+luQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NM4tcHcenWq1MQ46lCcjZguB2y0u9a08wBEfpVvvyTs7aHG6ltzW76Dp3veftpT3j i1Z8OUTTxKwVUAmyDMA+HXFG+VHMfUSpBXFYQKnXtfp4zAw9tSsPC4LsKRiXuq2zAg HvqopQ1KrOMmaeAddUivvw1SPeSBFS4rs/JYB6OWbu8LyMbywWfLlGHwIwSoPCUba+ CR/KZxC/S7C6BvcQ6xEq1ZAT/XwXhgiHFAmVMnZNvfQpiBQ54hkBW5XE+iCSel8XF/ fPXVUiky2QMlDUFAJiVqHbMLhldLNckU/yM4uw7ip+kHMlzdMUBZ1fj64JKT3Rpf6g dEPOCUfNAx76A== Date: Wed, 14 Feb 2024 11:38:47 +0100 From: Niklas Cassel To: Kishon Vijay Abraham I Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Srikanth Thokala , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , Kishon Vijay Abraham I , Damien Le Moal , Frank Li , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, ntb@lists.linux.dev Subject: Re: [PATCH 0/2] PCI endpoint BAR hardware description cleanup Message-ID: References: <20240210012634.600301-1-cassel@kernel.org> <7a243a1e-6b47-bc2f-c538-b57db1c9c580@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7a243a1e-6b47-bc2f-c538-b57db1c9c580@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_023900_828055_153F055D X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 14, 2024 at 09:47:54AM +0530, Kishon Vijay Abraham I wrote: > Hi Niklas, > > On 2/10/2024 6:56 AM, Niklas Cassel wrote: > > The series is based on top of: > > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=endpoint > > > > > > Hello all, > > > > This series cleans up the hardware description for PCI endpoint BARs. > > > > The problems with the existing hardware description: > > -The documentation is lackluster. > > -Some of the names are confusingly similar, e.g. fixed_64bit and > > fixed_size, even though these are for completely unrelated things. > > -The way that the BARs are defined in the endpoint controller drivers > > is messy, because the left hand side is not a BAR, so you can mark a > > BAR as e.g. both fixed size and reserved. > > > > This series tries to address all the problems above. > > > > Personally, I think that the code is more readable, both the endpoint > > controller drivers, but also pci-epc-core.c. > > Thank you for cleaning this up! > > FWIW: > Reviewed-by: Kishon Vijay Abraham I IMHO, a FWIW is quite the undersell here, as there is no R-b I would value higher than the R-b from the original author or the pci endpoint subsystem :) Kind regards, Niklas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel