From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFD1DC48BC4 for ; Wed, 14 Feb 2024 11:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fvgN7f4BoGxd+7h3S5gV3zM2i4P6fyKSPCO7+Gm2kbI=; b=wRZCbm5mC8TK22 TtRc+4nUH2pYVo11MPewfhTmeFZxp/wLhYbcGJsUo74cfTAZoyq3iMwmwcyIFwR6Eo5DPHSKtDNui WLIwjaRDAanVsJ9BFEqMJSX/F8ly/fvnbjAHmEylRDEaPSKJGVwnYQoq1h1DdY87nlkR6RkuJxTUo RgdLpEmu3rnBxVyW/PxMZU0GQtvgVH9yW6/Vc8qzSJL66+2udZxXFKc2NjIN1t/WdHT76PwNd0UO6 ACBugiQxTfVMRQc2bWkZAhEcHLrjYc2gfdYZsmDthE89J55Ku3wh91MI1BWQ+qGPL0davDTohkxa0 hlklPrgoR7AR2fdNv8Bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raDAo-0000000CcNy-0iHv; Wed, 14 Feb 2024 11:11:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raDAk-0000000CcNa-363Y for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2024 11:11:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC7D61FB; Wed, 14 Feb 2024 03:12:03 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.64.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 957893F766; Wed, 14 Feb 2024 03:11:20 -0800 (PST) Date: Wed, 14 Feb 2024 11:11:14 +0000 From: Mark Rutland To: Easwar Hariharan Cc: Oliver Upton , Catalin Marinas , Will Deacon , Jonathan Corbet , Marc Zyngier , Andre Przywara , Rob Herring , Zenghui Yu , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , "open list:DOCUMENTATION" , open list , Anshuman Khandual , stable@vger.kernel.org Subject: Re: [PATCH] arm64: Subscribe Microsoft Azure Cobalt 100 to ARM Neoverse N2 errata Message-ID: References: <20240212232909.2276378-1-eahariha@linux.microsoft.com> <18b3ac3e-2bfc-4fce-9be4-3e75e487f9fc@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <18b3ac3e-2bfc-4fce-9be4-3e75e487f9fc@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240214_031126_852770_09A8C6BB X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 13, 2024 at 04:19:08PM -0800, Easwar Hariharan wrote: > >> diff --git a/arch/arm64/include/asm/cputype.h b/arch/arm64/include/asm/cputype.h > >> index 7c7493cb571f..a632a7514e55 100644 > >> --- a/arch/arm64/include/asm/cputype.h > >> +++ b/arch/arm64/include/asm/cputype.h > >> @@ -61,6 +61,7 @@ > >> #define ARM_CPU_IMP_HISI 0x48 > >> #define ARM_CPU_IMP_APPLE 0x61 > >> #define ARM_CPU_IMP_AMPERE 0xC0 > >> +#define ARM_CPU_IMP_MICROSOFT 0x6D > >> > >> #define ARM_CPU_PART_AEM_V8 0xD0F > >> #define ARM_CPU_PART_FOUNDATION 0xD00 > >> @@ -135,6 +136,8 @@ > >> > >> #define AMPERE_CPU_PART_AMPERE1 0xAC3 > >> > >> +#define MSFT_CPU_PART_AZURE_COBALT_100 0xD49 /* Based on r0p0 of ARM Neoverse N2 */ > >> + > >> #define MIDR_CORTEX_A53 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A53) > >> #define MIDR_CORTEX_A57 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A57) > >> #define MIDR_CORTEX_A72 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A72) > >> @@ -193,6 +196,7 @@ > >> #define MIDR_APPLE_M2_BLIZZARD_MAX MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M2_BLIZZARD_MAX) > >> #define MIDR_APPLE_M2_AVALANCHE_MAX MIDR_CPU_MODEL(ARM_CPU_IMP_APPLE, APPLE_CPU_PART_M2_AVALANCHE_MAX) > >> #define MIDR_AMPERE1 MIDR_CPU_MODEL(ARM_CPU_IMP_AMPERE, AMPERE_CPU_PART_AMPERE1) > >> +#define MIDR_MICROSOFT_AZURE_COBALT_100 MIDR_CPU_MODEL(ARM_CPU_IMP_MICROSOFT, MSFT_CPU_PART_AZURE_COBALT_100) > > > > nitpick: consistently use the abbreviated 'MSFT' for all the definitions > > you're adding. > > I was rather hoping to use Microsoft throughout, but I chose MSFT for the CPU_PART* to align columns > with the other defines. :) If consistency is of a higher priority than column alignment, I can change it > to MICROSOFT rather than MSFT throughout. Consistency across the definitions is more important than alignmen; please choose either "MSFT" or "MICROSOFT" and use that consistently. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel