From: Mark Rutland <mark.rutland@arm.com>
To: takakura@valinux.co.jp
Cc: catalin.marinas@arm.com, will@kernel.org, ardb@kernel.org,
rmk+kernel@armlinux.org.uk, Jonathan.Cameron@huawei.com,
gregkh@linuxfoundation.org, james.morse@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/kernel/setup: Update comment on interrupt masking
Date: Tue, 27 Feb 2024 10:10:09 +0000 [thread overview]
Message-ID: <Zd21AaRO_JGLFo78@FVFF77S0Q05N> (raw)
In-Reply-To: <20240225021812.4834-1-takakura@valinux.co.jp>
On Sun, Feb 25, 2024 at 11:18:12AM +0900, takakura@valinux.co.jp wrote:
> From: Ryo Takakura <takakura@valinux.co.jp>
>
> DAIF_PROCCTX_NOIRQ contains FIQ bit.
> Update the comment as only asynchronous aborts are unmasked
> and FIQ is still masked.
>
> Signed-off-by: Ryo Takakura <takakura@valinux.co.jp>
> ---
> arch/arm64/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 0ea45b6d0177..9b9fdb64c684 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -298,7 +298,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p)
> dynamic_scs_init();
>
> /*
> - * Unmask asynchronous aborts and fiq after bringing up possible
> + * Unmask asynchronous aborts after bringing up possible
> * earlycon. (Report possible System Errors once we can report this
> * occurred).
> */
I think we can further simplify/clarify that as:
/*
* Unmask SError as soon as possible after initializing earlycon so
* that we can report any SErrors immediately.
*/
With that wording:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-27 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 2:18 [PATCH] arm64/kernel/setup: Update comment on interrupt masking takakura
2024-02-27 10:10 ` Mark Rutland [this message]
2024-02-28 2:28 ` [PATCH v2] " takakura
2024-02-28 18:59 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zd21AaRO_JGLFo78@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=takakura@valinux.co.jp \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox