From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44B95C54798 for ; Tue, 27 Feb 2024 12:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UJV79aHyo+udzfNml/bnQAQ69vQsOesM/laCCvGXr+U=; b=wyQ0rMHb/3KWNy D3P2zHXFjIbSB8liERlvOrLOrxYw62wwkuojVUqFmmv1yOr0K6eD1eDnZbOFkwHRqAXuJLTIv0jZU xOStgBN0uzt3zRL7LMbp8smjoQeoycluy6n8zhGw8ge4Ep8MbKtW9jyR40xQKy9aSs9W6dtddItAf qAEkMR0gdkBWxtfLByHspYZBV2vI12Ed39/cXDsUx0iCmcdacl5a9ymGtHIOVFNatSBWNLkY4uzeM fRmX+Y1+fw7Sv4kJ5TmHJ8SM6X+yKhhjkN3o1ZOr9HxsxVm3he5VOn2wC+/UsgOYZrccdahpL6qRk +g9WqhiL4LO70rLqo4hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rewkh-00000005E7t-31OM; Tue, 27 Feb 2024 12:40:07 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rewke-00000005E5p-2pdP for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 12:40:06 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a3d484a58f6so596131466b.3 for ; Tue, 27 Feb 2024 04:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1709037601; x=1709642401; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3G5KA/KgvvnP+phbQfXRPEFm6i2mU+y0npJdWX/2CSw=; b=b+5bwf4NRKjAt+IF5/xFpfVZ7WVEX7bLf43lStp+AeT8vyf1oFFj90kUEulHwqLItT NRVPtFovo/7jG/z/stpgq2xAdQ6oMAQsY+7FR1VQ7Nr6bdrDN/2yPYU1ylMcppYN5Yax ToCv/zASUbwJim5mGEr9n7I1CWPqWHAnKW3lAbVOBsxmu1VeRSFzg9Xr3ysXflRpCjld UcdAzwWz/xkdDB7P+xRz4ygtup/7NTKXl8CAtd+vg7EvsDNgGG7PqWvlWUQZJfC3oqFC 08frC5YaNjE0liI4k9bxVtMMbsS/8S3PnAVVCaz/72Km/5KTzH9Ybqvt1RfO+ZNxVXlx WOhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709037601; x=1709642401; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3G5KA/KgvvnP+phbQfXRPEFm6i2mU+y0npJdWX/2CSw=; b=Qbszu8s3P8XinWUhlwJ2tJUWshkhYgpyro1vWRt8/30jurilbZAH3DUBogvFro8Qgc e807aVIRoe1IG5EnFkE6vWSi5b0fH16dNjd29t36RV3y3u+OlPfDRNPpEpBqCSfx1l2u a+Rbfr/4BMkWcZMdmy2/sGFTHa0+pjJcdSBILb1mNWxd5XRTTtxK42PqAJo4kPYkJegi aDtCh+BAJNLo07GoqQXAFFOwR6T3Onb8G2+jyQVHbOBEV2jvfJezxzqmh/dwl/2apukH mFCD45Gb5x+//8yTJvfV1RpdrmnNosHEsFvzp3lwXpBu67h0bmcTv9/QgW3/g2YCORq0 Rexw== X-Forwarded-Encrypted: i=1; AJvYcCWi81ksQMf9Jip4Mau+wzISMqa6Om2A7F8UpT/7G8kKwIAY2I6pM1sjze3BBTCSzwqUj8rWKfMFuRdn3yCL8J8lLvjShgcV5FLbMMtWxNfFQLPFP2s= X-Gm-Message-State: AOJu0Yw+vInLsArJ7/oZupAXR2PB1MyG1yWkVYjT7W9IqnIMeOgeRbfn o2fGejz6J7/91wQhiPl+5w1rr4/E9vax6UuL0T+Sho0p8Xq2BfLeyjl3cJQIs/g= X-Google-Smtp-Source: AGHT+IFf+1UxKm68Ufr79btEFTW+YSygrKjHq5rNe4O6m6Bv9IEEvxhrtwQV1oX0yXq9DLLJhL5gyQ== X-Received: by 2002:a17:906:e0d6:b0:a43:8468:ac0b with SMTP id gl22-20020a170906e0d600b00a438468ac0bmr2629106ejb.7.1709037600854; Tue, 27 Feb 2024 04:40:00 -0800 (PST) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id wr2-20020a170907700200b00a3e881b4b25sm714035ejb.164.2024.02.27.04.39.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 04:40:00 -0800 (PST) Date: Tue, 27 Feb 2024 13:39:57 +0100 From: Jiri Pirko To: Siddharth Vadapalli Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rogerq@kernel.org, andrew@lunn.ch, vladimir.oltean@nxp.com, hkallweit1@gmail.com, dan.carpenter@linaro.org, horms@kernel.org, yuehaibing@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpsw: Add priv-flag for Switch VLAN Aware mode Message-ID: References: <20240227082815.2073826-1-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240227082815.2073826-1-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_044004_745928_436323E3 X-CRM114-Status: GOOD ( 10.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tue, Feb 27, 2024 at 09:28:15AM CET, s-vadapalli@ti.com wrote: >The CPSW Ethernet Switch on TI's K3 SoCs can be configured to operate in >VLAN Aware or VLAN Unaware modes of operation. This is different from >the ALE being VLAN Aware and Unaware. The Ethernet Switch being VLAN Aware >results in the addition/removal/replacement of VLAN tag of packets during >egress as described in section "12.2.1.4.6.4.1 Transmit VLAN Processing" of >the AM65x Technical Reference Manual available at: >https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf >In VLAN Unaware mode, packets remain unmodified on egress. > >The driver currently configures the Ethernet Switch in VLAN Aware mode by >default and there is no support to toggle this capability of the Ethernet >Switch at runtime. Thus, add support to toggle the capability by exporting >it via the ethtool "priv-flags" interface. I don't follow. You have all the means to offload all bridge/vlan configurations properly and setup your hw according to that. See mlxsw for a reference. I don't see the need for any custom driver knobs. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel