From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F36DBC5478C for ; Tue, 27 Feb 2024 17:55:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YDyeHFeY4RY1hi5vEtMRoy5NDJ4MeeiCsnKAHGpqez0=; b=DLj+yxhrZPPMeB 4nu/dJCQ/aig7I4sm0X2dF9ahVy+vaikT82Pl3kt2gk2PvUhMbYQFBSqlcgFoUZzh7rQoDGcE5r+c 0Rl50BQtyUezdx4qnfdDZvTCgQUQOyt/iX/ASoFKX/ELGFmkvUmpogYDk8VFnT7Ni4qRreS3mBxQr /gjtmP5eNpcgkCFGNsORa4gViHLRbdIBzTcKupwm9IU2q6QSeKPTjpi4cZRSuwfs5R3Y5vGzaZAo1 YhL7dCmpm6JWXDHqraZv+cJlXtYAlSG7vLgYMJzhXjujOiLA8zj7CAKSB/WCtTbfTdZV3E0/cOEts iOryFtk9+ml+wkNOeIzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf1fg-00000006K5g-3Tr8; Tue, 27 Feb 2024 17:55:16 +0000 Received: from mail-io1-xd29.google.com ([2607:f8b0:4864:20::d29]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf1fe-00000006K2l-0AJQ for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 17:55:15 +0000 Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7bc332d3a8cso309792939f.2 for ; Tue, 27 Feb 2024 09:55:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709056509; x=1709661309; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0z6oy3tLEwRGgu8/omrsseYREQZqlDjlucfwbridRR4=; b=KOblvAI6VTkr/+sEV3V62jI2q9ARtqokqgywoqmHbUoIQ8Phtk21JM+7O8onOeBwB/ 5bCBqzshbinyZQf+Z2TDk2LpalFxgpU0rmMQtb7Q1FQzKcPU//6/dyuCFrgZ0WNZurC8 mYGP9yHXpOzJT5ivkQoI1XifygmDLk9CrTPgE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709056509; x=1709661309; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0z6oy3tLEwRGgu8/omrsseYREQZqlDjlucfwbridRR4=; b=aAH8AI31fpzSusF6TCR5Sf0cuXllKyjzWfLxRPauWkU3x9S4qycsvxjEX4DH2iVIic SE5SeTrIusMRokNb+vML3OXcA15K4YQkrTS4HHE9VzmkQi2NWHSJV1ehEzFJU9KtADEe OXGbGWnRwJ7N0y8ilDmYanDWwN5HRnkGqVc82PZtiMn3HaCJvTxBXH939eU/SSEqZU37 zXyus/osAF8sPfauCoaldl+ZPaC5ti1WX+kXg+5eHhu5uOAJxE7r1JliLMEK/dM/UIkN uhCy93h+LVfXqU9PzWwtrswutCbA3+rX30g5PxNQkKKmMssdZgAjVj2WB9H7S/oKhzUj /fhQ== X-Forwarded-Encrypted: i=1; AJvYcCVoTHlbHZY7TsY/axAxajjqTX1yA09V24x32x5K24Nb6X5L/f2wHLIN40m6m7JhZeI1DOkUJU+G3LtcH6sg1Koum1xZtdY1w6iI1EvQVUUNur1uoB4= X-Gm-Message-State: AOJu0YxKxMjoe4e5/Uc99n7hw8vjdtRqMFB7DLDr3uM7BWhoScYX1VFM zA0SBikXkhUe3hbN6gzEPZu7PiCKEv3D3bcUxiMdx8yCdNd28WlHqb/+Phc1TQ== X-Google-Smtp-Source: AGHT+IE99IEm1bwDJq2IEwn8DzuSvhEObNZduooC8XEtgQeAr6li7TB9E5Onf6yMe4pPR4UCVj/fTw== X-Received: by 2002:a5e:c007:0:b0:7c7:9184:df98 with SMTP id u7-20020a5ec007000000b007c79184df98mr13293582iol.12.1709056509170; Tue, 27 Feb 2024 09:55:09 -0800 (PST) Received: from localhost (147.220.222.35.bc.googleusercontent.com. [35.222.220.147]) by smtp.gmail.com with UTF8SMTPSA id u14-20020a02b1ce000000b0047464deaba5sm1816183jah.114.2024.02.27.09.55.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 09:55:08 -0800 (PST) Date: Tue, 27 Feb 2024 17:55:07 +0000 From: Matthias Kaehlcke To: Javier Carrasco Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Helen Koike , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Catalin Marinas , Will Deacon , Russell King , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/8] usb: misc: onboard_dev: add support for non-hub devices Message-ID: References: <20240220-onboard_xvf3500-v4-0-dc1617cc5dd4@wolfvision.net> <20240220-onboard_xvf3500-v4-2-dc1617cc5dd4@wolfvision.net> <174ce57a-3197-4251-831f-205ec5cfeae9@wolfvision.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <174ce57a-3197-4251-831f-205ec5cfeae9@wolfvision.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_095514_105643_36DBC9BE X-CRM114-Status: GOOD ( 30.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 22, 2024 at 03:42:26PM +0100, Javier Carrasco wrote: > On 21.02.24 20:24, Matthias Kaehlcke wrote: > > On Tue, Feb 20, 2024 at 03:05:46PM +0100, Javier Carrasco wrote: > >> Most of the functionality this driver provides can be used by non-hub > >> devices as well. > >> > >> To account for the hub-specific code, add a flag to the device data > >> structure and check its value for hub-specific code. > > > > Please mention that the driver doesn't power off non-hub devices > > during system suspend. > > > >> Signed-off-by: Javier Carrasco > >> --- > >> drivers/usb/misc/onboard_usb_dev.c | 3 ++- > >> drivers/usb/misc/onboard_usb_dev.h | 10 ++++++++++ > >> 2 files changed, 12 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c > >> index 2103af2cb2a6..f43130a6786f 100644 > >> --- a/drivers/usb/misc/onboard_usb_dev.c > >> +++ b/drivers/usb/misc/onboard_usb_dev.c > >> @@ -129,7 +129,8 @@ static int __maybe_unused onboard_dev_suspend(struct device *dev) > >> if (!device_may_wakeup(node->udev->bus->controller)) > >> continue; > >> > >> - if (usb_wakeup_enabled_descendants(node->udev)) { > >> + if (usb_wakeup_enabled_descendants(node->udev) || > >> + !onboard_dev->pdata->is_hub) { > > > > > > This check isn't dependent on characteristics of the USB devices processed > > in this loop, therefore it can be performed at function entry. Please combine > > it with the check of 'always_powered_in_suspend'. It's also an option to > > omit the check completely, 'always_powered_in_suspend' will never be set for > > non-hub devices (assuming the sysfs attribute isn't added). > > > > The attribute will not be available for non-hub devices in v5. However, > if the check is completely removed, will power_off not stay true at the > end of the function, always leading to a device power off? As you said, > 'always_powered_in_suspend' will not be set for non-hub devices. Even without the sysfs attribute the field 'always_powered_in_suspend' could be set to true by probe() for non-hub devices. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel