From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B079BC54798 for ; Tue, 27 Feb 2024 18:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0i5+KtdnjJq9GaadhnzP02v0jnXmRTIXoN/3KWLsmU0=; b=hN3if40SB5xx6s iTaG3bAi96hEJZ8CQslYFQmnT3NZeo9CdwchrSWg7vDO6DnwG8P+qZ78qr05j7jvMdzsUbt2gumUU jro1ly4xtSb0sevBI+rCRbMiHtyCnJasZWMZaWKqlruxlVdPqm7yxVTV0tUbMX5wQRWjfi8aa4MIw k18oRMObdlLXg1pnJeHXxZGY4dRz4jzj3gAyMLvoIEBaWR4ivAucQhEPqVpPgOLXV8UnzmhkYzlFC gv30mlH/+Y+BWOiyBhMiHnVzgF0hzRNCl505UwGugydlPxFPV5CTam5JeOxWdOA4HFYG0xsRWGD8i rVUzXCrwcw2JYRnw5RVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf2LA-00000006T4Q-2nCb; Tue, 27 Feb 2024 18:38:08 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rf2L7-00000006T3e-40M1 for linux-arm-kernel@lists.infradead.org; Tue, 27 Feb 2024 18:38:07 +0000 Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-365169e0938so213245ab.0 for ; Tue, 27 Feb 2024 10:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709059084; x=1709663884; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zaG4Gr4Kx+0i0zsq6oXYlyOK6u158LHOb5Hpg9y9dtA=; b=ENGeCk1gl9woh56KVEmoQclT3UGF9lwfzFr4nxdpEXxfTw7mckrNQpbD3t3Ry9pPPZ GH4u0AHMVuz6F8vL9c6JYAWYbnfh/iLjUpaxYIYVWBVYMe6Uo49uEVovRBD4XzEcXdpB 5QFuDIpx0mxecn22cznIQNTrpcEeHquwyarJk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709059084; x=1709663884; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zaG4Gr4Kx+0i0zsq6oXYlyOK6u158LHOb5Hpg9y9dtA=; b=KMP+mC80c60vyygR3+F61lT8uc7AybGahFI7hZddiBbXvDkZgi6LSQ+a/nOppeguCU Hpt0gxiMZSpqRTL5znSloUC+FvTlDuzTs5dfa2kUu9FAjhs+ELpzvt5U2MhudZK346yV 4hL6SNCV8UZE+q0nsfM7zi0NFALIGukMhlrDhx1Ua97+TLYTPfN3RxNDumn/UD4g84pB Y4u47+jb0xJf6JGCRiggrELReg3C3EPehF0QLDDattpThKjvGJvHqdMbLjiflHy7eCSq hdAMk/Ttt6ZvMwJoJkZyJtAQvSXd/wAastJgGc0ApdlDkauFLJde96V/OsNn1uNbs6c9 X9kA== X-Forwarded-Encrypted: i=1; AJvYcCUkAfUcjSSmDY3m5VC98nhfv/yT+xs8aepv/LtjOXIjyV/Dg3+VXPx0ju1HxRUYGHyen357UxYVpF8D0B8JrCUPVuCPKfP1y99IsWu9U78orrtyu6Q= X-Gm-Message-State: AOJu0YxPbOWuyaA1sUFJK6QYaRLTUoQ9pmYebMgEiFQDZju3d49pC0dg 6qZJqd9C234r7LajvLloHbS5k7kcpU0wxeANsu54iwa86AeuM6Xs3v1BehCg3g== X-Google-Smtp-Source: AGHT+IEeZR7+1yyy7wcg6Jz8cOZdq5xTguaXhSCIcOHuTDOZFBcHwqro5Caz+F2LmDujB9cHZH+DyQ== X-Received: by 2002:a92:cb0b:0:b0:365:616a:72da with SMTP id s11-20020a92cb0b000000b00365616a72damr143131ilo.7.1709059084386; Tue, 27 Feb 2024 10:38:04 -0800 (PST) Received: from localhost (147.220.222.35.bc.googleusercontent.com. [35.222.220.147]) by smtp.gmail.com with UTF8SMTPSA id f5-20020a056e0212a500b00363ea1209basm2294457ilr.11.2024.02.27.10.38.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 10:38:03 -0800 (PST) Date: Tue, 27 Feb 2024 18:38:03 +0000 From: Matthias Kaehlcke To: Macpaul Lin Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Bear Wang , Pablo Sun , Macpaul Lin , Chunfeng Yun , Yow-shin Liou , MediaTek Chromebook Upstream , Chen-Yu Tsai Subject: Re: [PATCH 2/2] usb: misc: onboard_usb_hub: Add support for TI TUSB8020B Message-ID: References: <20240227090228.22156-1-macpaul.lin@mediatek.com> <20240227090228.22156-2-macpaul.lin@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240227090228.22156-2-macpaul.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240227_103806_028823_95735D23 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 27, 2024 at 05:02:28PM +0800, Macpaul Lin wrote: > The TI TUSB8020B is a 2-port USB 3.0 hub. Add support for > this hub in the driver in order to bring up reset, and supply > dependencies. > > Power-up: Issue a GPIO reset (GRSTz) 3ms after VDD and VDD33 stabilize. > > Signed-off-by: Macpaul Lin Generally this looks good to me, but it should probably wait for "usb: misc: onboard_dev: use device supply names" [1] to land and use a device specific supply name instead of 'vdd'. [1] https://lore.kernel.org/linux-usb/20240220-onboard_xvf3500-v4-6-dc1617cc5dd4@wolfvision.net/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel