From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFEA8C47DD9 for ; Wed, 28 Feb 2024 13:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0umi3xzWf6KYgGIkQqujDxUqcsavSWnvOfyLYuxbi1s=; b=3JmsHMTvEPUSCA GXczaCTyC/eNrIKZsKsKJd6itazbkkNPyrnSP+52ZOazV2UPdNYy3oZa5dkEUH1tY9dDETKdwlw+m 0u+C7fXobuRDHghvvmxZg1d/hPrj/MULgcoATyPtKw6O4/RmBJimW8+fQXynoqiBV66EWhVvobSy6 6x6IKIbmUXCvRqiweY8DfElrPcwW5TUqMj46Iplh5zncOxpR1h6PtQIXIha0SZshyXWrWsOO/M5Xs SPkhCpn5MV1jijRh9/Jk/7p+WsBBv41NqGlHxqskma68swgRPYahbmt7jre5qGgF+YnPM8tVC53c2 euS191pQo6+u37atewbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfK8K-00000009VDn-26fT; Wed, 28 Feb 2024 13:38:04 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfK8G-00000009VA2-2rEH for linux-arm-kernel@lists.infradead.org; Wed, 28 Feb 2024 13:38:02 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-512bd533be0so6609156e87.0 for ; Wed, 28 Feb 2024 05:37:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709127474; x=1709732274; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=SxWgL4sElI1B0/tx2GgHOxLa5Q0889pBGSF5c/6AjSo=; b=O91WEhRKt+doMG86BxdG5uq7EEu9+sfoQmyvc0JZL1X4qdPBbrRke9knUJ15yqMfxg 2XCJEyvBV1zJVRM1Kz8Z9TiYEvQMKRbYSKo7qWMkbS32Bpez9GTMYE64k5blEoErc341 dM6/hKd6pCcaplRvtJv27cr7qyMLt7bsesx3FK1tDKj3cL42ApEhv8xa0UxgPttj39/6 IDtB1ykr4MGj/DraKuKUsxZgZQKrWMxe2AFOl2KmSLx9WWI3iG3no/kXxjm622xKW9f4 z3HYFDIqXtUO1J3gszBiCl6kvWuKfnwGgcsi4bAZgFmW/6DX//4bvRo9iPVUWJqDc1To M1fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709127474; x=1709732274; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SxWgL4sElI1B0/tx2GgHOxLa5Q0889pBGSF5c/6AjSo=; b=ikrkvBTIaEoVLz/QvLHrwCRp5bKdxCJhxbcdmFHHqomtuoWGvjxiX8rtnINgAQECY9 YmWaPZetRE9b2JsF/7QBvs0qOZonzYIWJEBX8Jwg7pgOp+3eQhKk/f/f9IJO+mGY2RAY ftq5r9cjsQBS3cHgluMndpjEVKE2YCaRljA+kvz4uTJifPbz0913ki2eVqEgmUr+RFOg nJ9Rbz9ZIf1lmZzITh3AYBRIO0dwFIab31MwS7bTYi7abq0F7bKZ+MKsBppamPg3aM7G c8QjfNFuosDDGwS3KdWd9O4v6rZSWjNjHml1jkg6w083IZQFPtN5/Nnoc5f2ggFD4SSR szhA== X-Forwarded-Encrypted: i=1; AJvYcCWYRwzg/ezfC2AWSZnpruoT3fj6sVugPtOHTaOI8nZfvRW6PvxTqNpoD3YH/Zsu4e4Q1ATMJlPf1dyc9m+7uCHavVsG6GGNFo72hANxegtw6sAkhaU= X-Gm-Message-State: AOJu0YzE0bfJM2wvUZvkwBaF+SvSuaRibMG9M0+Ys85sQ41cLBpbYIaa H+KNmu12umTZoq49jDcbQCzhw8BMiWdN3ZIdmPHbNnQPq2vmC5hB X-Google-Smtp-Source: AGHT+IEGAbjhr46EhXX778kptGTzCsJXZVuCDdfQgon6/ZXpJpBpqXYL2Ir2C0Xs3h1Pus1GVC1Ojw== X-Received: by 2002:a05:6512:21b1:b0:512:f733:9eb with SMTP id c17-20020a05651221b100b00512f73309ebmr5671413lft.11.1709127473910; Wed, 28 Feb 2024 05:37:53 -0800 (PST) Received: from localhost ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id o11-20020ac2494b000000b005131434454bsm433619lfi.228.2024.02.28.05.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 05:37:53 -0800 (PST) Date: Wed, 28 Feb 2024 16:35:39 +0300 From: Andrey Skvortsov To: Herbert Xu Cc: Corentin Labbe , "David S. Miller" , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Corbet , Ovidiu Panait , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris Subject: Re: [PATCH] crypto: rk3288 - Fix use after free in unprepare Message-ID: Mail-Followup-To: Andrey Skvortsov , Herbert Xu , Corentin Labbe , "David S. Miller" , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jonathan Corbet , Ovidiu Panait , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris References: <20240226215358.555234-1-andrej.skvortzov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_053800_748901_CF2164E5 X-CRM114-Status: GOOD ( 14.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-02-28 17:13, Herbert Xu wrote: > The unprepare call must be carried out before the finalize call > as the latter can free the request. > > Fixes: c66c17a0f69b ("crypto: rk3288 - Remove prepare/unprepare request") > Reported-by: Andrey Skvortsov > Cc: > Signed-off-by: Herbert Xu > > diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto/rockchip/rk3288_crypto_ahash.c > index 1b13b4aa16ec..a235e6c300f1 100644 > --- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c > +++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c > @@ -332,12 +332,12 @@ static int rk_hash_run(struct crypto_engine *engine, void *breq) > theend: > pm_runtime_put_autosuspend(rkc->dev); > > + rk_hash_unprepare(engine, breq); > + > local_bh_disable(); > crypto_finalize_hash_request(engine, breq, err); > local_bh_enable(); > > - rk_hash_unprepare(engine, breq); > - > return 0; > } > Thanks, that was quick. I had locally the same change. Reviewed-by: Andrey Skvortsov -- Best regards, Andrey Skvortsov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel