From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 255DFC5478C for ; Wed, 28 Feb 2024 15:30:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nSiadAbmVvZ/M8MiuwPcTAlbb7YIv7b/qQHiVmGy4TE=; b=t2pMCaYP2Lnz7e d3v0IwSiH9cf+yC7Ss1+QVHTM0QQDt+4D8fUjh57U0DBKk63NVg/U69oHmKv/ausBswvrV8nVaV8Z oPO8PhUcPTcuQ27JjGoOAZgJS68eqr9scj/hkVMgqMeAZB3OlYqyfOzjp5H27yTkm2Z+dsRe4eTys oGGLYIaT9n+NVXq+xPi81jfoUQMVlDkX4M1HDG33PlYpekoo2r1uZXioTTnpATHvgndd1eh4J+lUZ KFDKHYPl+nh9ogu/6W+j48M+bFxFQK6Wzjmmt6TdK14RMPbyEp2JFXubdoY8gM7fwnuL63RHQQf47 BFFzKPwdWJrlxGVRd6ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfLse-00000009to5-2Jdn; Wed, 28 Feb 2024 15:30:00 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfLsQ-00000009ti6-1C6v for linux-arm-kernel@lists.infradead.org; Wed, 28 Feb 2024 15:29:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 027C5CE1C79; Wed, 28 Feb 2024 15:29:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 064EEC433C7; Wed, 28 Feb 2024 15:29:41 +0000 (UTC) Date: Wed, 28 Feb 2024 15:29:39 +0000 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, broonie@kernel.org, Will Deacon , Mark Rutland , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/hw_breakpoint: Define an ISS code for watchpoint exception Message-ID: References: <20240223094615.3977323-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240223094615.3977323-1-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_072946_583709_0F468DDD X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 23, 2024 at 03:16:15PM +0530, Anshuman Khandual wrote: > diff --git a/arch/arm64/include/asm/esr.h b/arch/arm64/include/asm/esr.h > index 353fe08546cf..6c0a0b77fd2c 100644 > --- a/arch/arm64/include/asm/esr.h > +++ b/arch/arm64/include/asm/esr.h > @@ -143,6 +143,10 @@ > #define ESR_ELx_CM_SHIFT (8) > #define ESR_ELx_CM (UL(1) << ESR_ELx_CM_SHIFT) > > +/* ISS field definitions for Watchpoint exception */ > +#define ESR_ELx_WnR_SHIFT (6) > +#define ESR_ELx_WnR (UL(1) << ESR_ELx_WnR_SHIFT) We had ESR_ELx_WNR since about 2015, maybe even earlier in the form of EL1 or EL2. Only that the 'n' is uppercase. So please use that, don't add a new definition. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel