From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F422C48BF8 for ; Mon, 19 Feb 2024 15:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H7PJjs15QwJa1MTzHmuFvlaxUBWPxLGo5WXzlWVmHHo=; b=afhqcqJQ4YFA9j HH+TO0LzIIEXhlhRkiUWy2Wq+Cx4VOeUINw6mKO1WcIJcmfF4HnhSnGYw+uiIlU0SCZvdrQIAOp5H iLhXeG2ZmIiWcqHGbgkPSdAFhC7YU1ahV+/I8/BQTzUfAzUg2VY9Beb2zrUixLxrubhhvhhxotUAD pGiUseUkP7V1dTbZNJVGeQintshywzadKiEWiTg6cz/0cj3xXz66UD8a40h9z2vD6qp8ZlvOsAUDL PD2K8H5VjrHsTabc9EKabLuvHvVd9W2YinJ9f82pHTZulcdL+7hX8ohiWU9P85e9dQuxbOmJHnjGu am5z7lqkWryu73dlKGxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc5Is-0000000B2F9-3FMs; Mon, 19 Feb 2024 15:11:34 +0000 Received: from mgamail.intel.com ([198.175.65.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc5Ip-0000000B2Dj-1EaH for linux-arm-kernel@lists.infradead.org; Mon, 19 Feb 2024 15:11:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355491; x=1739891491; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ayLLTpEgKqvBUDQj5moMFIOBncxte1r8rIs7zb2L0nI=; b=HPfFZ1UdiWtY42VUAxrfDbui7UUxvk+OmInZZYgdBLTG6qHJIJ2ye1kP 8aTk5DWOD/74Wx4w/4TCYEMdU4kUPctDRc2a2jViRGwG26K4dvpIsyLQ/ lGfWVaI9fG+TqumvArQN4qI/aFnPmK2YJSDkYd0Dk56uUhTT66LDoUNIN E1+MvUDwMNWBofXCZgh/J/jzmHTf7vjf81sAKu9rOMAME6YlhbNmWHFF6 bXkw//N5/ZDnUFfhz/ZTnvwTdJ2cCsSnY9PJ7fcislJeX4GiWW4UHjS/g VhYjosavmP+r94Lf4NP/TMjp/SjYbGksOs56toXHJcBQDWARGhn+coGTr g==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2545647" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2545647" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:09:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="912890661" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="912890661" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:08:57 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rc5GI-00000005qqV-1fic; Mon, 19 Feb 2024 17:08:54 +0200 Date: Mon, 19 Feb 2024 17:08:54 +0200 From: Andy Shevchenko To: Serge Semin Cc: Andy Shevchenko , Serge Semin , Greg Kroah-Hartman , Jiri Slaby , Alexey Malahov , Pavel Parkhomenko , Maxime Ripard , Will Deacon , Russell King , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 1/4] serial: 8250: Add 8250 port clock update method Message-ID: References: <20200723003357.26897-1-Sergey.Semin@baikalelectronics.ru> <20200723003357.26897-2-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_071131_415028_7E473018 X-CRM114-Status: GOOD ( 21.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 16, 2024 at 08:19:37PM +0300, Serge Semin wrote: > On Thu, Feb 15, 2024 at 09:39:12PM +0200, Andy Shevchenko wrote: ... (thanks for the detailed explanation why you have done it that way) > If what you suggest is to replace the serial8250_update_uartclk() body > with a direct uart_port::set_termios() invocation then I don't find it > being much clearer really. The serial8250_update_uartclk() is > currently specialized on doing one thing: adjusting the divider in > case of the UART-clock change. If instead the entire > serial8250_set_termios() method is called then for a reader it won't > be easy to understand what is really required for a 8250 serial port > to perceive the ref-clock change. But from the maintainability point > of view I guess that it might be safer to just call > serial8250_set_termios() indeed, since among the other things the > later method implies the divider update too. Thus the maintainer won't > need to support the two clock divider update implementations. > From that perspective I agree, directly calling serial8250_set_termios() > might be more suitable despite of it' doing more than required. Would it be possible for you to cook the patch (and test on your HW, since it seems the only user of that)? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel