From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6B36C48BC4 for ; Tue, 20 Feb 2024 09:51:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tFBQC8Vfw9l7CV/mzGI46bQ131/fJHm2tHFy0S3MX7U=; b=gK5rPzQQgT9pTR eNMMl8L8p/1ycKByKdieUmKsoOZW++M5+7T/M265jODOQ1ppk8S5znKp3lKPoancx2JjQp4j40KoQ PgdHSYhFFZMYzqjf6Siv+TOiyc5IBNFSV6j1wLulZEzQYtruUH+uzxtQEAQ15Yr8oIkjQCbty+o9U 0VGdaR8NIik2Df/uezOFq7rNrCCdBFebk3YTm994XuU4enCkz6sklcefVcFU2PhmIt2ThY+ZaVDp/ DF/N4Umv2CjvygRq3OmdhH0VJjPmhd49dFcsjdY/w151M7iFCeI8HUIE143nc+/kkwy3GY11roFxv nduEaM9RMQd0B6ePSW+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcMmh-0000000E6IL-2pe6; Tue, 20 Feb 2024 09:51:31 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcMme-0000000E6Gf-2ECl for linux-arm-kernel@lists.infradead.org; Tue, 20 Feb 2024 09:51:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 79AA66115B; Tue, 20 Feb 2024 09:51:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AED6EC433F1; Tue, 20 Feb 2024 09:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708422687; bh=yDxhCM2YS8Q8iXNgzOUk2+9cgtV+kXn+jRue04kUuVo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i3/G5uUE84InpD/s92gGB4Qn1ZV+5peqepCh2De85eeXtuV1SSKSxkZDt4ySVLHfv VbfEaQGDWsz/uW5vZG7unMcBDyUlIM6EJDhUxA67I9e64733WUq+eheBr+lbcyjnyS DSv82w8W5ek+QhHwE8vlYXHJCPR7jpOTUpjDU7gi5cwQ1R01UPtyDb1y2GJvhi0Is5 fHBt+pbfofEdKhvyzo3ym3M5jlDfBP5xXyMO75tDQ7mvS/19JaVIUQ4rndppsSDQ7V sCf8a00JrgfXo+6cWth/VPSn/kiEbUd3sqSmZjBNecviq4+dip7G2AmYhxSfLVGJgn XBsekjWjyndpg== Date: Tue, 20 Feb 2024 10:51:17 +0100 From: Niklas Cassel To: Frank Li Cc: Manivannan Sadhasivam , lpieralisi@kernel.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v10 00/14] PCI: imx6: Clean up and add imx95 pci support Message-ID: References: <20240205173335.1120469-1-Frank.Li@nxp.com> <20240219161208.GE3281@thinkpad> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_015128_660539_9C4760E6 X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 19, 2024 at 11:18:03AM -0500, Frank Li wrote: > On Mon, Feb 19, 2024 at 09:42:08PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Feb 19, 2024 at 10:11:45AM -0500, Frank Li wrote: > > > On Mon, Feb 05, 2024 at 12:33:21PM -0500, Frank Li wrote: > > > > first 6 patches use drvdata: flags to simplify some switch-case code. > > > > Improve maintaince and easy to read code. > > > > > > > > > > @Lorenzo Pieralisi: > > > > > > Do you have chance to look other patches? > > > Mani's apply EP side change. > > > > Even though the controller is for the endpoint, it is still a controller > > driver. So all the patches should go through Lorenzo. > > > > I only merge patches under drivers/pci/endpoint. Hope this clarifies. > > Sorry. It confused everyone. My means was that Mani applied Niklas Cassel's > patches, which cause my 14th patch build failure. Hello Frank, Patch 14, which adds this: +static const struct pci_epc_features imx95_pcie_epc_features = { + .msi_capable = true, + .bar_fixed_size[1] = SZ_64K, + .align = SZ_4K, +}; Should, after rebasing on Mani's pci/endpoint branch, instead look like this: +static const struct pci_epc_features imx95_pcie_epc_features = { + .msi_capable = true, + .bar[BAR_1] = { .type = BAR_FIXED, .fixed_size = SZ_64K, }, + .align = SZ_4K, +}; > > I asked if I need update my 14th patch or applied 1-13 only. I see, you want the maintainers to apply 1-13, and simply drop patch 14 instead of you sending out a rebased series. I assume that the maintainers will be fine with your suggested approach. Kind regards, Niklas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel