From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5D54C48BC3 for ; Wed, 21 Feb 2024 06:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EmH+RZbY05N7qp67T0opdXob487VV2WAuN56eVAcxX4=; b=EiUMQQMS0xQAdF lfR/ueFbo7zp7izkHTC+WQaFaW+urImklQHSLrQr4LRmQI4Xm/y0ATe1XZMsaeMG3Wv3DO8K+u3xW 8iId1vz2QRkHHjVpjaX1XpAlK9sgyimVaV26nFfiwYtYwZKPMnhLssPhfX0Nn5bKn14Yd1LpzMAgV zk3xwVuSC65tI5ozGNe6+GooU0UVCz0w7oLKP+SUdHwubqUAULM876+1xcoXOFzqBrpn7Kvv84Hjn ugmPnKKGHDca2q9S65UK/pHI1rNDld/m0fTq7lx37EAF6uKHZAz2d5UhbBiLPbJ7BHUxlZOxbQzJ1 AGY3KLqRs2j5SQPBpswA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcfqh-0000000HIYl-45rD; Wed, 21 Feb 2024 06:12:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcfqe-0000000HIXt-2rEV for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 06:12:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B53DE613C5; Wed, 21 Feb 2024 06:12:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 131CCC433C7; Wed, 21 Feb 2024 06:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708495970; bh=+a2TXUHgHx9ewr828yRhngPu0FUo2wmIaOoxSHyJyc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OKlplEh9sLMQmx9Hl2i/IucT2jZPkZkqUmKau+bypPFQXCBJkoU0q84nYqYGkAkne RM8+aCtQ4agCD/1XSIyO/NFouZXnFYphrGuBsB3Ft83cCfPWCGLvmMgaZO+bSzIS5R E8a6NWAxNuwFRgxZ0836adTGyJW5Vg2JsOxRNLdx5z5Q8RNnSmWtqnSCQdTWGwYG8T /tDxNQcgSfbneLqAQXjL9BlLJQAt/jZv97L3DsZPyGXGSwLoaHbEqkN1oX7oLItycf yHTwKYU84FMuamlGIj9BKTQj7icxsI85MGWE+idKBePbMRuii+DX4dpKes+uQn483V E+ybak4gkvBLw== Date: Wed, 21 Feb 2024 08:12:14 +0200 From: Mike Rapoport To: Rongwei Wang Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, rafael@kernel.org, pierre.gondois@arm.com, mingo@redhat.com, dave.hansen@linux.intel.com, luto@kernel.org, teng.ma@linux.alibaba.com Subject: Re: [PATCH v1 0/2] support NUMA emulation for genertic arch Message-ID: References: <20231012024842.99703-1-rongwei.wang@linux.alibaba.com> <20240220113602.6943-1-rongwei.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240220113602.6943-1-rongwei.wang@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_221252_790831_61871D6E X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 20, 2024 at 07:36:00PM +0800, Rongwei Wang wrote: > A brief introduction > ==================== > > The NUMA emulation can fake more node base on a single > node system, e.g. ... > Lastly, it seems not a good choice to realize x86 and other genertic > archs separately. But it can indeed avoid some architecture related > APIs adjustments and alleviate future maintenance. Why is it a good choice? Copying 1k lines from x86 to a new place and having to maintain two copies does not sound like a good choice to me. > The previous RFC link see [1]. > > Any advice are welcome, Thanks! > > Change log > ========== > > RFC v1 -> v1 > * add new CONFIG_NUMA_FAKE for genertic archs. > * keep x86 implementation, realize numa emulation in driver/base/ for > genertic arch, e.g, arm64. > > [1] RFC v1: https://patchwork.kernel.org/project/linux-arm-kernel/cover/20231012024842.99703-1-rongwei.wang@linux.alibaba.com/ > > Rongwei Wang (2): > arch_numa: remove __init for early_cpu_to_node > numa: introduce numa emulation for genertic arch > > drivers/base/Kconfig | 9 + > drivers/base/Makefile | 1 + > drivers/base/arch_numa.c | 32 +- > drivers/base/numa_emulation.c | 909 ++++++++++++++++++++++++++++++++++ > drivers/base/numa_emulation.h | 41 ++ > include/asm-generic/numa.h | 2 +- > 6 files changed, 992 insertions(+), 2 deletions(-) > create mode 100644 drivers/base/numa_emulation.c > create mode 100644 drivers/base/numa_emulation.h > > -- > 2.32.0.3.gf3a3e56d6 > > -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel