From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83457C48BC3 for ; Wed, 21 Feb 2024 10:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CgCE9S+z1k1GqKGMOfkIAcuF9EC/cedW7ztcw8sBZCE=; b=hLk9JT80ndeTy/ NloorjYMLZPMnS0C1DxUlTwlaDtYiEcPHHgc4vFI5M6u1+q89CrpW6RXA+sV/oaRNqXaEJnv56jH/ Z/avUFicvu8Bh8D9lvGBRQQmVBURNddkgP9JEbQ4bI4zyg0h8M3CCBXjtgFp+LHYcOvE/cVqoRBmw RvCABQhunndJcAozWf6nQvnY46dhYkh7/v6VFVjA2My83rgNSdWj2Hp9FFSx3irPSqqZhzKQiu+aN kfVEpmODbVaxGJ0GqzsS7ha6wsc2xuKmBQf9bYP9gP8t08FTnuDnhHSmE9BRTKVg8iZzXJkazm3T6 4MdK8GtNp6zpMBFHPGYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rckDS-00000000aWN-1c6q; Wed, 21 Feb 2024 10:52:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rckDP-00000000aVc-3gI5 for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 10:52:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7CD3FEC; Wed, 21 Feb 2024 02:53:14 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C68D3F73F; Wed, 21 Feb 2024 02:52:35 -0800 (PST) Date: Wed, 21 Feb 2024 10:52:33 +0000 From: Cristian Marussi To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Sudeep Holla , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: optee: fix struct kernel-doc warnings Message-ID: References: <20240221062157.8694-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240221062157.8694-1-rdunlap@infradead.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_025239_989742_5E5BD146 X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 20, 2024 at 10:21:57PM -0800, Randy Dunlap wrote: > Fix the kernel-doc notation for the nested union in struct > scmi_optee_channel to eliminate kerenl-doc warnings: > > optee.c:130: warning: Excess struct member 'shmem' description in 'scmi_optee_channel' > optee.c:131: warning: Function parameter or struct member 'req' not described in 'scmi_optee_channel' Thanks for this, I've spotted it recently and didn't get time to address it. Reviewed-by: Cristian Marussi Cristian > > Signed-off-by: Randy Dunlap > Cc: Sudeep Holla > Cc: Cristian Marussi > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/firmware/arm_scmi/optee.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff -- a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > --- a/drivers/firmware/arm_scmi/optee.c > +++ b/drivers/firmware/arm_scmi/optee.c > @@ -109,8 +109,10 @@ enum scmi_optee_pta_cmd { > * @rx_len: Response size > * @mu: Mutex protection on channel access > * @cinfo: SCMI channel information > - * @shmem: Virtual base address of the shared memory > - * @req: Shared memory protocol handle for SCMI request and synchronous response > + * @req: union for SCMI interface > + * @req.shmem: Virtual base address of the shared memory > + * @req.msg: Shared memory protocol handle for SCMI request and > + * synchronous response > * @tee_shm: TEE shared memory handle @req or NULL if using IOMEM shmem > * @link: Reference in agent's channel list > */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel