From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DB15C48BF6 for ; Wed, 21 Feb 2024 10:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MeZWrkcYZfdJewFc3u1Fpmz8cbio3tDMQrbCErPTPmw=; b=apMK/W0YaWyQEy 7PSgYSbNfaUka2LmCk3nAOnzL19iQf7DZBzhMVCfiIIm1zP0aYZ4b+oHHpof1EDArQ59Wc51GSJHl C1ZIZtDBjy7ngKdYCvMpO7cUCtOz5p1a3Se5ldkkW3/Q04zcVFBwPYDCm72qykhkrsl4H4z1LvOJR CvRzyoLNrrGMY3Bz+Y2bI1JUJj2+6b0QKII79AeEEo3QU0lH6vbE0/52hfM+mQgx8ptAJMpYUb1rv JpY+GDR/sfWBy/aVZVSIyvdXlbsLXV3a4m/5HqHo3Iw7sH4vesSPBDFAP89T/5+5mNmb1wsJK5epN +KAeZh8UMeu24fJl9NQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rckAV-00000000a6U-1cph; Wed, 21 Feb 2024 10:49:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rckAS-00000000a54-1lOH for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 10:49:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DD5AB6146C; Wed, 21 Feb 2024 10:49:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89CD3C43390; Wed, 21 Feb 2024 10:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708512575; bh=arxOax1Fal/10bdeaxUbFAhv0i0ETEjU7HQwbaIn75g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OYsFWyE/axhIQyem8BlEb5Ux6m0afNO6l13t/w6dbXBZgrmIJqP9sVdkEdmxr4B0U avzMjmA1I49P+Bpx3W+kUjbSUdRo5iZG79GKt9wN6PZ9D7g44BTG1tVu6lBMGqgP/g r/cup2peMrEjBECspg5qHvQNbViQ7EgesHMR39ONcLFExoMUsZ65ZeLAAnVpbcVUSh ZOysjfBS4YmYCkGJalQnzgDnxLlJ88OjTB4ub9w9NYCEBG45erbSvQJ/r7pvNj/s5+ qbYMLvcrR++Ytd5md6atdT0c903u1FXjCbl8tymwS1+dI3205R2la9I4XhlGFgBL7G M8abO1W7lgXsw== Date: Wed, 21 Feb 2024 11:49:27 +0100 From: Lorenzo Pieralisi To: Frank Li Cc: bhelgaas@google.com, cassel@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, krzysztof.kozlowski@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, manivannan.sadhasivam@linaro.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v11 07/14] dt-bindings: imx6q-pcie: Clean up irrationality clocks check Message-ID: References: <20240220161924.3871774-1-Frank.Li@nxp.com> <20240220161924.3871774-8-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240220161924.3871774-8-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_024936_530567_56A0AF92 X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Irrationality ? I think you mean "duplicate" or "redundant" ? Lorenzo On Tue, Feb 20, 2024 at 11:19:17AM -0500, Frank Li wrote: > The bindings referencing this file already define these constraints for > each of the variants, so the if not: then: is redundant. > > Acked-by: Rob Herring > Acked-by: Manivannan Sadhasivam > Signed-off-by: Frank Li > --- > > Notes: > Change from v7 to v8 > - add Manivannan Sadhasiva's Ack tag > Change from v6 to v7 > - rewrite git commit message by using simple words > Change from v5 to v6 > - rewrite git commit message and explain why remove it safely. > - Add Rob's Ack > Change from v1 to v4 > - new patch at v4 > > .../bindings/pci/fsl,imx6q-pcie-common.yaml | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > index d91b639ae7ae7..0c50487a3866d 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml > @@ -150,22 +150,6 @@ allOf: > - {} > - const: pcie_phy > - const: pcie_aux > - - if: > - properties: > - compatible: > - not: > - contains: > - enum: > - - fsl,imx6sx-pcie > - - fsl,imx8mq-pcie > - - fsl,imx6sx-pcie-ep > - - fsl,imx8mq-pcie-ep > - then: > - properties: > - clocks: > - maxItems: 3 > - clock-names: > - maxItems: 3 > > - if: > properties: > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel