From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BC7FC48BC3 for ; Wed, 21 Feb 2024 11:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AcJszMW5AGSNplR3iXLdk9Y1z7zpyuk4HF2MEYgqQmc=; b=0CIOoeoE4DaMil XIJAwEd0agGydUSp+yp4cQ38S52lPQ9fOsqyUgjvprS06NIst7CE/7W83gJaWHeve/z7Xrvc8Vgd1 JsNLhNXcB83vGQePL8aKlXmwQusqmesJ1zxbtBCszqMn9h8j4PfQeOHxdEc84E74UOB3lkUz6YMy7 5mowhNwGc7SNabqwg4wJfh2VrmnI+iwqRQm45j5HWKXF35KRA1K0Gu+e9+syyZA+nSND9FnQEre0u 0jZnRoF0a6BP7WQ5AlNunB4mZ5e8w+Pl3o5bmx/eIQmKBM7fe4OA6roCFcDD7piQxPF8F9gRTd9sN XYaYWosXBJ4oRshys3cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rclCL-00000000luf-2MWH; Wed, 21 Feb 2024 11:55:37 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rclCI-00000000ltE-0SZt for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 11:55:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708516533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=KHnlCIhA07Nq1bAmW6MedzwqBPuXkFYPzE2sPHYfGZfOA8sAXHRKv5RNAXl8MYZzXTYg09 /mMEwE05IPR8KFnGwk8+cFg4GfhxE3pyDH8PnU/L2scgOI9NecOL7FW7aBbElZiqyVp2h/ xiLcsIYfIFcyT/toEZa3EoR0DrEK1f8= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-330-XOWcPfZmN66tN6blfxfzsw-1; Wed, 21 Feb 2024 06:55:31 -0500 X-MC-Unique: XOWcPfZmN66tN6blfxfzsw-1 Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-5ce9b15f4ccso2844687a12.0 for ; Wed, 21 Feb 2024 03:55:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708516530; x=1709121330; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PLsLM/ECtgqgj6YScdKuDzdQeO2PVy2fvKFbE23nuA4=; b=hGU4qbK200sOqCPzWXznIRml0lYgo0b3AYxM1KlsVJZaSTu5ER2w/SBKiP3zuqGjWB XmUQvi5Qr1QPcmOpMKZM9zHxrGXl0yLpI57RPnO7djGA5sGvzoxEk/5qClxIGskwE7Rp dRn/IaNeIIeqvTXzjRvWCAwmokMIxGcl8QECLkiHcMLW1jdGgcFLhJ7G7o5kvJeqr8wn snkibqFQIAs4Amd/IHgvCquxRrlSUNycKXbfVofu5edbeo9dgnJ0ykauvLF2J9HuzOv7 DXXt30mqr89Zy5jWhRWHI6MPvMOVT81nKabHEPCoAmbSkz/cTWa43/AwRmtv6aLwDpSm GrVg== X-Forwarded-Encrypted: i=1; AJvYcCVNyCV6BLmVeHL26qTqwf8lnKrQTUCZDKF55p5PrLOslFFyJse+UPX3p+ZyQhekU9Uti76SDEL51BJthCGK7f4EP28FALK4N4lO9qc94p0dJTXd49E= X-Gm-Message-State: AOJu0Yy6VORWwbvrHJ9Fhxt1O9HblGxR2ACNn2APeHg4bftoc8WFvskL CDWadA1eXC62vxN/HKnReqaaSrcsopqcxOktnf79fMBfk8waouluuzo+Za9Us4yfoev2kAOZLc3 sF2IjHtfCrS5QsG+WNpqYjCXXjdlJZ8/3OszK1lwE9+bomPjeNzXzmAPGiYSyVUre9edPOhKt X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196501pzb.3.1708516530442; Wed, 21 Feb 2024 03:55:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRO+9lM9EY5N92dCc9bYoUlt/pUN8sgkXoKwNhU9AZ+BNLKu2lSvew+Aw+SPUl5ZIlIuODvw== X-Received: by 2002:a05:6a21:3397:b0:1a0:cd02:b2f1 with SMTP id yy23-20020a056a21339700b001a0cd02b2f1mr196492pzb.3.1708516530136; Wed, 21 Feb 2024 03:55:30 -0800 (PST) Received: from x1n ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id b3-20020a170902a9c300b001dc0955c635sm4149309plr.244.2024.02.21.03.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 03:55:29 -0800 (PST) Date: Wed, 21 Feb 2024 19:55:17 +0800 From: Peter Xu To: Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , linux-riscv@lists.infradead.org, Andrew Morton , "Aneesh Kumar K . V" , Rik van Riel , Andrea Arcangeli , Axel Rasmussen , Mike Rapoport , John Hubbard , Vlastimil Babka , Michael Ellerman , Christophe Leroy , Andrew Jones , linuxppc-dev@lists.ozlabs.org, Mike Kravetz , Muchun Song , linux-arm-kernel@lists.infradead.org, Christoph Hellwig , Lorenzo Stoakes , Matthew Wilcox Subject: Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Message-ID: References: <20240103091423.400294-1-peterx@redhat.com> <20240103091423.400294-7-peterx@redhat.com> <20240115183748.GR734935@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240115183748.GR734935@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_035535_078311_05E8667C X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 15, 2024 at 02:37:48PM -0400, Jason Gunthorpe wrote: > > Drop that check, not only because it'll never be true for hugepd per any > > known plan, but also it paves way for reusing the function outside > > fast-gup. > > I didn't see any other caller of this function in this series? When > does this re-use happen?? It's reused in patch 12 ("mm/gup: Handle hugepd for follow_page()"). Thanks, -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel