From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA508C48BC3 for ; Wed, 21 Feb 2024 14:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oMMrlxLkerJp/xl+yqqTRLEofhdyY1QW5WSq6h8F208=; b=Rjm6/+cG7PlR+V Z5Zml45kmS6NPG+ZCnMLtGQgCQd1si9rCmt2ZIBqao7OrrzH3XdCUaNUAVozUNNpeAz9VO+7h66Gs Z7lNOzA1LrBpOo7WNykDNXeXIN6zt1dBGV+r4FKaISMbTezBL9o/nAr1Ihub0qy0+GtijrOuaMex2 aofB0WELRTS2KgIgdiyFZvOLf3pyf8ARW2NLYcCzeVAnWb+l6G6tPnOTOYD8lJ5loqld49T4mHAxW PNVLke/TrUCy9ftRAPwM9RXtlPmET5cOgtJsIDCKhMsQKUjzorZcUmDZHYoUV3VpRMmYcerTQVYpJ 4dwYlFZ27Fxx4brQg9fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcnE6-00000001Btw-1i5Z; Wed, 21 Feb 2024 14:05:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcnE3-00000001BsR-1IuY for linux-arm-kernel@lists.infradead.org; Wed, 21 Feb 2024 14:05:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD55DFEC; Wed, 21 Feb 2024 06:06:08 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.65.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BE97C3F762; Wed, 21 Feb 2024 06:05:27 -0800 (PST) Date: Wed, 21 Feb 2024 14:05:24 +0000 From: Mark Rutland To: Mark Brown Cc: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, James Clark , Rob Herring , Marc Zyngier , Suzuki Poulose , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org Subject: Re: [PATCH V16 1/8] arm64/sysreg: Add BRBE registers and fields Message-ID: References: <20240125094119.2542332-1-anshuman.khandual@arm.com> <20240125094119.2542332-2-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240221_060531_429487_BD52A7F5 X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 21, 2024 at 01:59:03PM +0000, Mark Brown wrote: > On Wed, Feb 21, 2024 at 01:52:38PM +0000, Mark Rutland wrote: > > On Thu, Jan 25, 2024 at 03:11:12PM +0530, Anshuman Khandual wrote: > > > Minor nit, but could we please list thse in order: > > > BRBCR_EL1 > > BRBCR_EL12 > > BRBCR_EL2 > > > ... since that way the names are ordered alphnumerically, which is what we've > > done for other groups (e.g. PIR_EL{1,12,2}), and it's the way the ARM ARM > > happens to be ordered. > > It's a good point about the sorting, though the file is currently mostly > sorted by encoding rather than alphanumerically (similarly to how > sysreg.h was done). Sure, we're inconsistent. I'd just prefer that there's *some* local ordering here, as the patch is neither ordered as above nor by encoding: Sysreg BRBCR_EL2 2 4 9 0 0 ... Sysreg BRBCR_EL1 2 1 9 0 0 ... Sysreg BRBCR_EL12 2 5 9 0 0 Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel