From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-tegra@vger.kernel.org, "Jiri Slaby" <jirislaby@kernel.org>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Al Cooper" <alcooperx@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>
Subject: Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type
Date: Wed, 21 Feb 2024 20:53:08 +0200 [thread overview]
Message-ID: <ZdZGlLoUd_R6JQJc@smile.fi.intel.com> (raw)
In-Reply-To: <d18d4488-aa48-4156-8087-a117664cea7b@gmail.com>
On Wed, Feb 21, 2024 at 10:47:13AM -0800, Florian Fainelli wrote:
> On 2/21/24 10:31, Andy Shevchenko wrote:
...
> > unsigned char iotype; /* io access style */
> > +#define UPIO_UNSET ((unsigned char)~0U) /* UCHAR_MAX */
>
> Nit: I would name this UPIO_UNKNOWN, or UPIO_NOTSET, unset means to me that
> it was previously set and we undid that action, whereas unknown or not set
> means we never did.
Works for me. I will wait for a few days / week to have more reviews and
likely testings to be collected. Would be nice if you be able to test on
(some of) the hardware in the list of modified drivers.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-21 18:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 18:31 [rft, PATCH v1 00/14] serial: Add a helper to parse device properties and more Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 01/14] serial: core: Move struct uart_port::quirks closer to possible values Andy Shevchenko
2024-02-21 18:54 ` Hugo Villeneuve
2024-02-21 19:04 ` Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type Andy Shevchenko
2024-02-21 18:47 ` Florian Fainelli
2024-02-21 18:53 ` Andy Shevchenko [this message]
2024-02-22 6:58 ` Jiri Slaby
2024-02-22 13:21 ` Andy Shevchenko
2024-02-23 5:42 ` Jiri Slaby
2024-02-23 14:59 ` Andy Shevchenko
2024-02-26 14:17 ` Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 03/14] serial: port: Introduce a common helper to read properties Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 04/14] serial: 8250_aspeed_vuart: Switch to use uart_read_port_properties() Andy Shevchenko
2024-02-26 4:13 ` Andrew Jeffery
2024-02-21 18:31 ` [PATCH v1 05/14] serial: 8250_bcm2835aux: " Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 06/14] serial: 8250_bcm7271: " Andy Shevchenko
2024-02-23 4:14 ` kernel test robot
2024-02-23 15:01 ` Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 07/14] serial: 8250_dw: " Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 08/14] serial: 8250_ingenic: " Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 09/14] serial: 8250_lpc18xx: " Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 10/14] serial: 8250_of: " Andy Shevchenko
2024-02-22 0:37 ` Andrew Jeffery
2024-02-22 13:23 ` Andy Shevchenko
2024-02-22 16:43 ` Andy Shevchenko
2024-02-22 16:47 ` Andy Shevchenko
2024-02-22 17:39 ` Florian Fainelli
2024-02-22 19:54 ` Florian Fainelli
2024-02-23 15:02 ` Andy Shevchenko
2024-02-26 4:12 ` Andrew Jeffery
2024-02-21 18:31 ` [PATCH v1 11/14] serial: 8250_omap: " Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 12/14] serial: 8250_pxa: " Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 13/14] serial: 8250_tegra: " Andy Shevchenko
2024-02-21 18:31 ` [PATCH v1 14/14] serial: 8250_uniphier: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdZGlLoUd_R6JQJc@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alcooperx@gmail.com \
--cc=andrew@codeconstruct.com.au \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=paul@crapouillou.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).