From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C6DDC5478C for ; Thu, 22 Feb 2024 08:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wp9/O6pTTK/2uJm+Rapml/U8sYNAUZ2fsAypaNFWwoI=; b=SKrSI8H/WQw4mQhrVj+1/LDuiD nzdX5xHvNBuqL71O5bdTEW+aDDfVdtf32efLzSjSg2GoB3GGsyOiSCFgu13gKYd3h+KRLvxxjJk60 zENbVO/yqeQ1g/7XTH0FvZNH5/cC1HqhhasNEHgEM5N8sieW0yHpHrV4WS3FU6iFLvA5xH4bYF4+q LW7uAMK6r6IZ62qfGygpGSqz5iN/yRK0olzrQsiqlk/oRriPoZnDfBwFKnEyM9Ou4kQ5UTrGegjZg uFa92khUvVva+BZ3zrcGHpGeWMVRnDsNdkGuGpPM7CJektsZ4+Qb3QkgwOxsjJdgTBJaXD6Fpl+78 RHR33ZCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd45C-00000003vdF-1utI; Thu, 22 Feb 2024 08:05:30 +0000 Received: from www.zeus03.de ([194.117.254.33] helo=mail.zeus03.de) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd457-00000003vZo-3AGc for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 08:05:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=QL5x T9/jYZaLY0gNRestMnTY/ze839aLxh2Y3nXkWDg=; b=di7usoBBJBsxQs1NMKek tTJGWTrHfCkJN2PrZc+9jx7baqG2iebwjHqdY7F6zOF7YXw+Nr7/zyW7uNYR1ybl Cvc2bYWgx1HxswowvBtLDgfFIx91golS0DqYGlnAzDZnO06XN4sdUos7g/LVQmZN i4sC9pBVmFxPaxixJ990TspFn3vg2UTcvRkfgBW+1zjBCAwb9mApaS+M7JPfV2an tahTxGwoL0PZMe+dRBiB5eLsPP9TsyU5vYn5ekHXEDlMeH/3mD2dBblnmCgVFCdk oV5UsAwetD1Rio5pCn5D95BiJxeZvGiZtuAULfYkCqIRpa+KJVjpMOrW0p94+2U7 sw== Received: (qmail 3884259 invoked from network); 22 Feb 2024 09:05:16 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 22 Feb 2024 09:05:16 +0100 X-UD-Smtp-Session: l3s3148p1@R3FP5/MR+qAujnsZ Date: Thu, 22 Feb 2024 09:05:15 +0100 From: Wolfram Sang To: Oleksij Rempel Cc: Andi Shyti , linux-i2c@vger.kernel.org, Corey Minyard , Andrew Manley , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] i2c: imx: when being a target, mark the last read as processed Message-ID: Mail-Followup-To: Wolfram Sang , Oleksij Rempel , Andi Shyti , linux-i2c@vger.kernel.org, Corey Minyard , Andrew Manley , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240221193013.14233-2-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_000526_701278_672AD7C5 X-CRM114-Status: GOOD ( 15.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6937452087736955802==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6937452087736955802== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jkgNTKjjcVM+jmPc" Content-Disposition: inline --jkgNTKjjcVM+jmPc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 22, 2024 at 08:56:00AM +0100, Oleksij Rempel wrote: > > > > When being a target, NAK from the controller means that all bytes h= ave > > > > been transferred. So, the last byte needs also to be marked as > > > > 'processed'. Otherwise index registers of backends may not increase. > > > >=20 > > > > Signed-off-by: Corey Minyard > > > > Tested-by: Andrew Manley > > > > Reviewed-by: Andrew Manley > > > > Reviewed-by: Oleksij Rempel > > > > [wsa: fixed comment and commit message to properly describe the cas= e] > > > > Signed-off-by: Wolfram Sang > > >=20 > > > is this a fix? > >=20 > > In deed, it is: > >=20 > > Fixes: f7414cd6923f ("i2c: imx: support slave mode for imx I2C driver") >=20 > Looks good :) > Are any action needed on my side? Nope. All tags are still valid, I'd say, because I didn't change any code. Thanks! --jkgNTKjjcVM+jmPc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXXADsACgkQFA3kzBSg KbbwkA/+LRNQhXhak4TaZVdgCFqaF4XuPEa1bzs9BwnBYsZG6iOWxmpOFVIS3PTw /CkmYJqtfS7d8ZqePNBXVRZnOH65xX9is66PCtGt4ozPRw8D5QELzBJnsc4Em9ra WeUofTGNtYr/0FBG+fypE8y7yf7XY3hQqeqhEq9s2+I5ONxybHu0TFxMKNgAXDjK Ayc61UaPEOTiT+12Kg1HBWxxzX9FnqUP87JWY8x7o7tf0xN/zXuLs1wDIuH9gWZf GSgs82aqU5mC4vz6TgZOiscwQxwYfqP8k3Ztj+53B9LzV3IeLeqiw1YGfWtM/wSU GYUQUZdO8w79Fld5KePO/XJUU9v8mn8Ye3LF9dmtVpID3i6ByhCPIl/GX+NxGOfL J7XFIgyGPOCq2WuEv9Gg7+OoiBLBv81CaYjPzVRAz73H59cgBDAvy/TFAAO7WYRz wBmfC0Z8QbbnmD1sISc69HQBkdl1ymL4X/MQEn9j9/GfCGTKVH9ak/z/XFDzxJCB aXejjwyHMKII+gm+jn3y8uGKthh0RRG7Fyzv0rZvLoqr7Qqmlq46TRz02vo97kiY 9F5YEZnNZokTJOF/xzSlgYtIMlLQTFuBBCuJ76m2ojXzHgvR3MCNPBQCtreHTfCg B8mt1L3KFYmVwyHeAd7ARxs32a3NmMUxGv7zVy9SHh9E0x0GCq4= =XJvn -----END PGP SIGNATURE----- --jkgNTKjjcVM+jmPc-- --===============6937452087736955802== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6937452087736955802==--