From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C60DDC48BF8 for ; Thu, 22 Feb 2024 09:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bJ5sT5ZrZkXO23X8kJ8UtswmQbtxtqBf1FYx8gB+WaI=; b=UsbTEi/bjcs8WT 7sx36EL9uv+hZ1Ta7CvPxRCZVvDbctq3kjYVNUFdHQkuHlRh6JjJ00ZwANjqpjGl4w/6a9/TagLRz 29ETus3qTar25eJQHBGmN5kQqy1aMSI9z0wD0AEFHg8taF4yVdII/IObfxOCPvZfZ+fouQyMC5VqK LqPGXP8dJcjlftWk6WFHLJY1SOH7xhUBCSWXtBjEk3s5Lde8xtUGQpdfE1vZig19nb0YQIuW2sQh1 nD/O6UlzcJGGbm93FxO5WFUpdOAKDy7SIvboKEIxDMjE1BFDQPr4RpHOow6Dd6Xygt2+IQTTXM9w8 hxaFi8ipBOrx2fh/R6qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd5nh-00000004NaL-0JCl; Thu, 22 Feb 2024 09:55:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd5ne-00000004NZs-1nrG for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 09:55:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 33559C15; Thu, 22 Feb 2024 01:56:07 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 99F803F766; Thu, 22 Feb 2024 01:55:27 -0800 (PST) Date: Thu, 22 Feb 2024 09:55:25 +0000 From: Cristian Marussi To: Sudeep Holla Cc: "Peng Fan (OSS)" , mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V4 2/2] clk: scmi: support state_ctrl_forbidden Message-ID: References: <20240121110901.1414856-1-peng.fan@oss.nxp.com> <20240121110901.1414856-2-peng.fan@oss.nxp.com> <20240222094153.2nxvefa44y5ikutm@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240222094153.2nxvefa44y5ikutm@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_015530_578694_D406C7CE X-CRM114-Status: GOOD ( 26.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 22, 2024 at 09:41:53AM +0000, Sudeep Holla wrote: > On Sun, Jan 21, 2024 at 07:09:01PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Some clocks may exported to linux, while those clocks are not allowed > > to configure by Linux. For example: > > > > SYS_CLK1----- > > \ > > --MUX--->MMC1_CLK > > / > > SYS_CLK2----- > > > > MMC1 needs set parent, so SYS_CLK1 and SYS_CLK2 are exported to Linux, > > then the clk propagation will touch SYS_CLK1 or SYS_CLK2. > > So we need bypass the failure for SYS_CLK1 or SYS_CLK2 when enable > > the clock of MMC1, adding scmi_no_state_ctrl_clk_ops to use software > > enable counter, while not calling scmi api. > > > > Co-developed-by: Cristian Marussi > > Signed-off-by: Cristian Marussi > > Signed-off-by: Peng Fan > > --- > > > > V4: > > Add scmi_no_state_ctrl_clk_ops per Cristian > > Add Cristian's tag > > > > V3: > > Add check in atomic enable > > > > V2: > > New. Take Cristian's suggestion > > > > drivers/clk/clk-scmi.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c > > index 8cbe24789c24..5747b6d651f0 100644 > > --- a/drivers/clk/clk-scmi.c > > +++ b/drivers/clk/clk-scmi.c > > @@ -194,6 +194,15 @@ static const struct clk_ops scmi_atomic_clk_ops = { > > .determine_rate = scmi_clk_determine_rate, > > }; > > > > +static const struct clk_ops scmi_no_state_ctrl_clk_ops = { > > + .recalc_rate = scmi_clk_recalc_rate, > > + .round_rate = scmi_clk_round_rate, > > + .set_rate = scmi_clk_set_rate, > > + .set_parent = scmi_clk_set_parent, > > + .get_parent = scmi_clk_get_parent, > > + .determine_rate = scmi_clk_determine_rate, > > +}; > > + > > static int scmi_clk_ops_init(struct device *dev, struct scmi_clk *sclk, > > const struct clk_ops *scmi_ops) > > { > > @@ -290,8 +299,10 @@ static int scmi_clocks_probe(struct scmi_device *sdev) > > * specify (or support) an enable_latency associated with a > > * clock, we default to use atomic operations mode. > > */ > > - if (is_atomic && > > - sclk->info->enable_latency <= atomic_threshold) > > + if (sclk->info->state_ctrl_forbidden) > > + scmi_ops = &scmi_no_state_ctrl_clk_ops; > > With this, even if is_atomic and latency matches, we won't allow > atomic operations ? One reason why it gets tricky and as Cristian > mentioned elsewhere we need dynamic assignment of these ops IMO. > Let me know if I am getting things wrong here ? It is fine that we wont allow atomic ops either since state_ctrl_forbidden means the server will reject any enable/disable action, atomic or not...what I missed here, though, is that we lost also is_enabled indeed, which could be provided even if state_ctrl_forbidden BUT only if atomic is supported...so yes this will need an additional atomic/non_atomic split of this static ops...and so the need for dynamic allocation I was saying elsewhere....indeed the is_enabled case is handled correctly again with my pending clk dynamic allocation of ops patch. My bad, thanks for spotting this Sudeep! Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel