From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A04EC48BEB for ; Thu, 22 Feb 2024 11:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V7YMTfDdGDxu6cGiRwTEkrcIIweLyhXJ2XnvZJImDGk=; b=wVroP54KQbjMxX n4VhXtcj8tMzU98fsZW8MZ2s07n1evJ7u0+R0ss8NUjqvcXaoEf7o+0XCstqiliDr/hU4V9LlWgMd mqa0rrB6XnOGDXV1jdQIBnTKnGGrIWth3DS6+c7mM73i5E0xjPG08iMjxzSStiKeRMLEjucYi3znt H8gGi4ncPRjM2JCxUdOnGZOHlqcI/U84cKsZyV/yvH+OEuZcMQK9GoBmXrBFP2ok+Er3r/6woZB9O kd/6UME/Gq2PmrGpU2MV8nY00rugg9wd4tabz8P7RwVys2f7RSKL2daV7zum7v1U3S9bw9OdMz0xI 63C/1DtBCCf1Gj9x6Zpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd6oC-00000004ZcS-0MKI; Thu, 22 Feb 2024 11:00:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd6o8-00000004Zbz-3KXO for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 11:00:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5AED8DA7; Thu, 22 Feb 2024 03:00:37 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.79.93]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C2F3B3F73F; Thu, 22 Feb 2024 02:59:57 -0800 (PST) Date: Thu, 22 Feb 2024 10:59:51 +0000 From: Mark Rutland To: Itaru Kitayama Cc: skseofh@gmail.com, catalin.marinas@arm.com, will@kernel.org, ryan.roberts@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: add early fixmap initialization flag Message-ID: References: <20240217140326.2367186-1-skseofh@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_030004_899577_CC043265 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 21, 2024 at 08:14:00AM +0900, Itaru Kitayama wrote: > On Tue, Feb 20, 2024 at 11:55:30AM +0000, Mark Rutland wrote: > > From 5f07f9c1d352f760fa7aba97f1b4f42d9cb99496 Mon Sep 17 00:00:00 2001 > > From: Mark Rutland > > Date: Tue, 20 Feb 2024 11:09:17 +0000 > > Subject: [PATCH] arm64: clean up fixmap initalization > > > > Currently we have redundant initialization of the fixmap, first in > > early_fdt_map(), and then again in setup_arch() before we call > > early_ioremap_init(). This redundant initialization isn't harmful, as > > early_fixmap_init() happens to be idempotent, but it's redundant and > > potentially confusing. > > > > We need to call early_fixmap_init() before we map the FDT and before we > > call early_ioremap_init(). Ideally we'd place early_fixmap_init() and > > early_ioremap_init() in the same caller as early_ioremap_init() is > > somewhat coupled with the fixmap code. > > > > Clean this up by moving the calls to early_fixmap_init() and > > early_ioremap_init() into a new early_mappings_init() function, and > > calling this once in __primary_switched() before we call > > early_fdt_map(). This means we initialize the fixmap once, and keep > > early_fixmap_init() and early_ioremap_init() together. > Thanks for this. Makes sense to me; would you post a proper patch > so I can build and do a boot test, just to make sure? I took a look, and Ard's recent changes to the boot code have removed the duplicate call to early_fixmap_init() by other means, so we don't need to do anything, and can forget about this patch. :) Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel