From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E20F4C48BF8 for ; Thu, 22 Feb 2024 13:22:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WisBbb4NyDjBcKCy/JpjLX6ubN1qGg5XwIuo57Rh7Vw=; b=IaXnqIAD2u1qgA 8XN3Bp6NZ1ESvwDxlKUWpPz4Ypjr/IcJ3JWw/tQL96J942NwS9QrhDJGazSpoBtU26QEpmfoA55x0 mz1HsbXEjIb7SqBBmscwwaFuXcrOYypZsiruq7mi5Ch8aVSXnXeiRwaxLc+kKlXsq/tf6oub5Ahl8 Wfu957uTUlpKWhk9hIWXTJh2gjTZ2CB/eqzXHNC8hq2abOCDM+zjk4uwy7agIUW7tGJNOpfudh5Zr vuc6osbI4hYS1GrfmYX5LWqfYVkP8s26QJKpRsHv4338xG/qTurruPTKTAccMXC6Ioyp41elsglgY 6Hug4CasgA7DJMdSCb5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd91T-00000004zrK-0OqK; Thu, 22 Feb 2024 13:21:59 +0000 Received: from mgamail.intel.com ([198.175.65.9]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd91Q-00000004zqF-0nsm; Thu, 22 Feb 2024 13:21:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708608116; x=1740144116; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LUP/1Bq8oCXj+CsYBpJOUqAEbKSgM+4ilo2mGVOjFxQ=; b=GViAowSmztcIVBPqF0DdlcoaJ8w3MGzKUR/mf2it8Cmz6GZ6iFAkqzrC 1nE20lY//ymu2drDtOTueWEoDmTY5k5Sk0K/QxdBOxjAufJZQ3DlXIbh9 ynBg56S8WGOCOq2m294Oqkpj/QzWgVTgfyaRTytCI8HVQaQCJi8quZ07T kq2ZPBtRypPugodilPPZZeEUQyK2no8vJCiD2Q+EB4skX1T1ftMN5PkPR 1dsx++NkzhQ3V1DgQLMHn9v6kNY406jm3DdqPkMho/YJfRrM7Nr9j+joK NtSlJI6CUFhTd1/5gKlOavbW+PduaHs3gRM741IJKq15EFS5R+QzTCBFx Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="25291951" X-IronPort-AV: E=Sophos;i="6.06,177,1705392000"; d="scan'208";a="25291951" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 05:21:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="913523354" X-IronPort-AV: E=Sophos;i="6.06,177,1705392000"; d="scan'208";a="913523354" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 05:21:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rd91F-00000006dVC-3OPd; Thu, 22 Feb 2024 15:21:45 +0200 Date: Thu, 22 Feb 2024 15:21:45 +0200 From: Andy Shevchenko To: Jiri Slaby Cc: Greg Kroah-Hartman , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org, Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Al Cooper , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Paul Cercueil , Vladimir Zapolskiy , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu Subject: Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type Message-ID: References: <20240221183442.4124354-1-andriy.shevchenko@linux.intel.com> <20240221183442.4124354-3-andriy.shevchenko@linux.intel.com> <5aeee02f-45a6-48e5-a6f4-e55b76d4b959@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5aeee02f-45a6-48e5-a6f4-e55b76d4b959@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_052156_300512_6C38B506 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 22, 2024 at 07:58:32AM +0100, Jiri Slaby wrote: > On 21. 02. 24, 19:31, Andy Shevchenko wrote: ... > > unsigned char iotype; /* io access style */ > > +#define UPIO_UNSET ((unsigned char)~0U) /* UCHAR_MAX */ > > Perhaps making the var u8 and this U8_MAX then? It would make more sense to > me. WFM, should it be a separate change? Btw, how can I justify it? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel