From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clkdev: Update clkdev id usage to allow for longer names
Date: Fri, 23 Feb 2024 17:48:18 +0200 [thread overview]
Message-ID: <Zdi-QnkPYUFWLJIe@smile.fi.intel.com> (raw)
In-Reply-To: <20240223141857.3794855-1-michael.j.ruhl@intel.com>
On Fri, Feb 23, 2024 at 09:18:14AM -0500, Michael J. Ruhl wrote:
> clkdev ID information is limited to arrays of 20 and 16 bytes
> (MAX_DEV_ID/MAX_CON_ID). It is possible that the IDs could be
> longer that. If so, the lookup will fail because the "real ID"
> will not match the copied value.
Perhaps you need to add a real example.
> Increase the size of the IDs to allow for longer names.
...
> -#define MAX_DEV_ID 20
> -#define MAX_CON_ID 16
> +#define MAX_DEV_ID 32
> +#define MAX_CON_ID 32
Do we need to alter both?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-23 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 14:18 [PATCH] clkdev: Update clkdev id usage to allow for longer names Michael J. Ruhl
2024-02-23 15:48 ` Andy Shevchenko [this message]
2024-02-23 16:09 ` Ruhl, Michael J
2024-02-23 16:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zdi-QnkPYUFWLJIe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael.j.ruhl@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).