From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52E2DC5478C for ; Fri, 23 Feb 2024 11:38:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6XLs1DdjlrMbCe89cAbqOvMeMTspL38/ElRtWuBhD1I=; b=vp5bPAAF8mZdF2 Mi6Lw3ouM1DWB/j1y5qPcL1IK4sA6k7hUaU/2tx4yFusGu+FoarQmzFZ1grnOKRqIeL543ru+ehSE cUOF93Wmpf4xKxIv+oPJIzQpz9gBaq8YQ82uqyCjtSXW62mDKhjuzJrCu9T3HIslohn2yQQ4AGk6i h6A8hnrxL0Njr4qZIczIlAgIxn1e9K8nYYXK/oK3+xSkHHYO4QDxzx9Y+s13PznePer9sVvz7nMrZ 0tstoUcVBjTBX9NUjZPhocLWI7pLTj9xLfXaKQqvtLPkEl6wG+x7tflx0Ioc+nadKbl2FavZdBeSO xTtS3bKMu42c9ivzmbvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdTt1-000000099tB-0lMd; Fri, 23 Feb 2024 11:38:39 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdTsm-000000099lc-3XbR for linux-arm-kernel@lists.infradead.org; Fri, 23 Feb 2024 11:38:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 33A1911FB; Fri, 23 Feb 2024 03:38:52 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 828FC3F762; Fri, 23 Feb 2024 03:38:11 -0800 (PST) Date: Fri, 23 Feb 2024 11:38:09 +0000 From: Cristian Marussi To: "Peng Fan (OSS)" Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sudeep Holla , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: Re: [PATCH 1/5] dt-bindings: firmware: add i.MX SCMI Extension protocol Message-ID: References: <20240202-imx95-bbm-misc-v1-0-3cb743020933@nxp.com> <20240202-imx95-bbm-misc-v1-1-3cb743020933@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240202-imx95-bbm-misc-v1-1-3cb743020933@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240223_033826_521106_14100930 X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 02, 2024 at 02:34:39PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Add i.MX SCMI Extension protocol BBM and MISC binding. > Hi, just a few remarks down below only about the SCMI related stuff... > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/firmware/nxp,scmi.yaml | 64 ++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/nxp,scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,scmi.yaml > new file mode 100644 > index 000000000000..00d6361bbbea > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/nxp,scmi.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2024 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/nxp,scmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX System Control and Management Interface (SCMI) Protocol Extension > + ... (SCMI) Vendor Protocols > +maintainers: > + - Peng Fan > + > +allOf: > + - $ref: arm,scmi.yaml# > + > +properties: > + protocol@11: protocol@81 ? > + $ref: 'arm,scmi.yaml#/$defs/protocol-node' > + unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x81 > + > + protocol@13: protocol@84 ? > + $ref: 'arm,scmi.yaml#/$defs/protocol-node' > + unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x84 > + > + wakeup-sources: > + description: each entry consists of 2 integers and represents the source and edge > + items: > + items: > + - description: the wakeup source > + - description: the wakeup edge > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + > +additionalProperties: false > + > +examples: > + - | > + firmware { > + scmi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + protocol@81 { > + reg = <0x81>; > + }; > + > + protocol@84 { > + reg = <0x84>; > + wakeup-sources = <6 1 > + 7 1 > + 8 1 > + 9 1 > + 10 1>; > + }; > + }; > + }; > +... > Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel