From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01806C54798 for ; Fri, 23 Feb 2024 15:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V25Vm23jDJStCC9KSoh87GSm7Zfhe9SvICI6KUpaqPM=; b=TN3uMPldfgrxA6 J4XfKHXIO4PlKBA8G6C5leQq4iEDIoP1+ypniGe93jXa13Z8kOPgr71YjEHYKyxhZ29gc94xHhS8n PASq+7ol2O2eJJIBS+71pX5WDl/zerNXE4gTOhb+x8AaoB7n7QAxVKsbKEjdLlGfliulcYu78EhQF lmsWg0f8qI+qAOCVb/XFUTnoFNdZw6g4nzSmR9iwcGIcUk3dhOa86v92imjNPJ4Ik68LwLwgMRcDs klsiqKYajh5DQyDjEN4L9b5RZ/HY22yJDQlnqTbOik3LggK4CDEEPPtXAM/P3kXgiNXdDSxfQrgA/ VSyR648y7gF2EMIUXZHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdX2A-00000009tUZ-209B; Fri, 23 Feb 2024 15:00:18 +0000 Received: from mgamail.intel.com ([198.175.65.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdX23-00000009tMU-2w0n; Fri, 23 Feb 2024 15:00:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708700412; x=1740236412; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tKzaZ4SrfW3NZnt7/A7BvgRIDvidSwzO3kkc6CIop9s=; b=Y57OUIQmZnOEyzC2QDFRDEnvqmx4cTPuVWNgEXq/Bhpa2h7bdsVNvu7i kA+d5tNMuA9Do+/Hbhsu1O5vpkEfGl6kSdWarBoOjM+PJPqOjfh/oYfPx p0Z98QQMqDJAVJPnrf85c3Hmsn0ZzOKZfmgM7E3SeX3cdyHIFjcoZpfyN l+dyysO+qAWqNNT6/WhOmr8A3gvDDq/C8C1sNa2PWDgalLNSIA05kp4Hv g1jqAgFwqihanmMWkWnRPUpcAcTlCCExOTXmeIHq7vVayKUlSjWVOo277 uUA9KJQ1b8DwLJioRtYfY0SNKaG494JfRmCzo+Y5a164+80AINWVH4Txa Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6832447" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6832447" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 06:59:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="913748299" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="913748299" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 06:59:28 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rdX1I-00000006ve5-4BqP; Fri, 23 Feb 2024 16:59:25 +0200 Date: Fri, 23 Feb 2024 16:59:24 +0200 From: Andy Shevchenko To: Jiri Slaby Cc: Greg Kroah-Hartman , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org, Joel Stanley , Andrew Jeffery , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Al Cooper , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Paul Cercueil , Vladimir Zapolskiy , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu Subject: Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type Message-ID: References: <20240221183442.4124354-1-andriy.shevchenko@linux.intel.com> <20240221183442.4124354-3-andriy.shevchenko@linux.intel.com> <5aeee02f-45a6-48e5-a6f4-e55b76d4b959@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240223_070011_991039_C950C8E8 X-CRM114-Status: GOOD ( 21.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 23, 2024 at 06:42:15AM +0100, Jiri Slaby wrote: > On 22. 02. 24, 14:21, Andy Shevchenko wrote: > > On Thu, Feb 22, 2024 at 07:58:32AM +0100, Jiri Slaby wrote: > > > On 21. 02. 24, 19:31, Andy Shevchenko wrote: ... > > > > unsigned char iotype; /* io access style */ > > > > +#define UPIO_UNSET ((unsigned char)~0U) /* UCHAR_MAX */ > > > > > > Perhaps making the var u8 and this U8_MAX then? It would make more sense to > > > me. > > > > WFM, should it be a separate change? > > Likely. Then I need a commit message, because I'm unable to justify this change myself. > > Btw, how can I justify it? > > Hmm, thinking about it, why is it not an enum? Maybe, but it is a replica of UAPI definitions, do we want to see it as a enum? To me it will be a bit ugly looking. > But it could be also an u8 because you want it be exactly 8 bits as you want > to be sure values up to 255 fit. Depends on what we assume UAPI does with those flags. It maybe even less than 8 bits, or great than, currently 8 bits is enough... TL;DR: I would rather take a patch from you and incorporate into the series than trying hard to invent a justification and proper type. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel