From: Shawn Guo <shawnguo2@yeah.net>
To: Manuel Traut <manuel.traut@mt.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6ul: Set macaddress location in ocotp
Date: Sat, 24 Feb 2024 07:33:09 +0800 [thread overview]
Message-ID: <ZdkrNfkXGo2pprLW@dragon> (raw)
In-Reply-To: <20240208122012.1959628-1-manuel.traut@mt.com>
On Thu, Feb 08, 2024 at 01:19:59PM +0100, Manuel Traut wrote:
> If a bootloader does not configure the MAC address, devices come up with
> a random MAC at the moment.
>
> ocotp provides registers for storing the mac-address.
> Configure those for i.MX6UL and i.MX6ULL allows net/core to retrieve it from
> there.
>
> Signed-off-by: Manuel Traut <manuel.traut@mt.com>
> ---
> arch/arm/boot/dts/nxp/imx/imx6ul.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
> index a27a7554c2e7..e5e8bf814f77 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
> @@ -538,6 +538,8 @@ fec2: ethernet@20b4000 {
> fsl,num-rx-queues = <1>;
> fsl,stop-mode = <&gpr 0x10 4>;
> fsl,magic-packet;
> + nvmem-cells = <&fec2_mac_addr>;
> + nvmem-cell-names = "mac-address";
> status = "disabled";
> };
>
> @@ -897,6 +899,8 @@ fec1: ethernet@2188000 {
> fsl,num-rx-queues = <1>;
> fsl,stop-mode = <&gpr 0x10 3>;
> fsl,magic-packet;
> + nvmem-cells = <&fec1_mac_addr>;
> + nvmem-cell-names = "mac-address";
> status = "disabled";
> };
>
> @@ -1004,6 +1008,14 @@ tempmon_temp_grade: temp-grade@20 {
> cpu_speed_grade: speed-grade@10 {
> reg = <0x10 4>;
> };
Have a newline between nodes.
> + fec1_mac_addr: mac-addr@88 {
> + reg = <0x88 6>;
> + };
> +
> + fec2_mac_addr: mac-addr@8e {
> + reg = <0x8e 6>;
> + };
> +
Dropped this one.
I fixed them up and applied the patch.
Shawn
> };
>
> csi: csi@21c4000 {
> --
> 2.43.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-02-23 23:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 12:19 [PATCH] ARM: dts: imx6ul: Set macaddress location in ocotp Manuel Traut
2024-02-23 23:33 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdkrNfkXGo2pprLW@dragon \
--to=shawnguo2@yeah.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.traut@mt.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).