From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02BDDC48BF6 for ; Sat, 24 Feb 2024 08:22:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DlmvHLLmtV1Yxsi2Qp/IKiRwspvai2qw+kzYv7X/P6I=; b=p6Qq9z2N0x5TGT 5994spgUvixC7mV3mIqKaZ+tdqRjwpFo5XrA6LyghQIf1snPZMzf7QkwzccPprZulYP76pDLExSN5 I1AICbPqUFbtRlBV95OeOd4zrSLCEisPeDxAl1r/rDXQMKpfE+O12TRVIdGMn2GZyQL7RUr2DI/7/ ZArha23jc3wckjscWJS29VHx3zy5mcVGlbvPD5Sqs3kvnt5cyVJSVX84Vv0Tq40/qutcX3V7UTIWH AJgINZyJA8/mNEG0K9gnc5pZVWGU/FtLVsuQYIZPUuUrS6fP+r8oBtTADq/QCYcI5etyWExWZutOo ChR4mrIVowljWxqQMaaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdnIo-0000000CLas-0l49; Sat, 24 Feb 2024 08:22:34 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdnIl-0000000CLaV-1nWc for linux-arm-kernel@lists.infradead.org; Sat, 24 Feb 2024 08:22:32 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5dc949f998fso839491a12.3 for ; Sat, 24 Feb 2024 00:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708762950; x=1709367750; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=m+cjQi/gR/Rij9z4IYqT76yUA9ZBG8wKYNwhgxvzNpA=; b=Au2qGLaHUFGx7G5x2y3rMH//WtlV5AJlOpl1+vsonyfiM4MXHlwsZg9ZwmukkkDMdg 1fqyRbKEEfXZ033QDzzhQFIr0ZhH2/KscI8IVqFMkhTln8V6DKeqemXPat+E9PEFOxPQ ionUZxXDnCs5jQID70j0QSQsZJha+mlF/WOXCiLFrj6w5nhwAJ0wO0ZIfmcNSw5rLYNn IFGZN3aABL1G1sC74N33T5PT62cgDPrI4kOx1FPOwqLaAtwOc3No+1XxFSia0Co7+tlC 31sLBGsmGEaIqGz7feGUbAXsDkjjRR3yipDUalgZc3N73owRkCmFJw/gJNwlWLgVLEyz 7zqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708762950; x=1709367750; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=m+cjQi/gR/Rij9z4IYqT76yUA9ZBG8wKYNwhgxvzNpA=; b=SqpwptZZOQBkPMv4A5doqLYogJ8e14kliNtv644HnKUtXxIrfuU8QrkXJ16tOEskRY ohlwYAk+dqXaI1XQxbMh++BcGGTiXZ1IUM2A0nhsssYmyWTVytlhf6uXYZNXfxsZtG27 7DbbCxKvl1reBeCh8drzjRAmwNPGS2gprC5tyQw3vpCBNhOkrPto1yb0kb6LdJ45Qkp5 LhnRbd7dZ8WI5inC2XBEHhDO61PON3UYR7kWDwCrlLej334/bFqz4n4bHIhMwGrtLyCl ImCg/yO0IvRD5x7s22vY9BQZR6k9LUFWZxpGIsYE0oD88n+cqGWIBtMsZdOFPm9KMawG hEcQ== X-Forwarded-Encrypted: i=1; AJvYcCU8nZmDbXEVNo+JolW4Vfn1EPK/tet56uQM9tJ2G86OgCXFiHm42r3yTV8Kd3mXT/kdnlcbZBLnblyeJh6HkjllcdzF9CmpuWBgTe6V+rNZOq8IvxA= X-Gm-Message-State: AOJu0YwKefuCnm8Cpk1XPyLnutQZYDSSPGL2X5MKkKW6ME5HbKZqaqD9 RIFSLD/5zk1TpU6Wqy7MdVoVkVfLYeb/4xk4dUnPULasWd0S81ZGYKucmXwXSsh4vw== X-Google-Smtp-Source: AGHT+IHxejnlqw/pNJAX9X/KU1/Cnfg20mLZoFcxZvSsEuxhvcSwELoBUgKHY4SAmDatTq3aJM68Dw== X-Received: by 2002:a05:6a00:3305:b0:6e4:8ea9:5e5c with SMTP id cq5-20020a056a00330500b006e48ea95e5cmr2299586pfb.27.1708762950181; Sat, 24 Feb 2024 00:22:30 -0800 (PST) Received: from linux-8mug (220-129-204-58.dynamic-ip.hinet.net. [220.129.204.58]) by smtp.gmail.com with ESMTPSA id f17-20020a056a001ad100b006e47664b05dsm645247pfv.212.2024.02.24.00.22.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 00:22:29 -0800 (PST) Date: Sat, 24 Feb 2024 16:22:25 +0800 From: Chester Lin To: Ghennadi Procopciuc Cc: Andreas Farber , Matthias Brugger , Shawn Guo , Sascha Hauer , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , NXP S32 Linux Team , Pengutronix Kernel Team , NXP Linux Team , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Ghennadi Procopciuc , Ciprian Costea Subject: Re: [PATCH v2 2/2] arm64: dts: s32g: add uSDHC node Message-ID: References: <20240122140602.1006813-1-ghennadi.procopciuc@oss.nxp.com> <20240122140602.1006813-3-ghennadi.procopciuc@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240122140602.1006813-3-ghennadi.procopciuc@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240224_002231_492597_D3D77745 X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ghennadi, On Mon, Jan 22, 2024 at 04:06:01PM +0200, Ghennadi Procopciuc wrote: > From: Ghennadi Procopciuc > > Add the uSDHC node for the boards that are based on S32G SoCs. > > Signed-off-by: Ciprian Costea > Signed-off-by: Ghennadi Procopciuc > --- > arch/arm64/boot/dts/freescale/s32g2.dtsi | 10 ++++++++++ > arch/arm64/boot/dts/freescale/s32g274a-evb.dts | 6 +++++- > arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts | 6 +++++- > 3 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi > index ef1a1d61f2ba..fc19ae2e8d3b 100644 > --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi > +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi > @@ -138,6 +138,16 @@ uart2: serial@402bc000 { > status = "disabled"; > }; > > + usdhc0: mmc@402f0000 { > + compatible = "nxp,s32g2-usdhc"; > + reg = <0x402f0000 0x1000>; > + interrupts = ; > + clocks = <&clks 32>, <&clks 31>, <&clks 33>; Same as I have mentioned in [PATCH v2 1/2], could we have fixed dt-bindings to replace with these raw clock id values (32, 31, 33)? Chester > + clock-names = "ipg", "ahb", "per"; > + bus-width = <8>; > + status = "disabled"; > + }; > + > gic: interrupt-controller@50800000 { > compatible = "arm,gic-v3"; > reg = <0x50800000 0x10000>, > diff --git a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts > index 9118d8d2ee01..00070c949e2a 100644 > --- a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts > +++ b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0-or-later OR MIT > /* > * Copyright (c) 2021 SUSE LLC > - * Copyright (c) 2019-2021 NXP > + * Copyright 2019-2021, 2024 NXP > */ > > /dts-v1/; > @@ -32,3 +32,7 @@ memory@80000000 { > &uart0 { > status = "okay"; > }; > + > +&usdhc0 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts > index e05ee854cdf5..b3fc12899cae 100644 > --- a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts > +++ b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0-or-later OR MIT > /* > * Copyright (c) 2021 SUSE LLC > - * Copyright (c) 2019-2021 NXP > + * Copyright 2019-2021, 2024 NXP > */ > > /dts-v1/; > @@ -38,3 +38,7 @@ &uart0 { > &uart1 { > status = "okay"; > }; > + > +&usdhc0 { > + status = "okay"; > +}; > -- > 2.43.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel