From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76DEEC48BF6 for ; Sat, 24 Feb 2024 10:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eZvVo0LY4RbvJP7ryq9KzB7lCXve+5JKGFm9ra6PASI=; b=NzOJKncBBW/n17 BeW+Mdgma36wmep22AGv9mKRc0/M1DBmxyBtOa3nEDeWGcKUuOe3OXJ92KUvgYjLE/GA/2cqAWtv0 UWZl8PfsKo0Kz0pkHSNdxdJSIl1aWc5dz6UbiSThmpgMSuS70aj9te6BnXKoSq07qoF9ybMluAgqp pAKCTPn+z2ip9E2bl0tGfvqKe+9UsPJhj/lV2cHCD4AwNX3rfH6yqSYdCD+riO+mA3OgLrD194rcI THpjjWTAKX2d+CjhckkKCkswB+g0uT8PDWM5Lf1rIHHzF5GPt0ruAMUBI0BaJnEFiyT6LtoHkW26W gadtRxRAQ3M9t5zEvxtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdpWs-0000000Ccsj-0y8z; Sat, 24 Feb 2024 10:45:14 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdpWp-0000000CcsA-1w1Z for linux-arm-kernel@lists.infradead.org; Sat, 24 Feb 2024 10:45:12 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1dc1ff3ba1aso13855525ad.3 for ; Sat, 24 Feb 2024 02:45:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708771510; x=1709376310; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XVqOjvQSDEDKq31auMq76nWKFY0pe+j+Ca5udl4+VwU=; b=l5Zi3TK7AhklFHZQyEhe7nh5JQiR/KNEhdrgCSqHgHvB87F+57ILIFXab+y9cDSO7I harRYJcaMMBEulEfSkf4Whg7goyDL7JpDK2RfLk58u9gYN5YydCkI9emL+PE7Z5yuD+T Yy2Vk7j28C4xuLYOjKdgfWBwbyTz9x0nSuxyGkwQv7y2/J9NHDoB6lGZCobJWU3PnBZz 7aCZygZ5UHAFkLUUwVFmCOKjiWY5uA1mV01Z42wJfuaHyeSQYPWSgMlJuB+c0W7IBcQ4 b4Ecb/F7es1ZwKJKYIEnnrJx98hfSeokvD5xVKVjm7U+3n9kbubnN6rXDH+G7PkOl/PD +vww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708771510; x=1709376310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XVqOjvQSDEDKq31auMq76nWKFY0pe+j+Ca5udl4+VwU=; b=PjrJEm/SOiHjiygu3vYN0tXxL4Mt0TjUhRMRCUYMqYhqNH15jJwByRK5iati2Tn3hi K5ScrcOIqycNEucdNJUjmHd08PAqVBOP/tXdGBlrMgYSYpGOj1I+MxrFuiDgKbxUZp/d EvTyOQy0m7Gw9KRgp2XNupmp8ndR+KvAmi6DYSyxD19dG2IwzR9btLYsKMoIbv1URvcv D4XNQ27b5rT6p9km21b8NDGnWuyURCYPAvmU4neu7H1fgDfWGHddJtyQL1ryqKqizTrI 4GV+7DeRot6fADQawauDCWbR4grlIQIeEViLyUKUeSIuWejK8LDxLS/Xf3WICKFHZpcb OjWA== X-Forwarded-Encrypted: i=1; AJvYcCWcNIwITyhAZSxW7pPn1YvSO5j8wCrsFc1IzXvKY9axlyP/sLPtIzscnRR+nNDGvuovdlVWfGGR8x7/NhK3zVhYLcn/ScQEK1wa5/BXusHW+b8Ar5g= X-Gm-Message-State: AOJu0Yyu4zqfM4vXhcGmUJiGuEBREohhqsaUOzBrOkwUTMWCZXLf4ZCL 7AlNzwB59N1T//Omsqp9LTxSg3mHELEL/bJsiSOby8MCvkdy1Dsl X-Google-Smtp-Source: AGHT+IGTCcw1nPo5uilPjR3XkAVmnW1KGl5IrYp5yQPGFpjcH9vaGA0Owygfz8dt8AbR2tyHeqGzQw== X-Received: by 2002:a17:903:2607:b0:1db:c6a0:d023 with SMTP id jd7-20020a170903260700b001dbc6a0d023mr1849674plb.8.1708771510260; Sat, 24 Feb 2024 02:45:10 -0800 (PST) Received: from linux-8mug (220-129-204-58.dynamic-ip.hinet.net. [220.129.204.58]) by smtp.gmail.com with ESMTPSA id ko8-20020a17090307c800b001db3361bc1dsm795726plb.102.2024.02.24.02.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Feb 2024 02:45:09 -0800 (PST) Date: Sat, 24 Feb 2024 18:44:55 +0800 From: Chester Lin To: Ghennadi Procopciuc Cc: Andreas Farber , Matthias Brugger , Shawn Guo , Sascha Hauer , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , NXP S32 Linux Team , Pengutronix Kernel Team , NXP Linux Team , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Ghennadi Procopciuc , Ciprian Costea Subject: Re: [PATCH v2 2/2] arm64: dts: s32g: add uSDHC node Message-ID: References: <20240122140602.1006813-1-ghennadi.procopciuc@oss.nxp.com> <20240122140602.1006813-3-ghennadi.procopciuc@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240224_024511_529888_78053D06 X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ghennadi, On Sat, Feb 24, 2024 at 04:22:30PM +0800, Chester Lin wrote: > Hi Ghennadi, > > On Mon, Jan 22, 2024 at 04:06:01PM +0200, Ghennadi Procopciuc wrote: > > From: Ghennadi Procopciuc > > > > Add the uSDHC node for the boards that are based on S32G SoCs. > > > > Signed-off-by: Ciprian Costea > > Signed-off-by: Ghennadi Procopciuc > > --- > > arch/arm64/boot/dts/freescale/s32g2.dtsi | 10 ++++++++++ > > arch/arm64/boot/dts/freescale/s32g274a-evb.dts | 6 +++++- > > arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts | 6 +++++- > > 3 files changed, 20 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi > > index ef1a1d61f2ba..fc19ae2e8d3b 100644 > > --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi > > +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi > > @@ -138,6 +138,16 @@ uart2: serial@402bc000 { > > status = "disabled"; > > }; > > > > + usdhc0: mmc@402f0000 { > > + compatible = "nxp,s32g2-usdhc"; > > + reg = <0x402f0000 0x1000>; > > + interrupts = ; > > + clocks = <&clks 32>, <&clks 31>, <&clks 33>; > > Same as I have mentioned in [PATCH v2 1/2], could we have fixed dt-bindings to > replace with these raw clock id values (32, 31, 33)? > Just found the previous review discussion in v1: https://lore.kernel.org/all/f54d947c-58dc-498f-8871-b472f97be4a8@oss.nxp.com/ What I'm worried is that, could these raw clock IDs be rearranged in the downstream TF-A? If so it would cause ABI inconsistency and clock issues since the kernel is not aware of any raw ID changes in downstream TF-A. Chester > > + clock-names = "ipg", "ahb", "per"; > > + bus-width = <8>; > > + status = "disabled"; > > + }; > > + > > gic: interrupt-controller@50800000 { > > compatible = "arm,gic-v3"; > > reg = <0x50800000 0x10000>, > > diff --git a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts > > index 9118d8d2ee01..00070c949e2a 100644 > > --- a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts > > +++ b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts > > @@ -1,7 +1,7 @@ > > // SPDX-License-Identifier: GPL-2.0-or-later OR MIT > > /* > > * Copyright (c) 2021 SUSE LLC > > - * Copyright (c) 2019-2021 NXP > > + * Copyright 2019-2021, 2024 NXP > > */ > > > > /dts-v1/; > > @@ -32,3 +32,7 @@ memory@80000000 { > > &uart0 { > > status = "okay"; > > }; > > + > > +&usdhc0 { > > + status = "okay"; > > +}; > > diff --git a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts > > index e05ee854cdf5..b3fc12899cae 100644 > > --- a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts > > +++ b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts > > @@ -1,7 +1,7 @@ > > // SPDX-License-Identifier: GPL-2.0-or-later OR MIT > > /* > > * Copyright (c) 2021 SUSE LLC > > - * Copyright (c) 2019-2021 NXP > > + * Copyright 2019-2021, 2024 NXP > > */ > > > > /dts-v1/; > > @@ -38,3 +38,7 @@ &uart0 { > > &uart1 { > > status = "okay"; > > }; > > + > > +&usdhc0 { > > + status = "okay"; > > +}; > > -- > > 2.43.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel