From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9A75C48BF6 for ; Sat, 24 Feb 2024 11:03:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KbiSlcPSJpYX23Gp/8wVTdMlhMHrn1rp1PC6+6n/kFM=; b=Nqwx6cZ0f8s4MD oarYBVesEu6FshW1PgRRF73BRlaPMxTkRo8z1g8d3iWFnNxBNnHjgG7Hs1PJpmHu3JPrtaAPJuuyG 2K0eCjKgxL3I/6EPJonQaz3I4Wmg+kST3WV1LBS6Nq2I19Rg1pgGhf9VbDzX0KxL5AGBkRQM0Q5h1 59Kidi6ApGIEDIw9IRHJN8Mec7uIh3M4jL8wj/ul2+X8uHvHjVj/MhRZCqvXXmoWdMVJLvYGe6rp3 Xd9mp+JxF4VidQMRwfBWX7t2aL+psf0u66+mebsDnZFjiEXYRnBxhJoX0HWwCml80mZ62aC9ZezMk +F0NzWei0r59OScEG0EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdpnz-0000000CfM4-3oMC; Sat, 24 Feb 2024 11:02:55 +0000 Received: from out-170.mta0.migadu.com ([91.218.175.170]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdpnx-0000000CfLN-0G3u for linux-arm-kernel@lists.infradead.org; Sat, 24 Feb 2024 11:02:54 +0000 Date: Sat, 24 Feb 2024 11:02:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708772568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vuWp/+7BcPYQXEWx/FGeNBwG2S56ypB+UYiRZv6cNM4=; b=SVkU/0KOQbxe4zhbMr3MEjYxu/5B6QD+MuxKlmxcTzwOcIYpDaHYA0/0XmxIEgUR7ZE1pG tq3vAoQsj2/P9WvPOZRO1kcgG11YUhVcBQuE9mU77Zvb25s0hUH+rH4QFl/+nUDpVvoGqO d+Kx0MHdeBHQ6mweiSFL9KqbQn9b4Po= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: Thomas Gleixner , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, Jing Zhang Subject: Re: [PATCH 2/3] irqchip/gic-v3-its: Spin off GICv4 init into a separate function Message-ID: References: <20240219185809.286724-1-oliver.upton@linux.dev> <20240219185809.286724-3-oliver.upton@linux.dev> <87cysm9mtv.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87cysm9mtv.wl-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240224_030253_532900_EBD9AA1E X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 24, 2024 at 10:30:04AM +0000, Marc Zyngier wrote: > On Mon, 19 Feb 2024 18:58:07 +0000, Oliver Upton wrote: > > @@ -3193,7 +3210,8 @@ static void its_cpu_init_lpis(void) > > * ancient programming gets left in and has possibility of > > * corrupting memory. > > */ > > - val = its_clear_vpend_valid(vlpi_base, 0, 0); > > + its_clear_vpend_valid(vlpi_base, 0, 0); > > + return; > > I'm not sure about the necessity of this return statement. > allocate_vpe_l1_table() checks for rvpeid already, so it should be > fine to carry on. Yup, definitely not necessary. My aim was to have the control flow make it a bit more obvious to the reader what's going on. Having what reads as an allocation helper do a feature check isn't entirely obvious. I have no opinion either way though. > > } > > > > if (allocate_vpe_l1_table()) { > > @@ -3205,15 +3223,6 @@ static void its_cpu_init_lpis(void) > > gic_rdists->has_rvpeid = false; > > gic_rdists->has_vlpis = false; > > } > > - > > - /* Make sure the GIC has seen the above */ > > - dsb(sy); > > ... we're now missing a dsb affecting the VPE table programming, as we > expect things to take effect immediately. LOL, and on the back of a bugfix no less. I'll fix this. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel