From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B834C48BF6 for ; Sat, 24 Feb 2024 11:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=24uagnux/EqspbUnM3eLemMqiUaJgP80GRboZnSUnZY=; b=1sqHecDAymSbx2 cKPsbmS8IFuokqWdoqO9JAzAL/guKABRQc5yZONUp/N161dtES/awfLKwmfDYRsWR7zn2DiV55nMC J1pw3qRpv1iiSs2CEpLR9E98qp1cx66Zf9LQeXK45Oh26X18tygER7Ik+TiyZeWU9tXz7HYxnBM16 PWUTaZXamGH2DnKkZvhIeOk+KkdFtNi+hnqzi6BpDyGVbKtWIyHQwpfgzVUT0UrIvg5xAYnXl3H3X 5jWZOz9nCh4OtwqOpETTxsTZs5FuYbBrUOxuX3VH3NHFQsQCrcHDS9e69sji4Ubf3ZhEXTfPPoBk5 yWrqyeUgvZHdGCYXUFTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdpwf-0000000CgXQ-1paE; Sat, 24 Feb 2024 11:11:53 +0000 Received: from out-188.mta1.migadu.com ([2001:41d0:203:375::bc]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdpwc-0000000CgVl-1wHJ for linux-arm-kernel@lists.infradead.org; Sat, 24 Feb 2024 11:11:51 +0000 Date: Sat, 24 Feb 2024 11:11:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708773105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OQrVRzuuc7x4zdDY3sLDy+NO1SlXGxkB6DC5Uppljl8=; b=eZXKR2Pd1Av/I9U0Ezk8UX3ar7+YfQR9ykGcdg53Bk1TOg+ookw+EyPFAK2sLn7p4F/kj7 7NV+FsLpg5Z2ZwWuN1/8xTQDQ5xVyfMiBbG2p7WdFYTMcYOA4LLLO+iub7pGskJ7UW7wRo Vk2iwcs7k6ApyTs5xY/hlNxxDLInrW0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: Thomas Gleixner , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, Jing Zhang Subject: Re: [PATCH 3/3] irqchip/gic-v3-its: Print the vPE table installed in redistributor Message-ID: References: <20240219185809.286724-1-oliver.upton@linux.dev> <20240219185809.286724-4-oliver.upton@linux.dev> <87bk869man.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87bk869man.wl-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240224_031150_663080_B0D707FB X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 24, 2024 at 10:41:36AM +0000, Marc Zyngier wrote: > On Mon, 19 Feb 2024 18:58:08 +0000, Oliver Upton wrote: > > - pr_debug("CPU%d: VPROPBASER = %llx %*pbl\n", > > - smp_processor_id(), val, > > - cpumask_pr_args(gic_data_rdist()->vpe_table_mask)); > > + pr_info("CPU%d: Using %s vPE table @%llx (%s)\n", > > + smp_processor_id(), > > + (val & GICR_VPROPBASER_4_1_INDIRECT) ? "indirect" : "direct", > > + val & GICR_VPROPBASER_4_1_ADDR, > > + (page) ? "allocated" : > > + ((from_its) ? "inherited from ITS" : "inherited from RD")); > > From past experience, having the vpe_table_mask value displayed did > help tracking VPE table affinity bugs. My reasoning behind it was that the change expanded the table mask by way of printing what's going on at every RD. But easy enough to throw back in! > This said, my problem with this patch is that we already have tons of > these statement printed once per CPU/RD. This is really huge and > accounts for a significant part of the boot time on large machines > (64+ CPUs). > > Before we add more of those, I'd really want to have a way to tone > them down and only print them at runtime *if* required by the user. > Kind of a dymanic debug, but driven from the command-line and present > early enough. Yeah, what'd be really nice is a way to enable pr_debug() on a per file / driver / whatever basis, since turning on all of it becomes a bit of a firehose... But I guess that's what grep is for. WDYT about leaving it at pr_debug() for now, with the additional context of what exactly VPROPBASE is getting programmend with? -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel