From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 773E7C47DD9 for ; Sun, 25 Feb 2024 11:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iyWgTy9Bn+SqKKBnXXcVDBybjimH7rfZp3E4ske0/Xk=; b=JrfJtXyS4qsBWr FEyxuJ0iUycLhRy/YzdLZWCjlaZWip7MjkB0usjLUVUxFdvIAP/JZekYU0/0y371DzxqF7FJj42eQ +23Wyf/macvUDUR6uJziuUhpF9HjFiiMu/RKc+P+E8g9PqpmYS0YVrSDNArqHHfoo/y5N304NJ9hq ERXR67VtUi0jo7GdgRCHfxNB7geWidoxXvBXt1Uqvm94TqR5QbxX92/kzhozr0AS4M2wGN8EVahUc YdW7h1xUUeo4w2hmxnFZcFA4e4p55yzVmqLnAoOTeeb3xK8Lo57emBDNtG9Qk7l5TTO88FR8FfFos Zr7PpahFTxb1K84d4RKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reCjo-0000000Er2j-3MnS; Sun, 25 Feb 2024 11:32:08 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reCjm-0000000Eqnf-1snM for linux-arm-kernel@lists.infradead.org; Sun, 25 Feb 2024 11:32:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qt7H2ZIh3v/Vcrg3evn+aruHV87xiNC9x1F3o9juqsA=; b=cDHw84OKV28nQBC6K8olsExeJA VSrWnBpyRHxPC5ZjzqX5aXz4lrpdcrGSEd3WmYoWDeSTKrkxpJWcdjHm8U/VRZOboPIkdNJPPBSg8 kctsmTYCGW/UQ9DWoAKu9rI6K1KZDA5gh9VcDLNNuR0o4rmCbcKgpujj7bNLGwI2UhQhiZu0zaTuE sNAJVDqhiW6rFNZ6RPYp/2eceULS3mA9ZE6C8a3iaq4T/wAzEN+9qnmFCAh9TF2tzC/D9X8Njw0gf r+UykDIQsUlc8LIjJ/HQdYuLRsD1qmOnzo18mqhgx7+Q11ke63Mcvvf1iI182yJd87vHjaiZ710Mn nYbZqd8w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54804) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1reChh-0007Mq-23; Sun, 25 Feb 2024 11:29:57 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1reChe-0005TB-3y; Sun, 25 Feb 2024 11:29:54 +0000 Date: Sun, 25 Feb 2024 11:29:53 +0000 From: "Russell King (Oracle)" To: Duoming Zhou Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com Subject: Re: [PATCH] ARM: mvebu: Prevent null pointer dereference caused by kzalloc failure Message-ID: References: <20240225060401.52768-1-duoming@zju.edu.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240225060401.52768-1-duoming@zju.edu.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240225_033206_534209_BDE7BC47 X-CRM114-Status: GOOD ( 10.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 25, 2024 at 02:04:01PM +0800, Duoming Zhou wrote: > The kzalloc() in i2c_quirk() will return null if the physical > memory has run out. As a result, if we dereference the new_compat > pointer, the null pointer dereference bug will happen. > > This patch adds a check to avoid null pointer dereference. Yet again another janitorial patch that is Way too focused on a single issue, rather than analysing the code and proposing the best fix. :( What if the two kstrdup() fail? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel