From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC0FCC54E49 for ; Mon, 26 Feb 2024 11:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LhnYvTe9wqu/fPzzZ1UopK+HIJwzWdCxKt1tyiHkMU0=; b=MmlEnxsOKc0+e8 fcFb+fPYKdVVPdjQfrSPiHdlti3Kv+MECeJFYyPUThLv73ShAFJtvucodk+WZimoPkPaUVbL69slX DbUFpXPZ2sh42EYoETg1w5grGgJCGBRSrMZGGT+LUEH93sC17Cr0Zcm7NUTMbE7a/Mnt/vWBtZx5X 2xbF8sp1dGQ1lmkzqHQHswQVJMpit+ln5prufbmUNf0i2gC8ZAvOECYNfVzguMOxaQIAVbG9T06tw SJA5Jux40Mtf1p89DB1OOH2oSYiKppDJ3yV/kDGys9H7+S5bFVCuI68fwfGVSiQj/3+czH1T+S5cB WCJVoSC4TFaHguQjJ+cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reZTI-00000000Pku-0Pc4; Mon, 26 Feb 2024 11:48:36 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reZT2-00000000Pb6-3QQn for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 11:48:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gw1YcQC9qtJ4/pe66V7YRq+GAf4l9U7OKSN0ldpLYSY=; b=brVvD7gLhZJfWAo8PU5vLdHgiY kdXs2ki0PBjRk/pm7+3gkSDljK1QxtoBZeyd8T+RUXMw9AUUjEuYYJ+vLcSnbqtqk74jX6Xc4GE3x XFX1+7DuIl4b7pTlP9DUxZvqxsMdrQ6/aAo5Yt5IyYF5DP+s36IinJu0HbOsg07TqnyCxHHgwX2Ky HnGs5GLG8BPOhvHM94GvuLxrxxNGy3WuXv4ekVOpOZC/OrkT3kvOMssX3fh+QLX6ieE1pn1MQDhnL JOis2meDoCyogwRu1Se4ystHBJPtbfLHPaoNB72w9rN9zygg7PMxSGBtjvAT3xrFex7WMTbppgRgj yjfwBftQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56924) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1reZSY-0003A6-2J; Mon, 26 Feb 2024 11:47:50 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1reZSS-0006P5-Tm; Mon, 26 Feb 2024 11:47:44 +0000 Date: Mon, 26 Feb 2024 11:47:44 +0000 From: "Russell King (Oracle)" To: Christophe Leroy Cc: Charlie Jenkins , Guenter Roeck , David Laight , Palmer Dabbelt , Andrew Morton , Helge Deller , "James E.J. Bottomley" , Parisc List , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Palmer Dabbelt , Linux ARM Subject: Re: [PATCH v10] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests Message-ID: References: <20240223-fix_sparse_errors_checksum_tests-v10-1-b6a45914b7d8@rivosinc.com> <7ae930a7-3b10-4470-94ee-89cb650b3349@csgroup.eu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7ae930a7-3b10-4470-94ee-89cb650b3349@csgroup.eu> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_034821_528604_F1FE55AE X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 26, 2024 at 11:34:51AM +0000, Christophe Leroy wrote: > Le 23/02/2024 =E0 23:11, Charlie Jenkins a =E9crit=A0: > > The test cases for ip_fast_csum and csum_ipv6_magic were not properly > > aligning the IP header, which were causing failures on architectures > > that do not support misaligned accesses like some ARM platforms. To > > solve this, align the data along (14 + NET_IP_ALIGN) bytes which is the > > standard alignment of an IP header and must be supported by the > > architecture. > = > I'm still wondering what we are really trying to fix here. > = > All other tests are explicitely testing that it works with any alignment. > = > Shouldn't ip_fast_csum() and csum_ipv6_magic() work for any alignment as = > well ? I would expect it, I see no comment in arm code which explicits = > that assumption around those functions. No, these functions are explicitly *not* designed to be used with any alignment. They are for 16-bit alignment only. I'm not sure where the idea that "any alignment" has come from, but it's never been the case AFAIK that we've supported that - or if we do now, that's something which has crept in under the radar. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel