From: Abel Vesa <abel.vesa@linaro.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com,
sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
shengjiu.wang@gmail.com, marex@denx.de, m.felsch@pengutronix.de,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: imx: imx8mp: Fix SAI_MCLK_SEL definition
Date: Mon, 26 Feb 2024 11:04:28 +0200 [thread overview]
Message-ID: <ZdxUHAg2UZOU/s4h@linaro.org> (raw)
In-Reply-To: <1708683351-8504-1-git-send-email-shengjiu.wang@nxp.com>
On 24-02-23 18:15:51, Shengjiu Wang wrote:
> There is SAI1, SAI2, SAI3, SAI5, SAI6, SAI7 existing in this block
> control, the order is discontinuous. The definition of SAI_MCLK_SEL(n)
> is not match with the usage of CLK_SAIn(n).
>
> So define SAI##n##_MCLK_SEL separately to fix the issue.
>
> Fixes: 6cd95f7b151c ("clk: imx: imx8mp: Add audiomix block control")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/clk/imx/clk-imx8mp-audiomix.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c
> index e4300df88f1a..55ed211a5e0b 100644
> --- a/drivers/clk/imx/clk-imx8mp-audiomix.c
> +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
> @@ -18,7 +18,12 @@
>
> #define CLKEN0 0x000
> #define CLKEN1 0x004
> -#define SAI_MCLK_SEL(n) (0x300 + 4 * (n)) /* n in 0..5 */
> +#define SAI1_MCLK_SEL 0x300
> +#define SAI2_MCLK_SEL 0x304
> +#define SAI3_MCLK_SEL 0x308
> +#define SAI5_MCLK_SEL 0x30C
> +#define SAI6_MCLK_SEL 0x310
> +#define SAI7_MCLK_SEL 0x314
> #define PDM_SEL 0x318
> #define SAI_PLL_GNRL_CTL 0x400
>
> @@ -95,13 +100,13 @@ static const struct clk_parent_data clk_imx8mp_audiomix_pll_bypass_sels[] = {
> IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK1_SEL, {}, \
> clk_imx8mp_audiomix_sai##n##_mclk1_parents, \
> ARRAY_SIZE(clk_imx8mp_audiomix_sai##n##_mclk1_parents), \
> - SAI_MCLK_SEL(n), 1, 0 \
> + SAI##n##_MCLK_SEL, 1, 0 \
> }, { \
> "sai"__stringify(n)"_mclk2_sel", \
> IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK2_SEL, {}, \
> clk_imx8mp_audiomix_sai_mclk2_parents, \
> ARRAY_SIZE(clk_imx8mp_audiomix_sai_mclk2_parents), \
> - SAI_MCLK_SEL(n), 4, 1 \
> + SAI##n##_MCLK_SEL, 4, 1 \
> }, { \
> "sai"__stringify(n)"_ipg_cg", \
> IMX8MP_CLK_AUDIOMIX_SAI##n##_IPG, \
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-26 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 10:15 [PATCH] clk: imx: imx8mp: Fix SAI_MCLK_SEL definition Shengjiu Wang
2024-02-26 9:04 ` Abel Vesa [this message]
2024-02-26 9:16 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZdxUHAg2UZOU/s4h@linaro.org \
--to=abel.vesa@linaro.org \
--cc=abelvesa@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=marex@denx.de \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).