From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3666C54E49 for ; Mon, 26 Feb 2024 09:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OGdFXpLYDh94FoAnccQygdHd+fTGi5mAbtDhxvh7abw=; b=FBo3hfqC4zidIa PCOuB4cIHe1CFe8OzhJByptRpsv5wllfwvixbG8Ui9umI5lmKq42UXR8iQjig0xEMzYpUyrSU3s9w pNbzXx7Jfg9k3P02A/znP732/V3mhOJtiDPLkM76IRm8/qHUYSHLZH9fg90ijVSI5w4G5hf2yrt2F yX/1CQ2ptiLgxyRCUr8J2MKT/OpIxTJl5NcO5B0MS0NQes41oiDpwrARP1gXEcvcfJ9Ryf88Cnpmy 7eFe+QLjOhJCtq4/3X5wXXkdukHBjud2BM3tUNWwXM08ImHZv4iF7AH1AiYPOupLYcUrYJ1DS0pTM 0PegiccipdsPp4qF/8Uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1reWua-0000000HDKX-2shx; Mon, 26 Feb 2024 09:04:36 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1reWuX-0000000HDHv-0biZ for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 09:04:34 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a293f2280c7so386326966b.1 for ; Mon, 26 Feb 2024 01:04:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708938271; x=1709543071; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XK97/Ais5pPf/X1///jyXhhD+o5dKRJYFfX0RVnBU80=; b=xXs8FP+HLItflheaCGS3TX+2N70L8ijhPrgULU8iF+/nTZRua0sp23ubqEeYZR4KFc EZbp7U0iMA28KR9IH3xv8byUvveuu9/bvzcwpebjWKjslevopKdtPoVy0M/TsULCM+Nd ZpbFOjhLpJZ2dynVhzuNYibqFdj62WTtlAbM7bzDo0K4sTOoQurb5dPnpvGAQ9S7I6O5 cRAnRxjZESXMlP34pvag8AEIKr0lab+njuWX4lHfT7QWCxMnRz/ft2AW4CD7UP4bEwK8 jy+shuv83qY+en18+WGIfeT92ahpqEMzdObsfGkuDMZwg3SVA6ETYLKYw/9vbvx5Q7Ka VAfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708938271; x=1709543071; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XK97/Ais5pPf/X1///jyXhhD+o5dKRJYFfX0RVnBU80=; b=FChekoZj0r42+owbRVpdL8bfOxlcpVTIgmwtmkngn9Q8Vv4eB2qHiz8ktvm4yuK5gM 69sSs+B1cvr/GHX5bNMFNnAbo+zlGCSyNneOkeDN3q4Gphhux22NaZs66cAEPp305DBa 4UxBXRrXDRtWJ3/lXrvy0Ak6sQQSCoDVCoKnYniENEgr7YOc6TThx0qOijGQDm3/hy6T 0kU75P+phWWdQbrpMp8l2pCGDIMuA+cOpNju1N1n20/6AGUPMcOuIr1JMNjnLAzPYJ7t rW0ESabT7IoYxrbiYpIMwPd5tCpXndo+lGhMdoyx0u9p2REuIrsju3ajDmVd1o+Lknob rmpQ== X-Forwarded-Encrypted: i=1; AJvYcCVOeB7sicNVXCfnyRWODmOTFEECOUWN3fLAdygnfJUrsLlN4oU6qL2XNxTJWbbYiecIXkWnQqSOJFJ2bPYIYqEeXeB52tUFFfiIFjWNWBiyf6jGI9o= X-Gm-Message-State: AOJu0Yy4rFGVrpeuPZ7hg5AluZbWsmkxOkqdjf74NwWEXxO4FAlTGYlI RgyZTuhySp1ZLVgNDCK+l/kUZ6ic5mPRXVkAbr2XhW/bknKG0+5vzaTH8sbqBCc= X-Google-Smtp-Source: AGHT+IEP31lrkAYgXHTXfaTNGbJ5RbfHTcM0xJ2Z+InoGeeBiYd/7OfA29vMJCRwdLnHEOFQNbp6Rw== X-Received: by 2002:a17:906:c2d8:b0:a43:2fa9:c05b with SMTP id ch24-20020a170906c2d800b00a432fa9c05bmr1842731ejb.41.1708938270828; Mon, 26 Feb 2024 01:04:30 -0800 (PST) Received: from linaro.org ([188.24.162.93]) by smtp.gmail.com with ESMTPSA id i20-20020a1709061cd400b00a3f2bf468b9sm2244445ejh.173.2024.02.26.01.04.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 01:04:30 -0800 (PST) Date: Mon, 26 Feb 2024 11:04:28 +0200 From: Abel Vesa To: Shengjiu Wang Cc: abelvesa@kernel.org, peng.fan@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, shengjiu.wang@gmail.com, marex@denx.de, m.felsch@pengutronix.de, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: imx: imx8mp: Fix SAI_MCLK_SEL definition Message-ID: References: <1708683351-8504-1-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1708683351-8504-1-git-send-email-shengjiu.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_010433_267059_3E8A8065 X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-02-23 18:15:51, Shengjiu Wang wrote: > There is SAI1, SAI2, SAI3, SAI5, SAI6, SAI7 existing in this block > control, the order is discontinuous. The definition of SAI_MCLK_SEL(n) > is not match with the usage of CLK_SAIn(n). > > So define SAI##n##_MCLK_SEL separately to fix the issue. > > Fixes: 6cd95f7b151c ("clk: imx: imx8mp: Add audiomix block control") > Signed-off-by: Shengjiu Wang Reviewed-by: Abel Vesa > --- > drivers/clk/imx/clk-imx8mp-audiomix.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c > index e4300df88f1a..55ed211a5e0b 100644 > --- a/drivers/clk/imx/clk-imx8mp-audiomix.c > +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c > @@ -18,7 +18,12 @@ > > #define CLKEN0 0x000 > #define CLKEN1 0x004 > -#define SAI_MCLK_SEL(n) (0x300 + 4 * (n)) /* n in 0..5 */ > +#define SAI1_MCLK_SEL 0x300 > +#define SAI2_MCLK_SEL 0x304 > +#define SAI3_MCLK_SEL 0x308 > +#define SAI5_MCLK_SEL 0x30C > +#define SAI6_MCLK_SEL 0x310 > +#define SAI7_MCLK_SEL 0x314 > #define PDM_SEL 0x318 > #define SAI_PLL_GNRL_CTL 0x400 > > @@ -95,13 +100,13 @@ static const struct clk_parent_data clk_imx8mp_audiomix_pll_bypass_sels[] = { > IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK1_SEL, {}, \ > clk_imx8mp_audiomix_sai##n##_mclk1_parents, \ > ARRAY_SIZE(clk_imx8mp_audiomix_sai##n##_mclk1_parents), \ > - SAI_MCLK_SEL(n), 1, 0 \ > + SAI##n##_MCLK_SEL, 1, 0 \ > }, { \ > "sai"__stringify(n)"_mclk2_sel", \ > IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK2_SEL, {}, \ > clk_imx8mp_audiomix_sai_mclk2_parents, \ > ARRAY_SIZE(clk_imx8mp_audiomix_sai_mclk2_parents), \ > - SAI_MCLK_SEL(n), 4, 1 \ > + SAI##n##_MCLK_SEL, 4, 1 \ > }, { \ > "sai"__stringify(n)"_ipg_cg", \ > IMX8MP_CLK_AUDIOMIX_SAI##n##_IPG, \ > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel