From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF5ADC48BF6 for ; Mon, 26 Feb 2024 14:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g+t0I6YclFwL8F6farmegXyh66ZTvMjLx8YpekYAT2E=; b=NQTyGiyqH/iXa5 PF+RAb600cUNOgrod7ylnTaaQIhvloGa63Fzh0SzVWwt1PGoWVgTzVA1/yNuyCQHldaTA75yhzef/ 3OAqoTf5mb5yyAxzaItJ1cd8odEBdYm6oygWuGBmDRk3g7v7hxDXW7EcCyoWnV9gPAWjmva/U0Zst rdLTNon9a7E3WdQtlFT4L6y80Uh3ERrA18mLq83SkjkufYF9QbTgzyMvKomEQd9+/3izICiikC/SA U/3ayBdtdTfgtdj60Ak7JWB+GTYPDBedMGG352wbGdkoMzu/jkjiVf4lFqndN5W0MiMiRTiGWJF0Q mEngvwQZ1/0FzPNWqJiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1recBw-00000001DKk-13ko; Mon, 26 Feb 2024 14:42:52 +0000 Received: from mgamail.intel.com ([198.175.65.12]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1recBr-00000001DEk-2GHd for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 14:42:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708958567; x=1740494567; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EUJ5esbYjUapXTYbha5kyIY8tScY0s/JJFha6imEgQw=; b=RqE5GtsAo9OE+DMW6lA75x9Hjwl20+ohbdURI2zBxp7EqV9HsNm1Wtri 1/B9CVbT3c4w174C7k6V+EkiXBp5ygltEsA5nn4aWzPvcnzQzArB9PrrA KMH6c/+LXa1dOCHd7cyaQKOLi+VB0dHgblFxR7PkGe/2nt0KR84WPQ9w2 7DP1zJbmGHY4zY9wBNLhnvwGwjlEx5pCUMMRHd23unEwS8+vN8lKZbRcz Lh/bejFRXOQ2SYh8SFVyGKMe1nGz4teyU8xs4H54KAxTLgO6WHOYxh4j5 Y8cNUmoyHrKdtvbpl39gR/GGXRC39zV9A9APhX2miaK7SDY1qGwmiS8nh w==; X-IronPort-AV: E=McAfee;i="6600,9927,10995"; a="14681149" X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="14681149" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 06:42:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10995"; a="913873886" X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="913873886" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 06:42:36 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1recBd-00000007hqk-1zwX; Mon, 26 Feb 2024 16:42:33 +0200 Date: Mon, 26 Feb 2024 16:42:33 +0200 From: Andy Shevchenko To: nikita.shubin@maquefel.me Cc: Hartley Sweeten , Alexander Sverdlin , Russell King , Dmitry Torokhov , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Linus Walleij , Thierry Reding , Damien Le Moal , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH v8 23/38] input: keypad: ep93xx: add DT support for Cirrus EP93xx Message-ID: References: <20240226-ep93xx-v8-0-3136dca7238f@maquefel.me> <20240226-ep93xx-v8-23-3136dca7238f@maquefel.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240226-ep93xx-v8-23-3136dca7238f@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_064247_809779_41234806 X-CRM114-Status: GOOD ( 15.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 26, 2024 at 10:30:19AM +0300, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin > > - drop flags, they were not used anyway > - add OF ID match table > - process "autorepeat", "debounce-delay-ms", prescale from device tree > - drop platform data usage and it's header > - keymap goes from device tree now on ... > struct ep93xx_keypad { > - struct ep93xx_keypad_platform_data *pdata; > struct input_dev *input_dev; > struct clk *clk; > + unsigned int debounce; > + uint16_t prescale; In case you need to send a new version note that the indentation of the fields is different here. Also uint16_t is not the type we expect to see usually (does the file use it already?). In kernel we have u16. > void __iomem *mmio_base; -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel