From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E270C5475B for ; Mon, 11 Mar 2024 17:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5HKXKsNw2QVQqNz3EU+QnrZ7l25Jg9iwAM1haV7FckM=; b=My6FIxFN1HmK4Z 5PAwXZ74MOpHJ7lw4DxXCxL6SJD4hFNDT0/zd9qrsdlLL6qOuBGema9vGqAGwGv5uzJEw+1gD/Srj l2UZk1yoQU+P/2E/BRRAKLvhGIjjK8pjOeY00rbE5rimepFrS4fwUwnwv1sJW3Leac5DZsvaGWJXq WpETaOLCSzoL1MDG5lq0DT58ztJcCa5cyzQoq4peVatchl6pIeaHgO9nrj8enIxKMNqww4AS5YqH4 GVrG+LPS6wy+ZTTPB9b4gTxac1KjjP1m8X5YIVJLyPSduU+zGl7/yuwtZ8BYZc1CgZBzBcsTz8Rst Uv7i5z2qoHGdlDQTvW+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjj8N-00000002Rt8-0yjl; Mon, 11 Mar 2024 17:08:19 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rjj8J-00000002Rrg-3Pvj for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2024 17:08:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 175D260F0D; Mon, 11 Mar 2024 17:08:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A02EC43390; Mon, 11 Mar 2024 17:08:10 +0000 (UTC) Date: Mon, 11 Mar 2024 17:08:08 +0000 From: Catalin Marinas To: Marek Szyprowski Cc: Mark Rutland , "Christoph Lameter (Ampere)" , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Jonathan.Cameron@huawei.com, Matteo.Carlini@arm.com, Valentin.Schneider@arm.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, Eric Mackay , dave.kleikamp@oracle.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux@armlinux.org.uk, robin.murphy@arm.com, vanshikonda@os.amperecomputing.com, yang@os.amperecomputing.com, Nishanth Menon , Stephen Boyd Subject: Re: [PATCH v3] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512 Message-ID: References: <37099a57-b655-3b3a-56d0-5f7fbd49d7db@gentwo.org> <8abb1a69-6cbd-4a36-ab1d-d269cdafa391@samsung.com> <8c8aea4d-e911-44cd-bbec-ead4e44d338a@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8c8aea4d-e911-44cd-bbec-ead4e44d338a@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240311_100815_921721_F4215702 X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 11, 2024 at 05:51:04PM +0100, Marek Szyprowski wrote: > On 11.03.2024 16:22, Catalin Marinas wrote: > > On Mon, Mar 11, 2024 at 03:56:37PM +0100, Marek Szyprowski wrote: > >> On 11.03.2024 13:12, Mark Rutland wrote: > >>> On Fri, Mar 08, 2024 at 09:08:59AM -0800, Christoph Lameter (Ampere) wrote: > >>>> On Fri, 8 Mar 2024, Marek Szyprowski wrote: > >>>>>>> It looks that cpufreq-dt and/or opp drivers needs some adjustments > >>>>>>> related with this change. > >>>>>> That's strange. Is this with defconfig? I wonder whether NR_CPUS being > >>>>>> larger caused the issue with this specific code. Otherwise > >>>>>> CPUMASK_OFFSTACK may not work that well on arm64. > >>>> cpumask handling must use the accessor functions provided in > >>>> include/linux/cpumask.h for declaring and accessing cpumasks. It is likely > >>>> related to the driver opencoding one of the accessors. > >>> I took a look at both the OPP code and the cpufreq-dt code and it looks like > >>> those are doign the right thing w.r.t. cpumask manipulation (i.e. they only use > >>> the cpumask accessors, and use the cpumask_var_*() functions to dynamically > >>> allocate/free cpumasks). Maybe I've missed something, but superficially those > >>> look right. > >>> > >>> Marek, can you try reverting this commit and trying defconfig + NR_CPUS=512? > >> Yes, with $subject reverted and CONFIG_NR_CPUS=512 everything works > >> fine, so it must be something else broken. > > Thanks for confirming. Would you mind testing the problematic commit > > with CONFIG_DEBUG_PER_CPU_MAPS enabled? If it doesn't show anything > > obvious that can be fixed quickly, I'll revert the commit and queue it > > again after -rc1 for 6.10 (I haven't sent 6.9 the pull request yet). > > I've enabled this option, but unfortunately it didn't reveal anything > more besides the warning and error I've posted in my initial report. I > will try to analyze this issue further, but I won't manage to do this today. No worries, thanks for giving this a try. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel