From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A56E6C48BF6 for ; Thu, 29 Feb 2024 10:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YPKVx+GpE0ZIO6eaRI5S/A4nuFRbJfr1Q1KibihSvI4=; b=t+ifnD1U83jyUM E9E4VR8vXFTsajcAOMaLqYl0VeyF6egJlcrTk7+8dip4/Du5D+MzhD7vYwJPMrotu2tpoxgE/DYdO 0LA0NFk8z+xnd6bkWMq69yfKi7mRk98X3PDkZSXoF1JSJ7CbYQ8UyEE1VOa2J2/knwFtPNP8Y1APt zUP8ADnfcMmh12p63NDsNuDimfDd9xStKj56ToTc5pbNNAiiLZNgPLYRPdsm82zulpdigqQGmIdYH zxWTQXDq2pveKiKKwFHTZAc1pnNcjY0DR39iBlekuQM3JWc739XGoo4sL3WTNpWrGgMtnq/OdGAIw wB4FaqCAuGF6d2XmByfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfe8S-0000000DGXi-14G4; Thu, 29 Feb 2024 10:59:32 +0000 Received: from mgamail.intel.com ([198.175.65.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfe8P-0000000DGWL-0dnQ for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 10:59:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709204369; x=1740740369; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YjdLAAQGiT0XCs7CLBYxxn9xZUUhhDnrttXTbBDNBak=; b=APKkcurN3+rRf5am4IzJ/iuALooDcsFYrV2MKB6E7CsuGKDLo5nSkcAh ejyqCM6Y6TL4nO/6Ef24JPVNA9AgTUXax0UVbQkaPjZHSwB8gBciT3b7e SUvHf+Vi6zGNFw5JTbbAYXkFiIuRI9Gt7+vVnYZvLzVAxx0lrPOOMCl5a +jncWVsi8dph5W2b16vAwKrtr95E/o3xVL3IgJsI03Gu/hXbQZsWJ12f1 wqgbbWy3ZhdJITGF4++itCz0X4H4uaU7n7AMBQmd3LeraqvifgDfcfUGt ZcFB3iRpwgo0yafETqMJjYZ7gKz5EHN17KgrmekalAqRz1IDehYWTp4BI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="3789955" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="3789955" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 02:59:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="913979088" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="913979088" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 02:59:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rfe8G-00000008eD8-3SLO; Thu, 29 Feb 2024 12:59:20 +0200 Date: Thu, 29 Feb 2024 12:59:20 +0200 From: Andy Shevchenko To: Kees Cook Cc: Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: [PATCH v4 1/8] overflow: Use POD in check_shl_overflow() Message-ID: References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-2-andriy.shevchenko@linux.intel.com> <202402281332.9B2F13570@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202402281332.9B2F13570@keescook> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_025929_273956_0994196D X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 28, 2024 at 01:33:15PM -0800, Kees Cook wrote: > On Wed, Feb 28, 2024 at 10:41:31PM +0200, Andy Shevchenko wrote: > > The check_shl_overflow() uses u64 type that is defined in types.h. > > Instead of including that header, just switch to use POD type > > directly. > > > > Signed-off-by: Andy Shevchenko > > Acked-by: Kees Cook Based on the further discussion this seems pretty independent. Can you take it through your tree? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel