From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48209C54E41 for ; Thu, 29 Feb 2024 14:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ROdLA1SpMc4bJ+zwTYWspCIKpjVj0VUwUmtZFpBdkEg=; b=TEJx/TV5NAIWpv lBjM4O8rR9qyj/ZF0OKotBz7Aqfp6ucbVGt42pv6pZccNMM1jRydFXrkQTRk5E5rz8AhB20dD6RbM QmBkpyD5lEmnzxbijCS0O/eTW59Yqo800qc0uVC7QfvR9Ev2m5vtT2RhRyVdZfEOspWUYMiUuFmVM 8I6ryFSU4UdGpZDSDwJSdHA56LSIq11YnSaOtbl2LCcjZ+tXe54TfUXoKP7CjWFC4gb6nSoNi8Nei 7fOCyRa23wi8OnuMVCVBO1DbSjosnxEF1RfjskKAZMw88CQG1qx3qBlmV00MI3TrGu9LutWdqQrTL YVy7X17zuEXlhhDoJNtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfhQh-0000000Dsi1-3LnV; Thu, 29 Feb 2024 14:30:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfhQe-0000000Dshd-49ES for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 14:30:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74F331FB; Thu, 29 Feb 2024 06:31:07 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.68.196]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 816B33F6C4; Thu, 29 Feb 2024 06:30:26 -0800 (PST) Date: Thu, 29 Feb 2024 14:30:23 +0000 From: Mark Rutland To: Jinjie Ruan Cc: catalin.marinas@arm.com, will@kernel.org, ardb@kernel.org, broonie@kernel.org, masahiroy@kernel.org, robh@kernel.org, scott@os.amperecomputing.com, joey.gouly@arm.com, ndesaulniers@google.com, anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] arm64: Remove enable_daif macro Message-ID: References: <20240229132802.1682026-1-ruanjinjie@huawei.com> <20240229132802.1682026-2-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240229132802.1682026-2-ruanjinjie@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_063033_093151_33BD1836 X-CRM114-Status: GOOD ( 13.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 29, 2024 at 09:28:01PM +0800, Jinjie Ruan wrote: > Since commit bb8e93a287a5 ("arm64: entry: convert SError handlers to C"), > the enable_daif assembler macro is no longer used anywhere, so remove it. > > Signed-off-by: Jinjie Ruan > --- > arch/arm64/include/asm/assembler.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm64/include/asm/assembler.h b/arch/arm64/include/asm/assembler.h > index ce7b95cd6e79..ab8b396428da 100644 > --- a/arch/arm64/include/asm/assembler.h > +++ b/arch/arm64/include/asm/assembler.h > @@ -38,10 +38,6 @@ > msr daifset, #0xf > .endm > > - .macro enable_daif > - msr daifclr, #0xf > - .endm > - I have no strong feelings either way on this; I had been waiting to remove this along with disable_daif, but removing the latter requires some more substantial work. FWIW, for this as-is: Acked-by: Mark Rutland Mark. > /* > * Save/restore interrupts. > */ > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel