From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF2C2C48BF6 for ; Thu, 29 Feb 2024 18:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RE3jQAeN0/QsSVQ1arx6Kvj2jEtb0kncTgEtyoZ/q4o=; b=nCkDIuhV5OGZZmgd11RDyHGicJ +f3ebKxNvDboXTOX1jIoZGpuYybF8Lqulwjsmt3UNDNza/n7vRIe4bwsE1LHy/XyI12s3SZ/whCLo QvAQ7QHweSIglkaShZ3wuxVXdG83MguYUgLZHCRoI89geNEFR5a5SaI9McGVCNavoZRYKee/af7Vl SNNTd18X4qzgG7uFc+OIX42NBTOQM7/gkDug0Ny3PAgMb6Ed5FHjtzRv45yj4JPcoOMEFpIGvCjcL 9ztWyGePSFSZiDwRLLm4A7RjrPZWn09x8cKeOTsgllP3FK4+46Z0j38v0IuMJX2hmoPpPE0ty9tLt xrmkFBeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rflbn-0000000EnsF-1qWX; Thu, 29 Feb 2024 18:58:19 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rflbk-0000000EnrR-3Hsh for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 18:58:18 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-412bc3350d0so7666125e9.1 for ; Thu, 29 Feb 2024 10:58:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709233094; x=1709837894; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QOMkV8+zwYA3EDl4Oj8veMVbhFWWtMnCBkuFp1N+OIc=; b=gtw0WDicJGRqvNYms4vJm217pBQA9qtfDO7DpCkYTw8GgKzB2o6eb3Ctb6+B59YlT+ vQ0kguVib095TwguVhzv7ihSaACnxuZ2NmYAvS5HsspWZ05C7w4WNhY023zvzjRr4jDl fBwo5KbfZmEgHh58lCrDd1x5Tg10vYqsy4Fo3Mv2HrS/10hjLu9l+QL8xzM5+FqjP+3P 83kWuhQJO3kkshJ1oKkyQZ59IwJTsW7s/Rrb700lXtFavWsNo4B0jTKalevKBr4u3P45 v3a8PqaKoJj+lL2MIkJ6kI7673mrnaqzPGtJ5mkETG1S+PAVGBtOonC29l4ubXtx9qCQ YYyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709233094; x=1709837894; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QOMkV8+zwYA3EDl4Oj8veMVbhFWWtMnCBkuFp1N+OIc=; b=jfyTGPTtRKN3+2nOVSB9JpowziuiMiHTTBCJw4j7zawouSk5f0B1tGNuNxI4v8Z4uK 1SksDyRIu1x/2ovRlZxtWOuAVcRfjPSj32/dXS+9oQKeEfTth6sPiYmF8MalYeqKwdQs zEEGwKum2CZ2+oeu/gOuAwC5wsgbNeqgm8OfRg/nKobP1CcU0+SCuUGvstnZYtiQXr1O Hen+B+ajhsiUsTHMPHYrFPcYzufMGakjzV0OttmlHB+qScFtoYbbNjBnoADTuQvzgc8A nCPTN0IXXDDvaRnscxGv928E0VoQqpb4jGDO58CftBrVixHOcJQDtt3Llkp5vEJJ7aLp RtQA== X-Forwarded-Encrypted: i=1; AJvYcCVk9CSmGGGHAqPgg2tV/H5pX9NKFd6/TaShsOEk1m3qK89CZTzLwj+mggGygtzXJ07wjMCiiE8/+7u8G6eP8TWYvyI0H5MQg+40wA8fZ1d8Z3itCbQ= X-Gm-Message-State: AOJu0Yy4Msjs8R4aRqzmhxMfvGdIceUZeUONetT2XVmNHlLjabx71M2J puAn49st3kplJXO5CwWdGlV2F68i0wDNRs+WmYpALmcagbq7uCAsaAJFfTdp56C0HmoQxXOzfJD a X-Google-Smtp-Source: AGHT+IE6N6/fBwdedrFzOy5DgpuEwQoJ27wC7Wfz2Gw6PuOexlU0y1KaywrIq7wNyzeVlhR8897a1g== X-Received: by 2002:a05:600c:1d24:b0:412:b74a:452a with SMTP id l36-20020a05600c1d2400b00412b74a452amr2732349wms.29.1709233094459; Thu, 29 Feb 2024 10:58:14 -0800 (PST) Received: from ishi ([185.243.57.250]) by smtp.gmail.com with ESMTPSA id fc18-20020a05600c525200b00412aeb77bbcsm2863560wmb.19.2024.02.29.10.58.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 10:58:14 -0800 (PST) Date: Thu, 29 Feb 2024 13:58:08 -0500 From: William Breathitt Gray To: Fabrice Gasnier Cc: lee@kernel.org, alexandre.torgue@foss.st.com, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Vignesh Raghavendra , Julien Panis , Syed Nayyar Waris Subject: Re: [PATCH v3 04/10] counter: stm32-timer-cnt: introduce clock signal Message-ID: References: <20231220145726.640627-1-fabrice.gasnier@foss.st.com> <20231220145726.640627-5-fabrice.gasnier@foss.st.com> <599a7357-b4d6-4581-9d5c-c1d0ade3e410@foss.st.com> MIME-Version: 1.0 In-Reply-To: <599a7357-b4d6-4581-9d5c-c1d0ade3e410@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_105816_862173_F2AD153A X-CRM114-Status: GOOD ( 26.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3790811739149103903==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3790811739149103903== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="el6dlSHLw0+sJrWy" Content-Disposition: inline --el6dlSHLw0+sJrWy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 27, 2024 at 06:43:20PM +0100, Fabrice Gasnier wrote: > On 1/8/24 17:46, William Breathitt Gray wrote: > > On Wed, Dec 20, 2023 at 03:57:20PM +0100, Fabrice Gasnier wrote: > >> Introduce the internal clock signal, used to count when in simple risi= ng > >> function. Also add the "frequency" extension to the clock signal. > >> > >> With this patch, signal action reports a consistent state when "increa= se" > >> function is used, and the counting frequency: > >> $ echo increase > function > >> $ grep -H "" signal*_action > >> signal0_action:none > >> signal1_action:none > >> signal2_action:rising edge > >> $ echo 1 > enable > >> $ cat count > >> 25425 > >> $ cat count > >> 44439 > >> $ cat ../signal2/frequency > >> 208877930 > >> > >> Signed-off-by: Fabrice Gasnier > >=20 > > Reviewed-by: William Breathitt Gray > >=20 > > The code is all right, but some minor suggestions below. > >=20 > >> +static struct counter_comp stm32_count_clock_ext[] =3D { > >> + COUNTER_COMP_SIGNAL_U64("frequency", stm32_count_clk_get_freq, NULL), > >=20 > > It might be worth introducing a new COUNTER_COMP_FREQUENCY() macro now > > that we have a second driver with the 'frequency' extension > > (ti-ecap-capture also has 'frequency'). But it's up to you if you want > > to add a precursor patch to this series, or I'll introduce it separately > > myself in a independent patch. >=20 > Thanks for suggesting. >=20 > I added a precursor patch to this series. > I guess you wishes to see it used in both ti-ecap-capture and > stm32-timer-cnt. I only cared about stm32-timer-cnt in this series. >=20 > Can I let you do ti-ecap-capture change if/when you're going to apply it? Thanks Fabrice, I'll pick up the precursor patch so we an start using it in other drivers. Syed will take on the ti-ecap-capture change, and I've CC'd Vignesh and Julien to this email as well so they are aware of the incoming patch. William Breathitt Gray --el6dlSHLw0+sJrWy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZeDTwAAKCRC1SFbKvhIj K3yKAP9au8psfZPV7oz/mKiqINUHWTZ0uA0altrVA9qTHRrJWQEA6q36cJEVxyKY FxE179tE7UvScdEB6mKG/o/bFy2hVQk= =nCx4 -----END PGP SIGNATURE----- --el6dlSHLw0+sJrWy-- --===============3790811739149103903== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3790811739149103903==--