From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E298C48BF6 for ; Thu, 29 Feb 2024 19:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JFlBkat9d7CaSxPF0OJFGd6GtQfEeod39ODykY2Os/I=; b=j5G7cZpe4NoFsyqQqX3OpxfJXY M4wvmxXRgAYD7yVhjBZmpLnlGW2RQ7TJL30Isr2aZEs/l2HhmYtKNRnHZlGawF66Ah7dmytTpbiMW anyUB0Zh+9EFcTiAr6ADOtlk2kVCtLBWScntAdfbhQ8lyAOv6bxIeEGa11tH3L3vkgbBxAjWMMgLJ ILi9THMvDmalxaSnW/ilqi+29rM5aUHPpUrt3Q8FsBuiHZdcOqeNcEVzPO4lX93F97I58URoCd+RZ tR28HpSzP4ZCWXbuMtjrmW1eMjYcTYaswqFJYor+Z5igPEwWUjYxzpyyM/R47h6jNkX/QpQsn0Ui6 xWDWMWqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rflk7-0000000Eopd-38iU; Thu, 29 Feb 2024 19:06:55 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rflk5-0000000Eop4-2RIy for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 19:06:54 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-412b20dc555so9325665e9.3 for ; Thu, 29 Feb 2024 11:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709233610; x=1709838410; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6C2bXPH86iM1wIE2+OdewUkS7BtP29sQZelrAG7pDTU=; b=RncTkf3fEWAnQHBiQqQLDrJMrcL3/sGycwo5K1L0kvslEaVnA4w4fqnvX7oLjKwH90 VjOCSTLm+Vgj9pdIoWmW5wb20tFDXCpBdC4zSlVKc2njxKunCXYny2Y8rA+59a1uveCy LXLlyzEkYXqf1DMhmAEI0t+8PkzNs0evNhEXrru86kXD6cl1a0G/Bm6nD3IRmVJuph42 aSc2A2+/F4N2lNUaRgO1T4hEr6EJmNvgjF5FCKaGFSdpivGTg8sCBnax77QHaIlTO/ak TpsBEn1OHE4Epg9dOi8foFk+hXKDW6EBvDRzvOPmYqEVLekQS83vfwyR7LuOly4EaSfO hZ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709233610; x=1709838410; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6C2bXPH86iM1wIE2+OdewUkS7BtP29sQZelrAG7pDTU=; b=tiw7LFzgZA729vljvgqmXFO5l7YUyH3pHqogaDk5/ZB3SVWMdTvrbR361K/Rcn2G63 rAz/3c3hgCjZHT0WeRg5Hf3niBazA/W8sFbEs3IqvOjxdBjamG+PiQyLT0vrraqcxgQ5 vmHmUVB87RkfLGT/RCK0xBGV7QGSrdulKDwoTHl981xQrOHJMvVX3Ca65w5k3iRMC37j /8SAa4hUFKbTpJo5wt4/+5QxgCbWYh9E2iMV/SLFMvDGNoRaykZ3rx27SLsH4l7MLIDP siKF0r4DJBgBvFRu+Bt5LhuMIrUepT6AzMNectcg+z5xH5WAr7CIfWb+7jc2GekI8Ipl HEVQ== X-Forwarded-Encrypted: i=1; AJvYcCWJUfXRARbfbxNV596i+efvjQl39wrk3y+07/5msIssH6ZnttNdFt7r0MhthR/A8DWnJhZPvSRIinCUelcHWq5iFPdjN0EIlHL5SyvdUyBkE0q81jo= X-Gm-Message-State: AOJu0Yzz2NQ8RFKnmJjpynmqqzGH0U3472m5sVmRPpNrD6MlXLK1ZKYH AKWfKOgMJox/xtRQjomq8CKM6yTHrSXMKDPH36QfU+NR6gHTIE5NrZ5EUm3rVEWnLe5D6M+n1YT E X-Google-Smtp-Source: AGHT+IEfyXff5Z/Catutq/9H1tJ1Tcp6NVWBS0uS4QEHmqL14qct73+IMdbYhpAanS6tRs2B0CzIBQ== X-Received: by 2002:a5d:58f2:0:b0:33d:29c1:c28c with SMTP id f18-20020a5d58f2000000b0033d29c1c28cmr2219550wrd.66.1709233609591; Thu, 29 Feb 2024 11:06:49 -0800 (PST) Received: from ishi ([185.243.57.250]) by smtp.gmail.com with ESMTPSA id t1-20020a5d5341000000b0033e11acf84asm1996039wrv.15.2024.02.29.11.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 11:06:49 -0800 (PST) Date: Thu, 29 Feb 2024 14:06:43 -0500 From: William Breathitt Gray To: Fabrice Gasnier Cc: lee@kernel.org, alexandre.torgue@foss.st.com, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Syed Nayyar Waris Subject: Re: [PATCH v4 01/11] counter: Introduce the COUNTER_COMP_FREQUENCY() macro Message-ID: References: <20240227173803.53906-1-fabrice.gasnier@foss.st.com> <20240227173803.53906-2-fabrice.gasnier@foss.st.com> MIME-Version: 1.0 In-Reply-To: <20240227173803.53906-2-fabrice.gasnier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_110653_662445_73340682 X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7907922795683090155==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7907922795683090155== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="m8RbYN6cnf/6A/iU" Content-Disposition: inline --m8RbYN6cnf/6A/iU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 27, 2024 at 06:37:53PM +0100, Fabrice Gasnier wrote: > Now that there are two users for the "frequency" extension, introduce a > new COUNTER_COMP_FREQUENCY() macro. >=20 > Suggested-by: William Breathitt Gray > Signed-off-by: Fabrice Gasnier > --- > include/linux/counter.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/include/linux/counter.h b/include/linux/counter.h > index 702e9108bbb4..03472d7407de 100644 > --- a/include/linux/counter.h > +++ b/include/linux/counter.h > @@ -602,6 +602,9 @@ struct counter_array { > #define COUNTER_COMP_FLOOR(_read, _write) \ > COUNTER_COMP_COUNT_U64("floor", _read, _write) > =20 > +#define COUNTER_COMP_FREQUENCY(_read, _write) \ > + COUNTER_COMP_SIGNAL_U64("frequency", _read, _write) > + > #define COUNTER_COMP_POLARITY(_read, _write, _available) \ > { \ > .type =3D COUNTER_COMP_SIGNAL_POLARITY, \ > --=20 > 2.25.1 Sorry, would you make one minor change? The "frequency" extension is read-only so there is no need for a _write parameter (it'll always be NULL). You don't need to rebase and submit the entire patchset again just yet because I will likely have more comments when I review. Just submit the next version of this particular patch separately and I'll pick it up so we can get it merged into counter-next. Thanks, William Breathitt Gray --m8RbYN6cnf/6A/iU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZeDVwwAKCRC1SFbKvhIj K5a/AP9ESChk0LtM25VBIa/YG3unlk+bBAuqQsCttKitBbei5AEAnS35RlwlEo91 tAqqQcOWaRtMdGXsFtre4ov5nr6/HQY= =Az87 -----END PGP SIGNATURE----- --m8RbYN6cnf/6A/iU-- --===============7907922795683090155== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7907922795683090155==--