From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44272C48BF6 for ; Thu, 29 Feb 2024 19:39:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z45boSEAsiBAJfS80fjU6iMkx0DHQARWMUnewcFvEAk=; b=jxMMcjSqOJLDVy N0OJ+5JNk8UAVS5Y1fPQcKhanlnQ7Va4pdsvvn1yQDNQ0U5H5tu66dEw1OEoFZxNzWCe2BWn+FLU4 +bgBpE/iaFSAvHYiwzHmGlrWji4QhyqU4K4qSu8u5RjO34IW2X/3tv1ous+VSchjl+oMm8YfH+04K 0rIaWsVisYSI6I2srinMxaoO/wVPZswKFBDqKZ5EcSRpwRNVWOU9FA08Eq147Rxv5CBlMZwAi8h4D DkyYnPdkm7jypSaGEFzvZNCuHXTmbdM36MXXsboVpCRIdVZi07tNjLJIrs1umaE25ZlYxE7zu3d1K w7FC292DmZLJ3nV8KQvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfmFi-0000000Ev6g-1Drm; Thu, 29 Feb 2024 19:39:34 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfmFf-0000000Ev5R-1duI for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 19:39:32 +0000 Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-7c78573f31aso63280739f.3 for ; Thu, 29 Feb 2024 11:39:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709235570; x=1709840370; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2Gj+BEkBgEqWivQ9srAklb104D0qLcRARdb72wK6r78=; b=ddtqCv9o3fATYxpgiJiS9Avb9AuHnZK/uCpFroFu9yK/KxcU1urWtQHG6IcSFV+F/4 hEk+jH4Zh16PlAHzxYyV7nyBj01/5+NPYnkVrwwooNWHMja1gA4RrTqe25oBuOBwX6ym 0RGCTnnAbLnTzwYn7hZBtsrrPY+slvyCrRdkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709235570; x=1709840370; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2Gj+BEkBgEqWivQ9srAklb104D0qLcRARdb72wK6r78=; b=FEBoGWqcRVdj89tsgxKWl7TS529uFqworM5bmdBG8hHU/MQpTWuBP+8K1tinFV1/oy sJNP40NHZuRl+btE8yKpbYE7Di6Q3o3xLrfTu5rvgG3MjvyXsGIyGi1MOIrHMyYMLn6x i4HxOUCKrYIyrGMcR9tY81K/Kje9OIq2z0puhTZ77WseAFq+dAs0swivi3KdXkJnscBC RwcYUFMxrTjf6seBLOQNBPBd+lgZZbOhT0juX0DbmqMgIaFkF/Dnj2zKvwh//H83Ev/s QVW4wA5biyLju1v/ME5zQB/BurpwMs/pArt4hHG2yGEfT0Xx7mNQSIFpzcojdlEaGKH4 FOuw== X-Forwarded-Encrypted: i=1; AJvYcCWw4cTwgt7PiuPg98N0rpyqQk+K51SeTxRRwPDebyGqmEIHdJXJP7LnziqIVNvkSDhc3KV6SF4EdhoQMoySl7zP5BLdJq4VzEgcQsu7g9r+9SYUX4w= X-Gm-Message-State: AOJu0YwFj4wByPKLptvsZJWg+KJqEaMFEVijha+V6JGaiJNdO1AJy9H3 vCImMztKB7RzrNDXVqBn7SG3xwHqsLuOMn0yWxSrktZX+mzqBLfTzmbnR+7/Dg== X-Google-Smtp-Source: AGHT+IFflBENGybw7AkP83/tQKr6kJsdZWm0Sw/tOPw0d/8ecXfBEQAjJ/Tt6ipaHpc0qkUXGk0Gbw== X-Received: by 2002:a6b:5b08:0:b0:7c7:a1e1:e2ec with SMTP id v8-20020a6b5b08000000b007c7a1e1e2ecmr3715738ioh.17.1709235570008; Thu, 29 Feb 2024 11:39:30 -0800 (PST) Received: from localhost (144.57.222.35.bc.googleusercontent.com. [35.222.57.144]) by smtp.gmail.com with UTF8SMTPSA id dy2-20020a0566381d4200b004747cfba9cesm448794jab.104.2024.02.29.11.39.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 11:39:29 -0800 (PST) Date: Thu, 29 Feb 2024 19:39:29 +0000 From: Matthias Kaehlcke To: Javier Carrasco Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Helen Koike , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Catalin Marinas , Will Deacon , Russell King , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 3/9] usb: misc: onboard_hub: rename to onboard_dev Message-ID: References: <20240229-onboard_xvf3500-v6-0-a0aff2947040@wolfvision.net> <20240229-onboard_xvf3500-v6-3-a0aff2947040@wolfvision.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240229-onboard_xvf3500-v6-3-a0aff2947040@wolfvision.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_113931_487343_6A5CC6A2 X-CRM114-Status: GOOD ( 20.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 29, 2024 at 09:34:46AM +0100, Javier Carrasco wrote: > This patch prepares onboad_hub to support non-hub devices by renaming > the driver files and their content, the headers and their references. > > The comments and descriptions have been slightly modified to keep > coherence and account for the specific cases that only affect onboard > hubs (e.g. peer-hub). > > The "hub" variables in functions where "dev" (and similar names) variables > already exist have been renamed to onboard_dev for clarity, which adds a > few lines in cases where more than 80 characters are used. > > No new functionality has been added. > > Signed-off-by: Javier Carrasco Acked-by: Matthias Kaehlcke This should land together with "usb: misc: onboard_dev: add support for non-hub devices". > diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c > new file mode 100644 > index 000000000000..4ae580445408 > --- /dev/null > +++ b/drivers/usb/misc/onboard_usb_dev.c > > ... > > +static const struct usb_device_id onboard_dev_id_table[] = { > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB33{0,1,2}x/CYUSB230x 3.0 HUB */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB33{0,1,2}x/CYUSB230x 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6570) }, /* CY7C6563x 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G USB 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0620) }, /* Genesys Logic GL3523 USB 3.1 HUB */ > + { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2412) }, /* USB2412 USB 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2517) }, /* USB2517 USB 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2744) }, /* USB5744 USB 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x5744) }, /* USB5744 USB 3.0 HUB */ > + { USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1 HUB */ > + { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 HUB */ > + { USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 HUB */ > + { USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 HUB */ > + { USB_DEVICE(VENDOR_ID_TI, 0x8140) }, /* TI USB8041 3.0 HUB */ > + { USB_DEVICE(VENDOR_ID_TI, 0x8142) }, /* TI USB8041 2.0 HUB */ > + { USB_DEVICE(VENDOR_ID_VIA, 0x0817) }, /* VIA VL817 3.1 HUB */ > + { USB_DEVICE(VENDOR_ID_VIA, 0x2817) }, /* VIA VL817 2.0 HUB */ > + {} > +}; nit: 'hub' isn't an acronym, please s/HUB/hub/ in the next revision. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel