From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93DD4C54798 for ; Thu, 29 Feb 2024 19:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fNnMnO8KnJ0xtM6OFo3Ope9772HzhLEHBSiJ6lykJbY=; b=GnHmSt2T+3ty+v 8CLLeKUaVFlM+5PSpX1bcic0ZLsC6Wb6nx9gzUzR+oDkf5HQjYkdRBqEphOczip/LGnW1SZs4NgfS U21jHz9OQe4V2WU1m5+YxKhV2zC4QF4lpcIfMXI2z7QS1CsmGGALSuIDKx2idn45KP0MYUVl9j0u8 hm03z3S/8aDY8Tnpj3XNeuoN1HmsqqdqUdHTloqyhCwi+l9bnEdugPKByPbiN+Hq4xlWTbLEws9Vl rwFVxBslcfu6iUAJLMVMYzKXzJNKvVugV0cxLQPvUdYDVYc6sy9ngZbRjsgwJQpyWlQjdRZeRdgLK 0t8TJaonyde2wKHo9S4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfmSI-0000000Eyb0-0cfz; Thu, 29 Feb 2024 19:52:34 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfmSF-0000000EyaN-0DPq for linux-arm-kernel@lists.infradead.org; Thu, 29 Feb 2024 19:52:32 +0000 Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-365169e0938so3828715ab.0 for ; Thu, 29 Feb 2024 11:52:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709236349; x=1709841149; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2t6iwGhsnNUxY4xM8qxSPssm7+cm45B8gw+DhHQKME4=; b=D8DJwPFL1nZ4oDV0ZHuOJg9oSy2ZbLw1cVaX17BORrZePl9PnZZMAGkW/moo4kryPp jrNGRvI+qDpXB71upinPY59LozAhd71lgh4c7v8eux/HCx/2s4qro8UDK9a+ePjUgb38 B9qJzEIHj3FbAFLRGRTXOmKTt+mdYeG5txSA8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709236349; x=1709841149; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2t6iwGhsnNUxY4xM8qxSPssm7+cm45B8gw+DhHQKME4=; b=AQDmbIsYOGtZ2BoHhxbPhghigESOux5bEDgptf4d1VppJa0TXeSls/ku0PjZVW+2+S ELOxRwI/ZsQ7w2AkFMwHAwGgSPhEKS7Oinhr2aux/OpwATFTmAro1le7kAteWQA4yygu owM64130CPbc8NK0w2Sel9yyKko3g6ZZe+iQzRbrl8H1lxAdjIYuaa/cP+CzyBIBtewj bib5PFXsOjYwJth1bnRRpKODNZe/4P49C5MS8tQvX4imRk0Wf57zeM8NO/Vj+WDuR4Jt /K1zBSv4e6wzMdUrUPUpUQpubwAdJ+fMz0280NE4FGK7FRQuaoHpHeMXAK9Re4mij0am qD6A== X-Forwarded-Encrypted: i=1; AJvYcCUBE/3UyCK/vVamiphDgkq7SSyIELsIjkAruKA9fyCuIyncqbN1MR9/AI3X+RZ/6vQ1Seq6jQMZr2Zja1GD4p4aMJwlcg2rgPU3XHmgQLylDg3VIfk= X-Gm-Message-State: AOJu0Yx3tYMNztkXO8nxB6d5fU+fVkRtxIWaH3/jiKx9OZ4I+ORnPHud SJolz18e8kJjxPGnS9a8p5id84A+AirWMDGLAmzmGqapNV73+MGVv2Hzmca3WA== X-Google-Smtp-Source: AGHT+IEZumlIxb4G0d4K62o0AbkepaXShc33hqlL9UEbLbxcWjF6LoBXCm4td2IpRYXolb4bY9ObCA== X-Received: by 2002:a05:6e02:1a8e:b0:365:185a:83ed with SMTP id k14-20020a056e021a8e00b00365185a83edmr1768942ilv.10.1709236349457; Thu, 29 Feb 2024 11:52:29 -0800 (PST) Received: from localhost (144.57.222.35.bc.googleusercontent.com. [35.222.57.144]) by smtp.gmail.com with UTF8SMTPSA id 6-20020a056e020ca600b003653eb24e14sm492989ilg.78.2024.02.29.11.52.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 11:52:29 -0800 (PST) Date: Thu, 29 Feb 2024 19:52:28 +0000 From: Matthias Kaehlcke To: Javier Carrasco Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Helen Koike , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Catalin Marinas , Will Deacon , Russell King , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 7/9] usb: misc: onboard_dev: add support for non-hub devices Message-ID: References: <20240229-onboard_xvf3500-v6-0-a0aff2947040@wolfvision.net> <20240229-onboard_xvf3500-v6-7-a0aff2947040@wolfvision.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240229-onboard_xvf3500-v6-7-a0aff2947040@wolfvision.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_115231_134501_5EA48877 X-CRM114-Status: GOOD ( 30.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 29, 2024 at 09:34:50AM +0100, Javier Carrasco wrote: > Most of the functionality this driver provides can be used by non-hub > devices as well. > > To account for the hub-specific code, add a flag to the device data > structure and check its value for hub-specific code. > > The 'always_powered_in_supend' attribute is only available for hub > devices, keeping the driver's default behavior for non-hub devices (keep > on in suspend). > > Signed-off-by: Javier Carrasco > --- > drivers/usb/misc/onboard_usb_dev.c | 25 ++++++++++++++++++++++++- > drivers/usb/misc/onboard_usb_dev.h | 10 ++++++++++ > 2 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/onboard_usb_dev.c b/drivers/usb/misc/onboard_usb_dev.c > index 4ae580445408..f1b174503c44 100644 > --- a/drivers/usb/misc/onboard_usb_dev.c > +++ b/drivers/usb/misc/onboard_usb_dev.c > @@ -261,7 +261,27 @@ static struct attribute *onboard_dev_attrs[] = { > &dev_attr_always_powered_in_suspend.attr, > NULL, > }; > -ATTRIBUTE_GROUPS(onboard_dev); > + > +static umode_t onboard_dev_attrs_are_visible(struct kobject *kobj, > + struct attribute *attr, > + int n) > +{ > + struct device *dev = kobj_to_dev(kobj); > + struct onboard_dev *onboard_dev = dev_get_drvdata(dev); > + > + if (attr == &dev_attr_always_powered_in_suspend.attr && > + !onboard_dev->pdata->is_hub) > + return 0; > + > + return attr->mode; > +} > + > +static const struct attribute_group onboard_dev_group = { > + .is_visible = onboard_dev_attrs_are_visible, > + .attrs = onboard_dev_attrs, > +}; > +__ATTRIBUTE_GROUPS(onboard_dev); > + nit: remove one empty line > > static void onboard_dev_attach_usb_driver(struct work_struct *work) > { > @@ -286,6 +306,9 @@ static int onboard_dev_probe(struct platform_device *pdev) > if (!onboard_dev->pdata) > return -EINVAL; > > + if (!onboard_dev->pdata->is_hub) > + onboard_dev->always_powered_in_suspend = true; > + > onboard_dev->dev = dev; > > err = onboard_dev_get_regulators(onboard_dev); > diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h > index 4da9f3b7f9e9..58cf8c81b2cf 100644 > --- a/drivers/usb/misc/onboard_usb_dev.h > +++ b/drivers/usb/misc/onboard_usb_dev.h > @@ -12,60 +12,70 @@ struct onboard_dev_pdata { > unsigned long reset_us; /* reset pulse width in us */ > unsigned int num_supplies; /* number of supplies */ > const char * const supply_names[MAX_SUPPLIES]; > + bool is_hub; /* true if the device is a HUB */ nit: either drop the comment (the variable name is pretty self explaining), or s/HUB/hub/ ('hub' isn't an acronym). Acked-by: Matthias Kaehlcke _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel