From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 805E3C5478C for ; Fri, 1 Mar 2024 10:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TKh7l5bh6+Pa9YRiY5vcoQjDGWXfM7bOayAMygOp9CA=; b=j5SERyoFQNx45l rc19oApDg4yGuC2u0Lnvd0XHCNAY4rK+lK/w2t3J3qM2B85sch9tStGgCLfdCBRwZx0hrWdFVO9Pi CHkQMCegL69CI4AmaYFJFnfp08kE9ZmvOlL+93LE1U6lUTZltDwwhLAnJrrmsGALA2fGCGB2cWkhq SWnpYV5PUTakuTR/YCMW4kXZt/vxlhjuOA9ZWNp54X6AjMV+KhuVvkNNr7Y/9bR7ggifx/OHXzZv9 EeoOnmtBklBoSff4vp229rmo3zdBL/3IWzSH9x3kG+UrT5au10s3rVrHMkAOGev347q3SGCTghd7r kdvJds9spsD6ccCBJgCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg0Pn-0000000HR99-1oGy; Fri, 01 Mar 2024 10:46:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg0Pl-0000000HR8f-1aub for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2024 10:46:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E05AB1FB; Fri, 1 Mar 2024 02:47:30 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 668A93F762; Fri, 1 Mar 2024 02:46:51 -0800 (PST) Date: Fri, 1 Mar 2024 10:46:41 +0000 From: Cristian Marussi To: Peng Fan Cc: Sudeep Holla , "Peng Fan (OSS)" , "robh@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dt-bindings: firmware: arm,scmi: support system power protocol Message-ID: References: <20240226130243.3820915-1-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_024653_548478_646B9B11 X-CRM114-Status: GOOD ( 30.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 01, 2024 at 10:37:49AM +0000, Cristian Marussi wrote: > On Fri, Mar 01, 2024 at 09:22:24AM +0000, Peng Fan wrote: > > > Subject: Re: [PATCH] dt-bindings: firmware: arm,scmi: support system power > > > protocol > > > > > > On Fri, Mar 01, 2024 at 12:41:29AM +0000, Peng Fan wrote: > > > > > Subject: Re: [PATCH] dt-bindings: firmware: arm,scmi: support system > > > > > power protocol > > > > > > > > > > On Tue, Feb 27, 2024 at 01:01:41AM +0000, Peng Fan wrote: > > > > > > > Subject: Re: [PATCH] dt-bindings: firmware: arm,scmi: support > > > > > > > system power protocol > > > > > > > > > > > > > > On Mon, Feb 26, 2024 at 01:28:31PM +0000, Cristian Marussi wrote: > > > > > > > > On Mon, Feb 26, 2024 at 09:02:43PM +0800, Peng Fan (OSS) wrote: > > > > > > > > > From: Peng Fan > > > > > > > > > > > > > > > > > > Add SCMI System Power Protocol bindings, and the protocol id is > > > 0x12. > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > yes this is something I spotted in the past it was missing and > > > > > > > > I posted a similar patch but I was told that a protocol node > > > > > > > > without any specific additional properties is already being > > > > > > > > described by the general protocol node described above. > > > > > > > > > > > > Without this patch, there is dtbs_check warning. > > > > > > > > > > > > scmi: 'protocol@12' does not match any of the regexes: 'pinctrl-[0-9]+' > > > > > > from schema $id: > > > > > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fd > > > > > > > > > evic%2F&data=05%7C02%7Cpeng.fan%40nxp.com%7C3ef5d152a8e5463e9b > > > 3408 > > > > > > > > > dc39c47e41%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63844 > > > 87632 > > > > > > > > > 86203182%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoi > > > V2luM > > > > > > > > > zIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=kRBV9FPk6 > > > Nrgu > > > > > > Hs2SHpL74VlNUH6cYO1kAsW74CkaTk%3D&reserved=0 > > > > > > > > > > > > > > etree.org%2Fschemas%2Ffirmware%2Farm%2Cscmi.yaml%23&data=05%7C0 > > > > > 2%7Cpen > > > > > > > > > > > > > > g.fan%40nxp.com%7Ccac77deb5f6a4b20460a08dc392ead40%7C686ea1d3b > > > > > c2b4c6fa > > > > > > > > > > > > > > 92cd99c5c301635%7C0%7C0%7C638448119832543335%7CUnknown%7CT > > > > > WFpbGZsb3d8e > > > > > > > > > > > > > > yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > > > > > %7C0% > > > > > > > > > > > > > > 7C%7C%7C&sdata=6MldIOUQ4hxn%2BRffwJJJ3jxXXtHCSxLUOa4JMWB0htU% > > > > > 3D&reserv > > > > > > ed=0 > > > > > > > > > > > > > > > > Why are you adding protocol@12 to the device tree ? Does it have a > > > > > dedicated channel ? If not, you shouldn't need to add it. > > > > > > > > No dedicated channel. > > > > The idea is we have multile Agent, the M7 agent may ask to shutdown > > > > Linux Agent. So the linux agent need use protocol@12 to do the action. > > > > > > > > > > Ok, so indeed you need, AFAICR, the node in the DT even without a dedicated > > > channel nor anynone referring it: no DT node means no protocol initialization. > > > > Yeah, so this binding update is needed, right? > > > > > > > > > For now, we have not finish implementing this in linux side, just add > > > > the node in dts. > > > > > > On the linux side you should not need to do anything but adding the node > > > @12, the existent drivers/firmware/arm_scmi/system_power_control.c > > > driver when loaded will shutdown the system upon receiving the > > > SytemPower notification....what lacks Linux side in these regards ? > > > > " Ignoring unsupported system_state:" we have new defined > > number here. > > > > So I suppose you are using the Vendor defined system states and writing > your own driver to handle these instead of system_power_control ? Or some vendor extensions to the std driver ? IOW what is the plan...custom vendor states was left out from system_power_control waiting for a real usecase...that seems to have shown up eventually :D Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel