From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers
Date: Fri, 1 Mar 2024 10:39:43 -0500 [thread overview]
Message-ID: <ZeH2v9WJsX9sLvXb@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <a1861d70-80e2-4f42-b99a-f2b8c8efe042@linaro.org>
On Fri, Mar 01, 2024 at 07:30:45AM +0100, Krzysztof Kozlowski wrote:
> On 01/03/2024 05:03, Frank Li wrote:
> > On Thu, Feb 29, 2024 at 10:44:42AM +0100, Krzysztof Kozlowski wrote:
> >> On 28/02/2024 20:14, Frank Li wrote:
> >>> fsl,imx8qxp-spdif and fsl,imx8qm-spdif have 2 interrupts. Other platforms
> >>> have 1 interrupt.
> >>>
> >>> Increase max interrupt number to 2 and add restriction for platforms except
> >>> i.MX8QXP and i.MX8QM.
> >>>
> >>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >>> ---
> >>> .../devicetree/bindings/sound/fsl,spdif.yaml | 20 +++++++++++++++++++-
> >>> 1 file changed, 19 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> >>> index 82430f1d5e5a2..785f7997eea82 100644
> >>> --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> >>> +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> >>> @@ -31,7 +31,8 @@ properties:
> >>> maxItems: 1
> >>>
> >>> interrupts:
> >>> - maxItems: 1
> >>> + minItems: 1
> >>> + maxItems: 2
> >>>
> >>> dmas:
> >>> items:
> >>> @@ -100,6 +101,23 @@ required:
> >>>
> >>> additionalProperties: false
> >>>
> >>> +allOf:
> >>> + - if:
> >>> + properties:
> >>> + compatible:
> >>> + enum:
> >>> + - fsl,imx35-spdif
> >>> + - fsl,vf610-spdif
> >>> + - fsl,imx6sx-spdif
> >>> + - fsl,imx8mq-spdif
> >>> + - fsl,imx8mm-spdif
> >>> + - fsl,imx8mn-spdif
> >>> + - fsl,imx8ulp-spdif
> >>> + then:
> >>> + properties:
> >>> + interrupts:
> >>> + maxItems: 1
> >>
> >> else:
> >> minItems: 2
> >
> > I think needn't 'else' here. Top have set to maxItems is 2.
>
> So explain why one item is correct here.
Top interrupt: maxItems: 2. That's means all compatible string (include
imx8qxp, and imx8qm) required interrrupt number less than 2.
other compatible string (except imx8qxp and imx8qm) already listed in
'enum', have additional requirement <= 1, which match original requirement.
simple said:
set[all] <=2
set[fsl,imx35-spdif...] <= 1
So it is the same as
set [all] <= 2
set [fsl,imx35-spdif..] <=1
set [qxp, qm] <= 2
>
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-01 15:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 19:14 [PATCH v3 0/4] arm64: dts: imx8qxp add asrc and sai Frank Li
2024-02-28 19:14 ` [PATCH v3 1/4] ASoC: dt-bindings: fsl,imx-asrc/spdif: Add power-domains requirement Frank Li
2024-02-29 9:44 ` Krzysztof Kozlowski
2024-03-01 4:01 ` Frank Li
2024-03-01 6:30 ` Krzysztof Kozlowski
2024-03-01 15:42 ` Frank Li
2024-03-04 15:05 ` Krzysztof Kozlowski
2024-03-04 15:39 ` Frank Li
2024-02-28 19:14 ` [PATCH v3 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers Frank Li
2024-02-29 9:44 ` Krzysztof Kozlowski
2024-03-01 4:03 ` Frank Li
2024-03-01 6:30 ` Krzysztof Kozlowski
2024-03-01 15:39 ` Frank Li [this message]
2024-03-04 14:56 ` Rob Herring
2024-02-28 19:14 ` [PATCH v3 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names Frank Li
2024-02-29 9:46 ` Krzysztof Kozlowski
2024-03-01 4:06 ` Frank Li
2024-03-04 14:58 ` Rob Herring
2024-02-28 19:14 ` [PATCH v3 4/4] arm64: dts: imx8qxp: add asrc[0,1], esai0, spdif[0,1] and sai[4,5] Frank Li
2024-03-01 4:53 ` [PATCH v3 0/4] arm64: dts: imx8qxp add asrc and sai Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeH2v9WJsX9sLvXb@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox