From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F8EEC5475B for ; Fri, 1 Mar 2024 17:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vy7vTC3k4t30wsTUMVNN0BY/9VcBaLFeaUKBp9bKLbM=; b=dq6oM57ZFcoe+L iL11u7MWQMKqLLPYHJwEXQM5ePotyZlIxhBGWVBJFjQCN3cCB+BWTkz5wjzgBhkJkFu2aQYrpa1BE Z5CrEC7fRX98uDfEQChSeBj6u5Oix557ru6kr6gFNYWtt0NyCc4hNnRlp4B7U4hfeWciLlHev1r0n W6DJ04NW2oBy2fuRs7UPSThUv49WT3jnbgxeu6cGSyjqHqynW+fiiy+nGFvMd4+awqptVK6IV58rh F9pNS6iHOzUtgczalKNBHqzKblZFqpyi01/yzLylkr9qdhmfdwxxmJb58nMcI9bXl/jQHDAoobVTd JV0svIRlCCLBpD4Ms1RQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg6O0-00000001HQk-16x5; Fri, 01 Mar 2024 17:09:28 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rg6Nr-00000001HMq-1OIo for linux-arm-kernel@lists.infradead.org; Fri, 01 Mar 2024 17:09:27 +0000 Received: by mail-io1-xd2a.google.com with SMTP id ca18e2360f4ac-7c7ee7fa1d8so103061839f.1 for ; Fri, 01 Mar 2024 09:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1709312958; x=1709917758; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=TgGayE0Ss0x7kMyOECw4c7ZlvB5+ggeY6MfRBHZyRj0=; b=LM+nm9fRULEDctQvmCXA+OrFQO/WqbTSeR1oA8jtYGK7PxFRwHtgG8K1SVuVuvv0B8 xJmoYK6VOTW+BvN3mJHedtTlRDm+5MUh7ztMU+ARDi+SAmk5xGdPkIMr6BMzVnppEuuS FmoU96fRi5st/GCgT0JP6V5YxoD3IP/MN0bGJ4w+JWEFNtTyCd5S2xkHXgeeFw9jCiz2 JpzDnODcYbKVKblbkdVO9t16Mf7Y+Jbo1ZiXJt85OIngkRao+ayOfvntHZHSlVuU4gPg /2+mx125SjDHDLzvxSqppLJPozljn8j9QS6dXnxfLOARkEZeu8UC1UtjVexAeNVWSd8z jGHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709312958; x=1709917758; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TgGayE0Ss0x7kMyOECw4c7ZlvB5+ggeY6MfRBHZyRj0=; b=XEvOq9b29Ah6pKWwATLebSMiUmmyDxDafho7Gvnm/AQtf7FSot9PEnacc0YEiyUgHa WqQ4cRA/A3kNklwQ2ALkewZ9yRT3yn8WGOtjPOLvHuaawQc1t/eV7CjRT0JvINhSk0ck lW3aiPhXChrrwHEBuem1P86OO9ST1N/I0tVTowpM0aTOTqMU8t1Jt00cLusQiY1CT9Te n0MShBtpSjtrt80DYR36qfFI0qbAHyi5QnxoF9ogyVPsmf9wCF2dMzUsFIjFpzydNpTD Ti1fBX1p6/f5pOSbqQZQYBpgiqDfzMrn+XhcGJzROxWI/RmdaGfni7ATBXWUe378hA+2 eJAA== X-Forwarded-Encrypted: i=1; AJvYcCVZZTBYXNyPBbOb6CR4W69Ua5e+nEoHamDkKEnX1nmiP9ZZ2yCURcFbS6gMfFpciWRL3O3sQnFh/1TlC1vAF1J2v8Dkptx35xap9IRw1csRsU2PTkA= X-Gm-Message-State: AOJu0YzQEaeoxNgkVmUI02G04Tn3Wf0tMo7NxPiqDUy+qJyJhrGoU8a4 k/bIVmFNITyHK5WdA6tCtaxneGU4W4cXr5Ab+YIcrdIDrB7wPbjp5l33ckdOAo0= X-Google-Smtp-Source: AGHT+IGbtTfgZxtEKonCNw+wmoLQTEBJgPOICKhUbu832VL/S6jYkO75nxPvM+5zad2mc8wT7+h4jw== X-Received: by 2002:a5d:9c16:0:b0:7c7:97c2:f04f with SMTP id 22-20020a5d9c16000000b007c797c2f04fmr2306910ioe.8.1709312958140; Fri, 01 Mar 2024 09:09:18 -0800 (PST) Received: from ghost ([2601:647:5700:6860:2a1e:5647:311:1139]) by smtp.gmail.com with ESMTPSA id 132-20020a63008a000000b005dc9439c56bsm3121416pga.13.2024.03.01.09.09.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:09:17 -0800 (PST) Date: Fri, 1 Mar 2024 09:09:15 -0800 From: Charlie Jenkins To: Christophe Leroy Cc: Guenter Roeck , David Laight , Palmer Dabbelt , Andrew Morton , Helge Deller , "James E.J. Bottomley" , Parisc List , Arnd Bergmann , Geert Uytterhoeven , Russell King , "linux-kernel@vger.kernel.org" , Palmer Dabbelt , Linux ARM , "netdev@vger.kernel.org" Subject: Re: [PATCH v11] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests Message-ID: References: <20240229-fix_sparse_errors_checksum_tests-v11-1-f608d9ec7574@rivosinc.com> <41a5d1e8-6f30-4907-ba63-8a7526e71e04@csgroup.eu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <41a5d1e8-6f30-4907-ba63-8a7526e71e04@csgroup.eu> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_090919_425923_DC8A0E9E X-CRM114-Status: GOOD ( 26.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 01, 2024 at 07:17:38AM +0000, Christophe Leroy wrote: > +CC netdev ARM Russell > = > Le 29/02/2024 =E0 23:46, Charlie Jenkins a =E9crit=A0: > > The test cases for ip_fast_csum and csum_ipv6_magic were not properly > > aligning the IP header, which were causing failures on architectures > > that do not support misaligned accesses like some ARM platforms. To > > solve this, align the data along (14 + NET_IP_ALIGN) bytes which is the > > standard alignment of an IP header and must be supported by the > > architecture. > = > In your description, please provide more details on platforms that have = > a problem, what the problem is exactly (Failed calculation, slowliness, = > kernel Oops, panic, ....) on each platform. > = > And please copy maintainers and lists of platforms your are specifically = > addressing with this change. And as this is network related, netdev list = > should have been copied as well. > = > I still think that your patch is not the good approach, it looks like = > you are ignoring all the discussion. Below is a quote of what Geert said = > and I fully agree with that: > = > IMHO the tests should validate the expected functionality. If a test > fails, either functionality is missing or behaves wrong, or the test > is wrong. > = > What is the point of writing tests for a core functionality like network > checksumming that do not match the expected functionality? > = > = > So we all agree that there is something to fix, because today's test = > does odd-address accesses which is unexpected for those functions, but = > 2-byte alignments should be supported hence tested by the test. Limiting = > the test to a 16-bytes alignment deeply reduces the usefullness of the te= st. > = Maybe I am lost in the conversations. This isn't limited to 16-bytes alignment? It aligns along 14 + NET_IP_ALIGN. That is 16 on some platforms and 14 on platforms where unaligned accesses are desired. These functions are expected to be called with this offset. Testing with any other alignment is not the expected behavior. These tests are testing the expected functionality. - Charlie > Christophe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel