From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46D10C5475B for ; Sat, 2 Mar 2024 01:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0N1du1I0YZe7RXOtRacbJZPIgT1r0Vwgq3n14WOt8KA=; b=Ifr/BH588TatES o0IZVHTg/MtR8e5Pz9WpB2JW+pZyl4Dbv0J9ZkWrGSkUUaQLEs7SNRVifA9l9N1ZKtXnsy/3X+JMM QTbh6n8cS1FF1lW3uREqghOJyGvkpGNyN+kXJRMFEOgu7aF7V0IVghzuVrsJHmLQq4K1X2ugy4gP2 ZRnIehWJoBGhUukgDzbDtkxwmV5ANqF9KnoNTXR/ReKvBCx/9HHWolTDcoto9oussXz0o/FrVvfyr 5k8jdgp4Ck1jCgAqlF/rUgXEr6oHO8QV3amPf5hOEHqbPvcr/WJ9dQpuXv1dxx3H24xjTk4RhyJS4 JL8qUp7W943GeQYsbyaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgEcR-00000002Xg0-42L9; Sat, 02 Mar 2024 01:56:55 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgEcP-00000002Xdz-0cfa for linux-arm-kernel@lists.infradead.org; Sat, 02 Mar 2024 01:56:54 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-29b21dc7a92so1092351a91.1 for ; Fri, 01 Mar 2024 17:56:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709344602; x=1709949402; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rAjZ+kaDMbKRwjpcrRG3XyrYoFrf4nbBV7+HyQvCf8U=; b=VnmV1GmOCDQZexqU7PSuYd/jgkSQIhAdhq9wmZxqUAQdl8wCzHlnjIA+QNxQr9+2q9 fNy59/anbAf9t8XX+EuqkYxjve+sp153pO6wpzCVi9t7ZJc78OVPxPlLvif1Uoqvi/c6 n6LFAu76fQApIyCVilRxvke7A9V//AdgRb2Ei76tMP8fMzPoJt6w17HeV4NC5lhIcwJS +Uh00cnxrzzZnNpMrSsMapIoePjOrFBltJMz3Ymz/LEmwcp1Y2OhI338zg1VjlVYjCZB VtZ/1LFeG25mA7rELlV+8cwl9AQgWG9vODN2G/cEyrlN7AeRQopfzJnhLie469c3obBr 1zeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709344602; x=1709949402; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rAjZ+kaDMbKRwjpcrRG3XyrYoFrf4nbBV7+HyQvCf8U=; b=LCdN7DaimYAoHQiug6qdwkq384uHqCbkBo6CTjjW0WyFTgN/3EM5HwmduxIz5EzUGp uUjYkqbE4VNmZIW70lSCbGJtnT+L5987WUvzCHRrXDbER/clCFV1Q9l9kul4GF2XZz0b KX3A8T5GannfPbisT6kKbQKbR0Xr16213k6jmun5FWewwgHJchorApc54hcuHPhL0iGT 1TSU087X34TOFw0Sw6pL/4E3JvoHqMYWRiFuf+xylDtN9HEoVzv6vOucwUqlRJvAwaLM rC1wdC8DgB2eBIeoINvm0DD4B+Gg+tC/MBVNrrBc2RyBeC/C648FkgAlddNLvmNRPhKO lH4A== X-Forwarded-Encrypted: i=1; AJvYcCUPEJ+P40jzVOF06uLT4bIwKbPY5ysIsOZtfmAz1LjJukYLDDi0945lRh8xRhKoAIAkThKpBzzEI7Ss6fOk3NLF505OY3+8T7fbAEVQfGBhugVQHwU= X-Gm-Message-State: AOJu0Yx8KiUKIo04qHfNKchWepP8lbJIQzlKIV6WE164EZqBTcf7Xwvd ck41rlWtBNVWb4QSECXosiM42LzQM2q2IvoMyqvogSFFAoAgoyOL X-Google-Smtp-Source: AGHT+IEZSaIuuq8xXQW17mRFdhgFLz6wv/6CBeltle2Te873kdRS3ixofr6VQxRP0FiVjG7TEMzIHw== X-Received: by 2002:a17:90a:fb81:b0:29a:1708:9878 with SMTP id cp1-20020a17090afb8100b0029a17089878mr3559394pjb.38.1709344602521; Fri, 01 Mar 2024 17:56:42 -0800 (PST) Received: from linux-8mug (111-248-209-112.dynamic-ip.hinet.net. [111.248.209.112]) by smtp.gmail.com with ESMTPSA id g24-20020a170902869800b001dbae7b85b1sm4118565plo.237.2024.03.01.17.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 17:56:42 -0800 (PST) Date: Sat, 2 Mar 2024 09:56:24 +0800 From: Chester Lin To: Ghennadi Procopciuc Cc: Andreas Farber , Matthias Brugger , Shawn Guo , Sascha Hauer , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , NXP S32 Linux Team , Pengutronix Kernel Team , NXP Linux Team , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Ghennadi Procopciuc , Ciprian Costea Subject: Re: [PATCH v2 2/2] arm64: dts: s32g: add uSDHC node Message-ID: References: <20240122140602.1006813-1-ghennadi.procopciuc@oss.nxp.com> <20240122140602.1006813-3-ghennadi.procopciuc@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_175653_220395_776121F3 X-CRM114-Status: GOOD ( 28.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 26, 2024 at 08:29:31AM +0200, Ghennadi Procopciuc wrote: > On 2/24/24 12:44, Chester Lin wrote: > > Hi Ghennadi, > > > > On Sat, Feb 24, 2024 at 04:22:30PM +0800, Chester Lin wrote: > >> Hi Ghennadi, > > Hi Chester, > >> > >> On Mon, Jan 22, 2024 at 04:06:01PM +0200, Ghennadi Procopciuc wrote: > >>> From: Ghennadi Procopciuc > >>> > >>> Add the uSDHC node for the boards that are based on S32G SoCs. > >>> > >>> Signed-off-by: Ciprian Costea > >>> Signed-off-by: Ghennadi Procopciuc > >>> --- > >>> arch/arm64/boot/dts/freescale/s32g2.dtsi | 10 ++++++++++ > >>> arch/arm64/boot/dts/freescale/s32g274a-evb.dts | 6 +++++- > >>> arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts | 6 +++++- > >>> 3 files changed, 20 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi > >>> index ef1a1d61f2ba..fc19ae2e8d3b 100644 > >>> --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi > >>> +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi > >>> @@ -138,6 +138,16 @@ uart2: serial@402bc000 { > >>> status = "disabled"; > >>> }; > >>> > >>> + usdhc0: mmc@402f0000 { > >>> + compatible = "nxp,s32g2-usdhc"; > >>> + reg = <0x402f0000 0x1000>; > >>> + interrupts = ; > >>> + clocks = <&clks 32>, <&clks 31>, <&clks 33>; > >> > >> Same as I have mentioned in [PATCH v2 1/2], could we have fixed dt-bindings to > >> replace with these raw clock id values (32, 31, 33)? > >> > > > > Just found the previous review discussion in v1: > > https://lore.kernel.org/all/f54d947c-58dc-498f-8871-b472f97be4a8@oss.nxp.com/ > > > Indeed, I switched to raw clocks instead of placing them into a binding > header after receiving this feedback on v1. > > > What I'm worried is that, could these raw clock IDs be rearranged in the > > downstream TF-A? If so it would cause ABI inconsistency and clock issues > > since the kernel is not aware of any raw ID changes in downstream TF-A. > > These clock IDs will become immutable in the downstream version of TF-A > once the patches get merged. This will prevent any unfortunate events > when the Kernel and TF-A are not in sync with regard to SCMI clock IDs. > > Best regards, > Ghennadi Thanks for explanation. Reviewed-by: Chester Lin > > > > Chester > > > >>> + clock-names = "ipg", "ahb", "per"; > >>> + bus-width = <8>; > >>> + status = "disabled"; > >>> + }; > >>> + > >>> gic: interrupt-controller@50800000 { > >>> compatible = "arm,gic-v3"; > >>> reg = <0x50800000 0x10000>, > >>> diff --git a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts > >>> index 9118d8d2ee01..00070c949e2a 100644 > >>> --- a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts > >>> +++ b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts > >>> @@ -1,7 +1,7 @@ > >>> // SPDX-License-Identifier: GPL-2.0-or-later OR MIT > >>> /* > >>> * Copyright (c) 2021 SUSE LLC > >>> - * Copyright (c) 2019-2021 NXP > >>> + * Copyright 2019-2021, 2024 NXP > >>> */ > >>> > >>> /dts-v1/; > >>> @@ -32,3 +32,7 @@ memory@80000000 { > >>> &uart0 { > >>> status = "okay"; > >>> }; > >>> + > >>> +&usdhc0 { > >>> + status = "okay"; > >>> +}; > >>> diff --git a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts > >>> index e05ee854cdf5..b3fc12899cae 100644 > >>> --- a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts > >>> +++ b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts > >>> @@ -1,7 +1,7 @@ > >>> // SPDX-License-Identifier: GPL-2.0-or-later OR MIT > >>> /* > >>> * Copyright (c) 2021 SUSE LLC > >>> - * Copyright (c) 2019-2021 NXP > >>> + * Copyright 2019-2021, 2024 NXP > >>> */ > >>> > >>> /dts-v1/; > >>> @@ -38,3 +38,7 @@ &uart0 { > >>> &uart1 { > >>> status = "okay"; > >>> }; > >>> + > >>> +&usdhc0 { > >>> + status = "okay"; > >>> +}; > >>> -- > >>> 2.43.0 > >>> > > -- > Regards, > Ghennadi > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel