From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E7C5C48BF6 for ; Mon, 4 Mar 2024 09:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Uut3VVRiYSn4SI6ek2d62wTewk8uVnoKemqcHrx3zfg=; b=rlye1AEsU0RFsrZMzLmhuuuAU5 iJf6P2qlmF76sEWwqX+cl+8Vqf5Xqw58dQsGFFnN1YZaZV5u06v7sADb7w/16HnOofAr8ifePJAX+ voT3Aqi5VAf28OWlEnP6v645ZPIh7rZu4m1QSO6XMpXzJWSanMtJETWxtczxKXjnSEnAfWY0FOHOm vDHmIAhMAkJp27wdC/xjb82C+Xmm6y0ZiSyfJUQlXjFc75kN3iyr7LEXFrx1ZxZ+Cd498+zCWRn8H cNJNdIFtZJqaEGfcLlPwkBvv5LGJmMiqUZ5PhaOIhu11UsVqDjZ5WnfQBz5DxcsXDDe1fMPB8jl9m 1CpEPrtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh4c3-00000008OLk-3Y8s; Mon, 04 Mar 2024 09:27:59 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh4bz-00000008OJx-2VXR for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 09:27:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A360D60DDC; Mon, 4 Mar 2024 09:27:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBC5BC433C7; Mon, 4 Mar 2024 09:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709544474; bh=jMsyGLHvO8uB8zv0yGRDRKH0t8IOUmfWepSdtjUOZTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S+xvoZF2GTy/RNd7tMYk20WS/5PzimRZfztQAxovLMVTXz69+dyZ3qiz7K0DNMsiv 6loEi8eC5AEsdku3Q/yBt7VJObLtzwbE+H6j62sODfdpE14MVYoyHsitx+xavdlxUy PruOIlewnMt95GVoqhhkGEsuqfiwu87CfLAX4HCLoxi1Ivfl0p+W6cskTwun1xDCQj qZTPn4K2ZZ489A54xop/I1dsnBIReBy3WHECGJ9z+zeURekb/l8eQaf2QeHtFsFRq2 1/+JhT9HPehKi3+Jm2w3yg7HKXwxHJAKw1F5rw0R+fSPvNkb9JTY4kcd7CVPNUMVj+ lNHjw5HJhXmjg== Date: Mon, 4 Mar 2024 10:27:51 +0100 From: Wolfram Sang To: =?utf-8?B?VGjDqW8=?= Lebrun Cc: Linus Walleij , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Subject: Re: [PATCH v2 09/11] i2c: nomadik: support Mobileye EyeQ5 I2C controller Message-ID: Mail-Followup-To: Wolfram Sang , =?utf-8?B?VGjDqW8=?= Lebrun , Linus Walleij , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk References: <20240229-mbly-i2c-v2-0-b32ed18c098c@bootlin.com> <20240229-mbly-i2c-v2-9-b32ed18c098c@bootlin.com> MIME-Version: 1.0 In-Reply-To: <20240229-mbly-i2c-v2-9-b32ed18c098c@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_012755_863085_2B300375 X-CRM114-Status: UNSURE ( 8.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6758562127145109238==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6758562127145109238== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k8nmJLf0eP41vvSM" Content-Disposition: inline --k8nmJLf0eP41vvSM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + if (of_device_is_compatible(np, "mobileye,eyeq5-i2c")) { > + ret = nmk_i2c_eyeq5_probe(priv); > + if (ret) { > + dev_info(dev, "%s: %d: %d\n", __func__, __LINE__, ret); This is debug code, or? Please remove it. Especially since nmk_i2c_eyeq5_probe() prints something out on error. --k8nmJLf0eP41vvSM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXllBcACgkQFA3kzBSg KbYjBg/9FCc3QH08DNHSDclrHAf1fg5Z5zrN+QWrseFFm2Snxk2BMxDn5RV7YGpa 5ElyrLnZX1DpRQtokMYrejy1yTOJlwVUUZIIbdB958ASVTLp47vkRw6Diz5s0Jh1 Jy8Lry+P72uLeSdagK31sLOw4Hoys31DkkGZhzRotEO6G3VvgjQ5mXU64Cyz5xfy 1LV0uiL5iJ3d1a3rV9cFmjDroHjeVQ6UA+cahAr10S3BHsaxgt6q5ZyCbsSQWr8C YETLFQfCU6MjgDikEPch4GcpX6g2uNUR4nicVtvclxdT4C7b2dK8iWNTYRqncbcH QgcfhX6sYT5J23tMqnuKKfCHD0Fmo2nlyFNlHUUkLnZrMgCXU7APz8JUsN70Eahn tN0St7ccWN79BntxXyUeAooDOopPAhklSvN/rc0epG0/PGUlx4QZrZK+SGPWtTdP JX9tRIDavd4Swd7DRiL9hCmFQE2P6DhPlvO10TPoz7KI9LvZCZ0Fd2WJAsajo5mD MdgK0n4jC1XdqSC3WFTm7+MiAJUZJTsdkq7OFlGfWGgy0T0AQwq0FYX0sjREswQB 05xfcgLhn9XjUzAQIRErvh459o4IrxwfB3zgJtnL5RN64YN0P89+FBm5kkxfcATC 72f3ECGuiYFDiCbEWCuIT5OX5hiY37WcWVfynwSOgcAeBfRRT/c= =SBTB -----END PGP SIGNATURE----- --k8nmJLf0eP41vvSM-- --===============6758562127145109238== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6758562127145109238==--