From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84793C48BF6 for ; Mon, 4 Mar 2024 11:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=00/Q0jv0DAKzZCsacsedSAUocsBCgnrUHghnMrlb6u8=; b=vTH26K8v35PrjVX/wpmI80FxLq 3qgD4CqPXx4tIUlrvAXXlBCe8oa651GH1weyG4PAXW5fPJonleKh5jjhXkhKU/wB667uqAzBm+RaA OP6zRPJN8Hi3chHeUi9HjxBxb1PN2wjOGRem1YsJyacO9E3UuR3pdFKDjqbli1lARewIUu0PdMRJr Q/Fl/xs8WYSvbyDLOL2k28aOrAmLevRkm8ieY9JBeEpMyWfjKE2heeU0edkz36TYORIRAbJlBoHyB KOjhsEJjLpsoUYUlwhbkusVPAyr+jyf+MAPs8nLcShNi9l6s+qzS/kc25G1DJ9C9InJNg3H5f4f+r vMnZFavA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh6dv-00000008r6g-2Ap1; Mon, 04 Mar 2024 11:38:03 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh6dp-00000008r5o-38vf for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 11:38:02 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 142B660E86; Mon, 4 Mar 2024 11:37:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F8EEC433C7; Mon, 4 Mar 2024 11:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709552276; bh=5TZPumrHu7nOZMaUyKuATS4UdYvQenVHwGCAR2gaiC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hskPch44nM09zbxpIg687TMJ6Q/lTPRAkyILKLkBCstGwd5agQW0C3sRjmLOZbVE7 1VT/lRMMmCrTBr9HWlZSVnoLvQmu4HbAG/JVGProBIIl12Rgr0f7j24yUe3thGsAyB ymelxx9kV9eT5NK0l/cohW1K1E/JGmuRDHQG5r/1oMinaRc2zIRJF9HR+CVJbNdpf0 XDs/zl8NABdL08nR+z7EIp+6K9m3Gq3ZvoMbBpOzrrgWJY2TFnuFp5D/oZBZNVh+iC zQ3mXvCCG26HrpJb76DV+sJfhckEfPlx8dtp3sH3pXHwtOAbqaZYK5cr2sGFWJeOvg bFKk3S1gZMfvg== Date: Mon, 4 Mar 2024 12:37:53 +0100 From: Wolfram Sang To: =?utf-8?B?VGjDqW8=?= Lebrun Cc: Linus Walleij , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk Subject: Re: [PATCH v2 06/11] i2c: nomadik: support short xfer timeouts using waitqueue & hrtimer Message-ID: Mail-Followup-To: Wolfram Sang , =?utf-8?B?VGjDqW8=?= Lebrun , Linus Walleij , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Gregory Clement , Vladimir Kondratiev , Thomas Petazzoni , Tawfik Bayouk References: <20240229-mbly-i2c-v2-0-b32ed18c098c@bootlin.com> <20240229-mbly-i2c-v2-6-b32ed18c098c@bootlin.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_033757_913184_E5327AC2 X-CRM114-Status: GOOD ( 10.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3619119953822591911==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3619119953822591911== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5oCfEIbf9yhEOXcl" Content-Disposition: inline --5oCfEIbf9yhEOXcl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > > - int timeout; > > > + int timeout_usecs; > > > > I think 'unsigned' makes a lot of sense here. Maybe u32 even? >=20 > Yes unsigned would make sense. unsigned int or u32, I wouldn't know > which to pick. It gets (later) fed by of_property_read_u32(), so I tend to suggest u32. Sounds like least conversions then but please double check. --5oCfEIbf9yhEOXcl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXlso0ACgkQFA3kzBSg Kba7aRAAp8MwXqIV0LPiw5/f0gf9Ya9eqn734mD8kNjabJrB7OQ/XDq0cBrG0bZr QTGhzV0kmEPcA7Eg3ezMaIuFiooPqnhWkIJNMXQA062XXMjrNrjjk44zZz+zHcIY JAUW/1fNcPgeTN5DbFtfRr/4wxPd78niGclcbFtIltQewyib9ecyXS6SMhFldi9S OlEm2p6ahwF8Cq4DKD3GgtjrEjDr1QGPh4ct5rsJ75dLvNlLvTDPxUiIA09RqQMh jOhfUL9OpNdcNRsz7pSBSmgM4f03Eb+jocKB3Q54G3wQHBBAMeSPwDWj/fGYpf+L 83eJkRl/6Zlp1XupCq5gK64qiJOeOhnMSNuvY2cKypET9wacdUKvXvJw6/Dd04xA +MgwTTpilIJUZZKMT1r3mjTGUbcod+9odmVXOO0KvgJBxErGBPzNunSZcePC/sy1 CYnCdC65q8P/XAgJnftDHFGFWRR+0zbUU5aJTPLfJMD2j4B/95EjR5aSJmErlaY5 bI5m0FZLKif/w9hTVKLqaPdHWMzDZUUW3cadqRr1sINDQuVh4decxrVss/9bZXh3 NXc10UNRPI+SYA7vMYuWFXtvMS6D49HcIH7iJSyEdFXqB8Wl+3ScGCx3UXrYUyFZ doh/MmTSP6huxKuyQyspeuVJsCoAZJRWqEr4+tg5YmnmIIH7kK8= =aOD+ -----END PGP SIGNATURE----- --5oCfEIbf9yhEOXcl-- --===============3619119953822591911== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3619119953822591911==--