From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0C3BC48BF6 for ; Mon, 4 Mar 2024 14:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=50UhIxgi0Q0hw9Rug08IDQ04vE5AQx6EARK1yzB2FUs=; b=3eJ8eX6+SvgH5J 62w3IGD7tyVjeUhUEmsm1XoPhYiTU8YEvzZlINyQGZSITlsgW4nZaod35RCgRN1p0kl7P+YI6o46r LKGT5HRHf/DZjoG0KYMbVWGCNvXIjJiacE1bGIZDn3qtSpYfX80x59hThdi/lZJnB5rDK6YVTsEat w+Ox6LbSjkFevoNAHh7LDcBBN1wpdPeqs0JjeqTdBK70Mxk3+EZe5/m+q8aorftlh3lqEI3M7Ch40 rwVsJvtN8YIdIGiS6+jRLgZMKYD9DJLWQrLPAzS46C4SnS9Y6kfgzUqqcN//o9REzi07+SbEmIfar 7gKrgFdOiW6yHZ+WfqgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh9NW-00000009ODT-3vkA; Mon, 04 Mar 2024 14:33:18 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh9NU-00000009OCG-0YCL for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 14:33:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wRopBagK4PzSmOlB5j0pJxRv6DYM1p2O2ZjwhN9VoqE=; b=wB+R7DNUYNqQRGU933WTZiLRjk yHZFIW9bXImt1vd8AhUGj/2sOmmZGxKIvLywerjKxjZmSCLvIRUSfknMPXKhv/Es6VrN0t9hY7lnl jAcLnJBDBg/OiRq3hxOlNH43/BFx19j4jgFyrTp5G8/NyBIfIE9RibPgyInobGdy0d9pNSIwDX37d vNVnaHo9TKdRBr3sxEQBUHvE4yMfgWcFu1CSwNH2McU5T+9PWRhXRcSwVTie8yKB+MRjntauLVKVI Gtf7zATZjsfqp3tVnQ1ibrNlz1r2So2yZ9ypfGklkZS1zcUV8dgFog2U7XMKjTt9Vb547OeKHyrDR +NGM65Uw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42658) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rh9NJ-0005lg-0B; Mon, 04 Mar 2024 14:33:05 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rh9NG-0004Yn-KR; Mon, 04 Mar 2024 14:33:02 +0000 Date: Mon, 4 Mar 2024 14:33:02 +0000 From: "Russell King (Oracle)" To: Romain Gantois Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Maxime Chevallier , Miquel Raynal , Thomas Petazzoni , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH net-next v5 2/7] net: phylink: add rxc_always_on flag to phylink_pcs Message-ID: References: <20240301-rxc_bugfix-v5-0-8dac30230050@bootlin.com> <20240301-rxc_bugfix-v5-2-8dac30230050@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240301-rxc_bugfix-v5-2-8dac30230050@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_063316_233670_32D68116 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 01, 2024 at 04:34:59PM +0100, Romain Gantois wrote: > Some MAC drivers (e.g. stmmac) require a continuous receive clock signal to > be generated by a PCS that is handled by a standalone PCS driver. > > Such a PCS driver does not have access to a PHY device, thus cannot check > the PHY_F_RXC_ALWAYS_ON flag. They cannot check max_requires_rxc in the > phylink config either, since it is a private member. Therefore, a new flag > is needed to signal to the PCS that it should keep the RX clock signal up > at all times. > > Suggested-by: Russell King Given that this contains some of my code, this is slightly more than "suggested by", it's probably more accurately co-developed-by. All the same comments apply to this attributation as the sign-off in patch 1. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel