From: Cristian Marussi <cristian.marussi@arm.com>
To: Shivnandan Kumar <quic_kshivnan@quicinc.com>
Cc: xinglong.yang@cixtech.com, linux-arm-kernel@lists.infradead.org,
sudeep.holla@arm.com
Subject: Re: [BUG REPORT] firmware: arm_scmi: Shared Memory Overwritten in SCMI Mailbox Communication
Date: Fri, 8 Mar 2024 08:33:17 +0000 [thread overview]
Message-ID: <ZerNTSeSfgLXiPb7@pluto> (raw)
In-Reply-To: <c17b246c-182b-432c-a6eb-e3f276c21a60@quicinc.com>
On Fri, Mar 08, 2024 at 11:46:07AM +0530, Shivnandan Kumar wrote:
> On 12/13/2023 11:32 AM, Xinglong Yang wrote:
> > The shared memory is overwritten happened in some condition and the detail are
> > as follows:
> > Based on mailbox transportation. The thread A is waiting for response and The
> > thread B is waiting the mark_txdone() to submit the next message. When the thread
> > A is timed out because that the callee do not reply promptly and then caller begins
> > to tx_tick() for the next message(for thread B). At the same time, the shared memory
> > is written by the callee(response for thread A) and set channel free. After the callee
> > has written the shared memory. The caller written the shared memory again for
> > thread B. In such case the shared memory written by callee is overwritten by caller.
> > Later, the caller received the completion IRQ for Thread A(BUT has been overwritten
> > by Thread B's tx->buffer). The caller checks the shared memory discover that the buffer
> > is error. Which case triggers a chain of errors.
> >
> > The part of error logs are as follows:
> > [ 19.135368] arm-scmi firmware:scmi: timed out in resp(caller: xxx)
> > [ 19.508536] arm-scmi firmware:scmi: Invalid message type:0 for 301 - HDR:0x%X state:1
> >
> > Because the same token ID are received twice by caller, the second IRQ with the same token
> > will be treated as invalid message and abandoned.
> >
> > Regards,
> > Xinglong
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
> hi Xinglong,
>
Hi Shivnandan,
> I encountered the same issue recently.
> Is any fix identified/merged for this in a separate thread?
This fix has beem merged back to 5.15 stable.
https://lore.kernel.org/linux-arm-kernel/20231220172112.763539-1-cristian.marussi@arm.com/
Thanks,
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-08 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 6:02 [BUG REPORT] firmware: arm_scmi: Shared Memory Overwritten in SCMI Mailbox Communication Xinglong Yang
2024-03-08 6:16 ` Shivnandan Kumar
2024-03-08 8:33 ` Cristian Marussi [this message]
2024-03-08 9:53 ` Sudeep Holla
2024-03-09 13:05 ` Shivnandan Kumar
2024-03-08 9:50 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZerNTSeSfgLXiPb7@pluto \
--to=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=quic_kshivnan@quicinc.com \
--cc=sudeep.holla@arm.com \
--cc=xinglong.yang@cixtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).