From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 373C5C54E5C for ; Fri, 8 Mar 2024 09:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GoL/qwPCaaMw5mSoQTCP/7fDN9OpC5GnrJcxo63HZAE=; b=XCXOFzAC8zkvmE GdytE0FenmRBphdNPro6CQzpXI2J2YT7oVDRzCXP/eQEwwvk1qFrnEEz/A8NImJk80BLWjAeTrjPR NN/DvHP9pnu9sjIA12J/bAzvL/gcvBrCa0X3TIGMAYTlc4gCFMhoFpXK74RAx2NfpY/jEMCmPn8mk nn3ngT/ZvsHp0cpb/CaRPJc37GXKwkBHxAXizlnvNSFMxpszzQTo1kYix6HOHbM/Htdnjmp9PIkmz sKv5+90UEy/4v94XWUWzvfW+nndbcGAFKU4K7tl7hwzYAWrtV8D0lS0+2jSr/3OOnNmmZAIJuWt9l LXNnKNSKD1XnaCyyTivQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riWEP-00000008VcA-1NZv; Fri, 08 Mar 2024 09:09:33 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riWEM-00000008Vba-1RPg for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2024 09:09:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 938D1CE27F2; Fri, 8 Mar 2024 09:09:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B6C6C433C7; Fri, 8 Mar 2024 09:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709888965; bh=v16FgxoD4jrKW4DEZ2p6BiXqbxPb+7o/1XZr+zdbld8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sy+YczvDG6c2AeBXhxb5VElBD0BrCFbb0Q74TH3cp5WXlCVitaxCh9lCXgApm3b7A 46oflEALayLxbh5FA6XFYkkZMGd1C4955wle9QBfzPi7tO4QCvWODlo93CK7cl+xqm 2yec3of5kSvv96OrGHnan4dtE/zAwMIK6iOpwIUNKaaAmVWDmAbGNTeXFFNChcQRbw kTlKmH2KPRySP4S7Fmr4g8bTEfVSjvrwfwVIMBceaVBTGJ54NZ5X88To+TH1Dnd75d sacCq75SHdHlJWW4+K/7HbJMC+gktckqawSjz+rnZVbpEbnO5ah6SzQieh0jTyAwZ4 KzDmymh50vDIA== Date: Fri, 8 Mar 2024 10:09:21 +0100 From: Lorenzo Pieralisi To: Jens Wiklander Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla , Marc Bonnici , Olivier Deprez Subject: Re: [PATCH] firmware: arm_ffa: fix ffa_notification_info_get() Message-ID: References: <20240307092104.937440-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240307092104.937440-1-jens.wiklander@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_010930_679132_5081CAB0 X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 07, 2024 at 10:21:04AM +0100, Jens Wiklander wrote: > FFA_NOTIFICATION_INFO_GET retries information about pending s/retries/retrieves/ > notifications. Notifications can be either global or per VCPU. Global > notifications are represented by the VM ID only, or 0 in the absence of > a hypervisor. I would just say "Global notifications are reported with the partition ID only in the list of endpoints with pending notifications". > ffa_notification_info_get() incorrectly expect no ID at all > for global notifications. Fix this by checking for 1 ID instead of 0. > > Fixes: 3522be48d82b ("firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface") > Signed-off-by: Jens Wiklander > --- > drivers/firmware/arm_ffa/driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Lorenzo Pieralisi > diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c > index c183c7d39c0f..ff1f37a4b28c 100644 > --- a/drivers/firmware/arm_ffa/driver.c > +++ b/drivers/firmware/arm_ffa/driver.c > @@ -790,7 +790,7 @@ static void ffa_notification_info_get(void) > > part_id = packed_id_list[ids_processed++]; > > - if (!ids_count[list]) { /* Global Notification */ > + if (ids_count[list] == 1) { /* Global Notification */ > __do_sched_recv_cb(part_id, 0, false); > continue; > } > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel